chore(cli): don't ask questions during publish when --non-interactive is specified (#5002)

[iansu]

Summary

Running publish with --non-interactive should not prompt for input and should fail if required args like --new-version are not provided.

Fixes #5002

Test plan

• Run yarn publish --non-interactive and see error message about not providing --new-version
• Delete NPM token, run yarn publish --non-interactive --new-version=1.0.1 and see error message about not being able to ask for login due to --non-interactive flag

[buildsize]

This change will increase the build size from 10.39 MB to 10.4 MB, an increase of 2.03 KB (0%)

File name	Previous Size	New Size	Change
yarn-[version].noarch.rpm	900.2 KB	900.41 KB	220 bytes (0%)
yarn-[version].js	3.91 MB	3.92 MB	754 bytes (0%)
yarn-legacy-[version].js	4.06 MB	4.06 MB	831 bytes (0%)
yarn-v[version].tar.gz	905.32 KB	905.51 KB	195 bytes (0%)
yarn_[version]all.deb	669.15 KB	669.22 KB	74 bytes (0%)

[gandazgul]

What if instead of requiring --new-version it publishes as is? I'm still using npm publish because I can't use yarn publish from CI.

[castarco]

Maybe the branch of this PR should be rebased to avoid having a broken commit. Having broken commits is a problem when someone tries to do a git bisect search.

[bestander]

Thanks, @iansu, very much appreciated!

[bestander]

@castarco, we squash commits when merge, so it should not be a problem

[bestander]

@gandazgul, I think there is a separate issue open for your point.
I actually would like to have an ability to bump version and publish as separate commands

[adamscybot]

@iansu I think this has caused a regression.

should fail if required args like --new-version are not provided.

In previous versions, version is not a required field. See this PR #3103 and the related issue it fixed which enabled --new-version to not be specified #3011.

This functionality allows people who are doing things like publishing from shell scripts or CI to use yarn to publish.

[adamscybot]

Scratch that, looks like I confused some similar sounding issues. Looks like it has never been possible to skip version bump.

[rafambbr]

yarn publish --registry=http://mynexus:8081/repository/yarn-repo/ --access public --non-interactive --new-version 0.0.4

[janosh]

There should be a non-interactive mode that doesn't require passing in a new version. What if the version was already bumped beforehand?

[merceyz]

Create a new issue, please don't bump a three year old PR