Skip to content

The CompositeMultiOracle reports zero updateTime #2

Open

Description

@alcueca

Check with DAI and ENS.

image

The bug itself is harmless, as it happens in the CompositeMultiOracle. If any of our external data providers sends stale data we revert at that point. The CompositeMultiOracle aggregates data feeds and should return the earliest updateTime, but there is no logic anywhere saying that it reverts when prices are too old, leaving this to the underlying data providers instead.

Maybe when redeploying the fixed CompositeMultiOracle, we can introduce a governance variable to revert when data is older than a given threshold, although that is risky in itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions