This repository was archived by the owner on May 22, 2025. It is now read-only.
Emote cooldown framework (no more spam) - #7372
Merged
Merged
Conversation
alexkar598
suggested changes
Dec 23, 2019
Contributor
Author
|
Testing Alex's changes before I commit. |
Co-Authored-By: alexkar598 <25136265+alexkar598@users.noreply.github.com>
Co-Authored-By: alexkar598 <25136265+alexkar598@users.noreply.github.com>
I think its more ugly now but whatever Alex you're the maintainer.
Contributor
Author
|
Committed changes. |
alexkar598
suggested changes
Dec 29, 2019
alexkar598
reviewed
Jan 6, 2020
| if(P.run_emote(src, param, m_type, intentional)) | ||
| return | ||
| if(intentional) | ||
| SEND_SIGNAL(src, P, act, m_type, message, intentional) |
Member
There was a problem hiding this comment.
No like just delete this line
Suggested change
| SEND_SIGNAL(src, P, act, m_type, message, intentional) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in a emote cooldown framework.
This means that emotes cannot be spammed anymore.
By default, a single emote cannot be repeated until 0.4 seconds have passed.
This an emote property and is able to be set per emote.
I left *flip and *spin spam able because it's sacred and must be preserved.
I used this new emote delay framework to set *deathgasp emote delay to 3.4 seconds.
Why i did this: I remember how angry AI's sometimes spam their death sound every 0.01 seconds on a macro. This change removes this.
yes, I cannibalized parts of TG code for this PR and edited it to fit in our codebase.
EDIT: Nich found what PR this was from:
This was cannibalized from tgstation/tgstation#47868
Changelog
🆑 Ninjanomnom , Hopek
rscadd: Emote cooldown framework has been added. This means you cannot spam a single emote in rapid succession (sorry macro kiddies)!
rscadd: Used this new emote cooldown framework to add a longer delay to *deathgasp . Take that spamming silicons!
/:cl: