fix: corrected horizontal slip judgment - #8387
Merged
Merged
Conversation
|
🎊 PR Preview bd4eaf9 has been successfully built and deployed to https://youzan-vant-preview-pr-8387.surge.sh 🕐 Build time: 82.111s 🤖 By surge-preview |
Contributor
Author
|
哎呀,忘了跑用例了。晚点看看 |
Member
|
实现上没问题,用例可以再跑一下~ |
chenjiahan
approved these changes
Mar 22, 2021
Contributor
Author
|
只有触发到 Safari 的后退事件的时候才能出现。 |
Member
|
screenX 这个值不是很常用,从语义上来说,是 clientX 更加合理的 |
Contributor
Author
|
看了一下关于
看了一下用例没跑过的地方,都触发了 看到模拟事件触发 的代码,是直接将事件参数 这个用例的初衷是啥? |
Member
|
这里 triggerDrag -50 的用例确实是不对的,可以顺便修正下~ |
added 2 commits
March 23, 2021 19:49
Contributor
Author
|
我理解
|
chenjiahan
approved these changes
Mar 23, 2021
Member
|
👍👍👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #8386
修复在 ios safari 中「手势返回」误触「右滑操作」的 bug