Repository navigation
feat(zarr-metadata): re-export each v3 extension package's submodule names - #4588
Merged
d-v-b merged 5 commits intoNov 1, 2026
Merged
Conversation
…names `zarr_metadata.v3.data_type`, `.codec`, `.chunk_grid` and `.chunk_key_encoding` export every name their submodules export, so `from zarr_metadata.v3.data_type import BoolDataTypeName` works again, as it did before 0.6.0 (downstream zarrista imports the data type names that way). Each submodule stays the name's home: the packages are aliases, like the top-level namespace and the format front doors, and a new test pins that each re-exports exactly its submodules' names as the same objects. The naming checks skip the alias packages, whose names they already check in the submodules. Assisted-by: ClaudeCode:claude-opus-5-5
github-actions
Bot
added
needs release notes
Documentation build overview
14 files changed ·
|
…r-developers#4588 Assisted-by: ClaudeCode:claude-opus-5-5
…v3-package-reexports # Conflicts: # packages/zarr-metadata/src/zarr_metadata/v3/codec/__init__.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4588 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 96 96
Lines 13998 13998
=======================================
Hits 13276 13276
Misses 722 722 🚀 New features to boost your workflow:
|
d-v-b
added a commit
to d-v-b/zarr-python
that referenced
this pull request
Nov 2, 2026
Resolve the rename against the four zarr-metadata changes main gained: the ZARR_PYTHON_CONTEXT scope and the *_CONTEXT constant names (zarr-developers#4583), the v3 submodule re-exports (zarr-developers#4588), the Hypothesis strategies (zarr-developers#4575) and the docstrings for every public object (zarr-developers#4590). Every conflict was the rename on one side and new upstream text on the other, so each is resolved as the upstream text with the rename applied. The rename is carried into upstream's additions: the new docstrings say "field" for a JSON key and "declaration" for an extension-point value, and the strategies module's `fields` strategy is `declarations`, with `FieldForm` now `DeclarationForm` in its tests. The zarr-developers#4575 changelog fragment uses the new name, since neither name has been released. Assisted-by: ClaudeCode:claude-fable-5-1 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
d-v-b
added a commit
to d-v-b/zarr-python
that referenced
this pull request
Nov 2, 2026
This branch was squash-merged upstream as zarr-developers#4575 (4a72dd4), whose tree matches this branch's head. Each conflict is main's later change to the same files (zarr-developers#4583, zarr-developers#4588, zarr-developers#4590, zarr-developers#4592), so every file takes main's side, and the branch now matches main. Assisted-by: ClaudeCode:claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d-v-b
added a commit
to d-v-b/zarr-python
that referenced
this pull request
Nov 4, 2026
The base branch added private base64 helpers in `_byte.py`. Define the public `base64_fill_value_rules` there, on top of `base64_problems`, instead of in `_numpy.py`, and take the base's versions of `null_terminated_bytes`, `_numpy.py` and the v2 rules. Re-export the rule from `zarr_metadata.v3.data_type`, as zarr-developers#4588 requires of every submodule name, and say "nested declarations" in the docs example, as zarr-developers#4592 does. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that
zarr_metadata.v3.data_type,.codec,.chunk_gridand.chunk_key_encodingexport every name their submodules export, sofrom zarr_metadata.v3.data_type import BoolDataTypeNameworks again. This undoes breakage induced by 0.6.0 (downstream zarrista imports the data type names that way). The packages are aliases, like the top-level namespace and the format front doors. A new test pins that each re-exports exactly its submodules' names as the same objects. Naming checks skip the alias packages, since they already check names n the submodules.Assisted-by: ClaudeCode:claude-opus-5-5
For reviewers
blast radius confined to zarr-metadata, so self-merge-worthy
Author attestation
TODO
docs/user-guide/*.mdchanges/