Repository navigation
feat(zarr-metadata): draw nested fields and codec pipelines - #4597
Merged
d-v-b merged 10 commits intoNov 4, 2026
Merged
Conversation
github-actions
Bot
added
needs release notes
Add Hypothesis strategies for struct, cast_value and sharding_indexed, which draw the fields they hold from the same Strategies mapping, and a `pipelines` strategy that walks a codec pipeline, drawing each codec for the chunk the codec before it hands on via its definition's transition. A shard's inner and index pipelines are drawn for the chunks its definition's `pipelines` gives. Shards and structs nest at most one level deep, and strategies are wrapped in a mapping with a short repr so Hypothesis's error notes stay under its 30,000-character warning. Every strategy record's functions now take the Strategies mapping as their last argument. Assisted-by: ClaudeCode:claude-opus-5-5
`NOT_NUMBERS` predates the zarr-python data types, so `cast_value` and `scale_offset` accepted `fixed_length_utf32`, `null_terminated_bytes`, `raw_bytes` and `variable_length_bytes`, and the strategies drew them. The cast_value spec defines the codec only for floating-point and integral data types. Assisted-by: ClaudeCode:claude-opus-5-5
`_scope` documented this but raised `ScopeConflictError`, so `declarations` failed for any definition named as a default, which worked before this branch. Pipelines and data type names now draw only the definition that claims a name, and `declarations` reads a draw with its own definition claiming the name. Assisted-by: ClaudeCode:claude-opus-5-5
The test compared a draw with the bare name, which depended on the example Hypothesis returned and said nothing of which definition read it. Every spelling is now read by the definition it was drawn for. Assisted-by: ClaudeCode:claude-opus-5-5
…s after zarr-developers#4597 Assisted-by: ClaudeCode:claude-opus-5-5
Documentation build overview
|
d-v-b
force-pushed
the
claude/zarr-metadata-nested-strategies
branch
from
November 3, 2026 21:20
c6f10be to
747a4c0
Compare
The struct and shard strategies removed the default definition by identity before drawing what they hold. A custom definition with the same name stayed in the inner strategies, so it could claim the name there and be drawn, and the default then refused the result with a ValueError. Filter by name instead. Assisted-by: ClaudeCode:claude-opus-5-5
d-v-b
marked this pull request as ready for review
November 3, 2026 21:46
A run held at most 4 chunks, so the `[size, count]` spelling was never drawn for what it is for, and a long dimension was covered by a few small chunks and one huge one. Draw counts sized to the dimension, and always write a run too long to list as a pair. Reach tests now cover each spelling of a dimension, not only that a pair is drawn at all. Assisted-by: ClaudeCode:claude-opus-5-5
…ds evenly A measured audit found strategies that drew valid metadata from little of what they could. Hex float fills came from a small-biased integer, so 83% of float64 fills were subnormal and few were normal. Integer float fills stopped at the limit of the narrowest type. Rectilinear edges rarely shared a factor, so 70% of a shard's axes held inner chunks of length 1. A struct field's type was drawn after its name, which made the first data type about a fifth of all fields. Draw hex fills from floats, infinities and NaN payloads as well as raw bits, limit integers by width, draw edges with a common factor, and draw a field's type first. Divisor search is now bounded, so a very long shard no longer takes billions of steps. New tests measure shares at the number of examples a test runs, which plain reach tests do not see. Assisted-by: ClaudeCode:claude-opus-5-5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4597 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 96 96
Lines 13997 13997
=======================================
Hits 13275 13275
Misses 722 722 🚀 New features to boost your workflow:
|
… size Axes can be up to 2**63 - 1 long, but regular and bare rectilinear chunk lengths reached twice that, which a reader indexing with int64 cannot hold. Cap them. A rectilinear last edge needs no cap: the runs before it cover at least one factor, so rounding up cannot pass the axis. Correct two docstrings, and require a covering run to count more than one chunk in its reach test, since the leftover edge passed it on its own. Assisted-by: ClaudeCode:claude-opus-5-5
An offset and a scale are fill values of the chunk's data type, but the strategy drew only finite floats, and never an integer spelling. It now draws every spelling a fill value takes, and still never a scale of zero. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds strategies to
zarr_metadata.testing.strategiesfor definitions that nest other stuff, namelystruct,cast_valueandsharding_indexed. Adds a newpipelinesstrategy for theChunkabstraction.Author attestation
TODO
docs/user-guide/*.mdchanges/