Skip to content

Feature/private polygons - #34

Open
petrafran wants to merge 28 commits into
masterfrom
feature/private-polygons
Open

petrafran wants to merge 28 commits into
masterfrom
feature/private-polygons

Conversation

@petrafran

@petrafran petrafran commented Nov 21, 2022 •

Copy link
Copy Markdown
Contributor

Description

⛑️ What was done:

  • New Scaffolding and routing
  • 4, 6, and 10 public point polygons
  • 4, 6, and 10 private point polygons
  • Uploaded zkey/wasm to pinata
  • Warning about max number of polygons (10 points max)

🎫 Ticket:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Ready to merge

🧪 How to test:

🗒️ Notes:

  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Closes #(issue)

@vercel

vercel Bot commented Nov 21, 2022 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 5:34pm

@BlakeMScurr BlakeMScurr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, I still have a lot to read!

Comment thread README.md Resolved
{
"indexed": true,
"internalType": "bool",
"name": "isVerifie",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed you fixed this in the other pr. Is this out of date?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need to update these files, but first, we should wait to see if we need to redeploy from:
zkMaps/zkMaps#43
zkMaps/zkMaps#44

Comment thread packages/react-app/src/hooks/FlyTo.js Resolved
Comment thread packages/react-app/src/index.jsx Resolved
Comment thread packages/react-app/src/App.jsx Outdated
<Route exact path="/create">
<CreateZone {...routeProps} />
</Route>
<Route exact path="/ethdenver">

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's /ethdenver for? Why does it just have the same stuff as Home?

@petrafran petrafran Nov 26, 2022 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ethdenver has the map we released for the hackathon.

Comment thread packages/react-app/src/App.jsx Resolved

This branch was successfully deployed

2 active deployments
Production — 48d327f7 Deployed Jun 7, 2023 by vercel[bot]
Preview — 48d327f7 Deployed Jan 24, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants