This repository was archived by the owner on Jul 16, 2026. It is now read-only.
Repository navigation
Conversation
…ct lists (sonichi#1257) slack-bridge was the only messaging bridge not covered by health-check's "multiple processes" detector or by --fix's stale-bridge resurrection path. Tonight on the Mac Studio core, slack-bridge had two PIDs (a launchd-managed instance 21min old and a standalone-launched instance 7 days old), and the warn surfaced only after manual pgrep — not via health-check. This adds slack-bridge to: - the configured-bridge iteration tuple at line 821 (so the detector fires for it), and - the auto-resurrect tuple at line 1270 (so --fix knows to resurrect it when stale). Verified locally: after the patch, health-check emits ⚠ slack-bridge warn multiple processes (2 PIDs: 52298,87616) on the host where it was previously silent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bassilkhilo-ag2
approved these changes
May 27, 2026
bassilkhilo-ag2
left a comment
bassilkhilo-ag2
left a comment
There was a problem hiding this comment.
Clean fix — adds slack-bridge to both the dup-process detector and the --fix resurrection path, exactly matching the existing telegram/discord entries. The companion PR in sonichi/sutando (sonichi#1257) is the deeper root-cause guard; this PR closes the observability gap regardless of root cause. LGTM.
2 tasks
|
Same two-line change as PR #92 (jgluck96). Whichever merges first, the other will be a no-op (or trivial conflict). Worth closing one to avoid confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tonight on the Mac Studio core,
slack-bridgehad two simultaneously-running processes (a launchd-managed instance ~21 min old and a standalone-launched instance ~7 days old) — buthealth-check.pyreported onlytelegram-bridgeanddiscord-bridgewarnings, because slack-bridge was missing from both:src/health-check.py:821--fixauto-resurrection tuple atsrc/health-check.py:1270Adding
slack-bridgeto both restores parity. The detector and resurrect paths are otherwise identical — samepgrep -f '<name>\.py$'anchor, same~/.claude/channels/<name>/env gating.Verification
Before the patch on the affected host:
After the patch on the same host (no other changes):
Context
Companion to sonichi#1257 (root-cause fix proposes
fcntl.flocksingle-instance guards inside the bridge processes themselves). This PR is the smaller of the two — closing the observability gap so dup-bridge regressions are visible regardless of which root cause they originate from.Test plan
python3 src/health-check.pyflags slack-bridge dup--fixpath on a host with a stale (down) slack-bridge🤖 Generated with Claude Code