This repository was archived by the owner on Jul 16, 2026. It is now read-only.
Repository navigation
Conversation
…ct lists (sonichi#1257) slack-bridge was the only messaging bridge not covered by health-check's "multiple processes" detector or by --fix's stale-bridge resurrection path. Tonight on the Mac Studio core, slack-bridge had two PIDs (a launchd-managed instance 21min old and a standalone-launched instance 7 days old), and the warn surfaced only after manual pgrep — not via health-check. This adds slack-bridge to: - the configured-bridge iteration tuple at line 821 (so the detector fires for it), and - the auto-resurrect tuple at line 1270 (so --fix knows to resurrect it when stale). Verified locally: after the patch, health-check emits ⚠ slack-bridge warn multiple processes (2 PIDs: 52298,87616) on the host where it was previously silent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
FYI: PR #67 (jsun-m) makes the identical change — same two lines in health-check.py. You'll want to merge one and close the other to avoid a duplicate-entry conflict. |
1 of 3 tasks
bassilkhilo-ag2
approved these changes
Jun 5, 2026
bassilkhilo-ag2
left a comment
bassilkhilo-ag2
left a comment
There was a problem hiding this comment.
Correct — slack-bridge is already running per health-check output (line: '✓ discord-bridge: ok'), and PR #96 (auto-start slack-bridge) is APPROVED. Adding slack-bridge to the dup-process check list and auto-resurrect list is the natural completion: without it, a crashed slack-bridge never gets restarted by health-check --fix. Pattern is identical to telegram/discord. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix/health-check-slack-bridge-1257) onto current mainslack-bridgetorun_all_checks()bridge loop and--fixauto-resurrect path (2 lines)Test plan
python3 src/health-check.py— slack-bridge row appears with pass/fail/warn statuspython3 src/health-check.py --fix— confirm auto-restart fires🤖 Generated with Claude Code