Repository navigation
fix(ci): Windows shared tests and std::expected on Linux - #26
Merged
Merged
Conversation
On Windows a shared aether_core.dll was built next to its own CMakeLists, away from aether_core_tests.exe, so the test failed to start (0xc0000135) when doctest discovered its cases. All runtime outputs now go to <build>/bin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JfRmXnowFEecvNmG9b9szy
ubuntu-24.04 ships clang up to 18 with libstdc++ 13, whose <expected> clang 18 cannot use. The Ubuntu 26.04 image ships clang 20 to 22 with a newer libstdc++, so std::expected builds without installing a toolchain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JfRmXnowFEecvNmG9b9szy
XavierBeheydt
added
scope: build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI failures, one already on
dev, one blocking #25:dev(run 42508204135, after feat(core): module scaffold, type aliases and export header #23 and ci: GitHub Actions on Linux and Windows, static and shared #24 were merged; each was green on its own).aether_core.dllwas built in its own directory, away fromaether_core_tests.exe, so the test could not start (0xc0000135) when doctest discovered its cases.CMAKE_RUNTIME_OUTPUT_DIRECTORYnow puts all executables and DLLs in<build>/bin.std::expected(feat(core): std::expected error handling #25): theubuntu-24.04image has clang up to 18 with libstdc++ 13, whose<expected>clang 18 rejects. The Linux jobs and the format job move toubuntu-26.04, which ships clang 20, 21 and 22, so no toolchain install step is needed.Verification
x64-debug-clangandx64-debug-clang-sharedconfigure, build, and pass 5/5 tests; the test executable lands inout/build/<preset>/bin.std::expectedon Ubuntu 26.04 is proven when feat(core): std::expected error handling #25 is updated with this fix.🤖 Generated with Claude Code
https://claude.ai/code/session_01JfRmXnowFEecvNmG9b9szy