Repository navigation
style: put attributes on their own line above the declaration - #35
Merged
Merged
Conversation
clang-format left the attribute placement to the author (BreakAfterAttributes: Leave), so both forms could mix. Always puts [[nodiscard]] and the other attributes on their own line, so a signature always starts with its return type. It also applies to attributes on variables. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JfRmXnowFEecvNmG9b9szy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.clang-formatinheritedBreakAfterAttributes: Leave, so[[nodiscard]] Result<T> f();and the two-line form could both appear. It is nowAlways:A signature always starts with its return type, which reads better in a diff. The option also applies to attributes on variables (
[[maybe_unused]]goes on its own line too).cpp.mdstates the rule.Verification
clang-format --dump-configshowsBreakAfterAttributes: Always.devis unchanged by it (clang-format --dry-run --Werrorclean).🤖 Generated with Claude Code
https://claude.ai/code/session_01JfRmXnowFEecvNmG9b9szy