Repository navigation
fix(template-generator): align d1 setup instructions - #1066
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThis PR conditions database script generation and README documentation on D1+Alchemy mode. When ChangesD1+Alchemy Conditional Script and Setup Handling
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e62df2462
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| steps.push(`${steps.length + 1}. Create and apply Prisma migrations locally: | ||
| \`\`\`bash | ||
| ${packageManagerRunCmd} db:migrate | ||
| \`\`\``); |
There was a problem hiding this comment.
Add the missing Prisma D1 migration DATABASE_URL
For Prisma + Cloudflare D1 projects, this new README step tells users to run db:migrate, but the generated env files do not define DATABASE_URL for D1 (processors/env-vars.ts only emits it when dbSetup === "none"), while the Prisma SQLite config still reads env("DATABASE_URL") from templates/db/prisma/sqlite/prisma.config.ts.hbs. A fresh D1 project following these instructions will fail the migration command before creating migrations unless the user guesses and adds a local SQLite URL; please either document that prerequisite here or avoid instructing users to run the command without it.
Useful? React with 👍 / 👎.
Summary
db:pushfrom generated D1 + Cloudflare projects so local SQLite push is not presented as D1 setupDBbinding vs localDATABASE_URL, and list D1 migration commandsFixes #1035
Verification
bun run checkbun run build:clidb:push, while README points todb:generate/db:migrateand the D1DBbindingSummary by CodeRabbit
Release Notes
Documentation
Improvements