Skip to content

Avoid db:local script for D1 database - #362

Merged
AmanVarshney01 merged 4 commits into
AmanVarshney01:mainfrom
martinnormark:patch-1
Jun 30, 2025
Merged

AmanVarshney01 merged 4 commits into
AmanVarshney01:mainfrom
martinnormark:patch-1

Conversation

@martinnormark

@martinnormark martinnormark commented Jun 29, 2025 •

Copy link
Copy Markdown
Contributor

I believe the db:local script is not needed when Cloudflare D1 was selected?

Summary by CodeRabbit

  • Chores
    • Refined when the "db:local" script appears in the server configuration, ensuring it is only included under more specific conditions.
    • Updated local development instructions for SQLite to reflect automatic handling when using Cloudflare D1.

@changeset-bot

changeset-bot Bot commented Jun 29, 2025 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2cd7f38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-better-t-stack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 29, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

The logic for including the "db:local" script in the server's package.json was updated. Now, the script is only added if the database is "sqlite", the ORM is "drizzle", and the database setup option is not "d1", further restricting when this script appears. Additionally, the README generation was modified to provide different local development instructions for the "d1" database setup versus other SQLite setups.

Changes

File(s) Change Summary
apps/cli/src/helpers/project-generation/project-config.ts Refined condition for adding "db:local" script: now requires database ≠ "d1" in addition to previous checks.
apps/cli/src/helpers/project-generation/create-readme.ts Updated generateDatabaseSetup to handle new dbSetup parameter; changed SQLite local dev instructions for "d1" setup.
.changeset/itchy-bikes-sit.md Added changeset documenting avoidance of "db:local" script for the "d1" database setup.

Possibly related PRs

  • Add D1 Database #335: Introduced foundational support for the "d1" database setup, including environment setup, validation, prompts, templates, and configuration, laying groundwork for the current refinements.

Poem

In the warren where configs grow,
A script appears, but not for show.
Only when the stars align,
Sqlite, drizzle—never d1’s sign.
Rabbits code with careful paw,
Tidy logic, without flaw! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 436fe08 and 2cd7f38.

📒 Files selected for processing (1)
  • .changeset/itchy-bikes-sit.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changeset/itchy-bikes-sit.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AmanVarshney01

Copy link
Copy Markdown
Owner

Thanks @martinnormark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants