Skip to content

Make the in-flight modal dismissal test deterministic #462

Open

Description

@hpmaxi

Priority

Low

User story / Problem statement

One app test fails now and then when the whole suite runs in parallel, and passes on its own: the case in app/src/pages/VaultPreview.test.tsx that dismisses the transaction modal while a transaction is still in flight. It showed up in several local runs of npm run test while working on #458-#461, in code those changes do not touch. A failure that comes and goes teaches people to rerun instead of read.

Expected outcome

The test passes or fails the same way every run.

Acceptance criteria

  • The cause is identified (for example a timer, an unawaited promise, or shared state between tests)
  • The test is deterministic under the full parallel run, checked over repeated runs

Technical notes

Fails under full parallel load; passes standalone and when its file runs alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions