Skip to content

feat(compliance): remove a module in wind-down - #461

Merged
hpmaxi merged 4 commits into
tranche-3from
feat/437-remove-module-in-wind-down
Nov 17, 2026
Merged

hpmaxi merged 4 commits into
tranche-3from
feat/437-remove-module-in-wind-down

Conversation

@hpmaxi

@hpmaxi hpmaxi commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #437

A wind-down cannot be cancelled and refuses governance changes. A compliance module that fails on burn would then block every claim for good. Governance can now remove a module during a wind-down, after the normal delay.

Changes

  • The compliance contract lets RemoveModule be proposed and applied during a wind-down, with the normal timelock, the same way the share token already lets the compliance grant through. Every other change is still refused.
  • Docs: the authorization matrix, the grant differences, the threat model (X6 states that governance may remove any module, failing or not, and what a compromised governance could do with it), the STRIDE document, the design document and TESTING; the vault's module doc.

Deviations

  • The issue placed the change in the share token. RemoveModule is a change of the compliance contract, which the share token cannot express, so the exception lives in contracts/compliance/src/governance.rs.

Acceptance criteria

  • RemoveModule can be queued and executed while a wind-down is active, with the normal delay
  • A test covers it

Test plan

Automated tests

  1. cargo test --workspace --locked, clippy -D warnings, cargo fmt --check, cargo deny check, and the Wasm upgrade tests: pass. New tests: removing a module during a wind-down waits the delay and lands; other compliance changes are still refused.
  2. Root npm run lint, format:check, typecheck, test: pass.
  3. On a local network: deploy and the scenarios in CI order, plus test:queue: pass.

Manual verification

None.

Breaking changes

None.

Checklist

  • Self-reviewed my own diff
  • Tests added or updated
  • Docs updated (if applicable)
  • No unrelated changes bundled in

Screenshots

None.

@hpmaxi
hpmaxi requested a review from luchobonatti November 16, 2026 23:57
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
strata-vault-kit-app Ready Ready Preview Nov 16, 2026 11:57pm UTC

Request Review

@hpmaxi
hpmaxi merged commit bc6e4de into tranche-3 Nov 17, 2026
10 checks passed

This branch was successfully deployed

1 active deployment
Preview — ae312533 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants