Repository navigation
feat(compliance): remove a module in wind-down - #461
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Nov 16, 2026
Draft
luchobonatti
approved these changes
Nov 17, 2026
7 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #437
A wind-down cannot be cancelled and refuses governance changes. A compliance module that fails on burn would then block every claim for good. Governance can now remove a module during a wind-down, after the normal delay.
Changes
RemoveModulebe proposed and applied during a wind-down, with the normal timelock, the same way the share token already lets thecompliancegrant through. Every other change is still refused.Deviations
RemoveModuleis a change of the compliance contract, which the share token cannot express, so the exception lives incontracts/compliance/src/governance.rs.Acceptance criteria
RemoveModulecan be queued and executed while a wind-down is active, with the normal delayTest plan
Automated tests
cargo test --workspace --locked, clippy-D warnings,cargo fmt --check,cargo deny check, and the Wasm upgrade tests: pass. New tests: removing a module during a wind-down waits the delay and lands; other compliance changes are still refused.npm run lint,format:check,typecheck,test: pass.deployand the scenarios in CI order, plustest:queue: pass.Manual verification
None.
Breaking changes
None.
Checklist
Screenshots
None.