[Bartok9]

Summary

• Redshift only stripped ; when wrapping with LIMIT.
• Unlimited path executed client terminators as-is.
• Strip unconditionally, then wrap if limited.

License

core/wren/** Apache-2.0.

Verification

python3 -m pytest core/wren/tests/unit/test_redshift_strip_unlimited_query.py -q

Summary by CodeRabbit

• Bug Fixes
  • Improved Redshift query execution by consistently handling trailing semicolons, including queries without a row limit.
  • Prevented formatting-related issues when submitting SQL statements to Redshift.
  • Added coverage to verify semicolon handling for unlimited queries.

[Bartok9]

Closing as duplicate of already-open #2482 (same unlimited-path strip). Sorry for the noise.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 894b51ea-fe4e-400f-b2a5-57dad818f769

📥 Commits

Reviewing files that changed from the base of the PR and between 3dac00a and dbb497b.

📒 Files selected for processing (2)

• core/wren/src/wren/connector/redshift.py
• core/wren/tests/unit/test_redshift_strip_unlimited_query.py

---

Walkthrough

Redshift query SQL is now stripped of trailing semicolons before optional limit wrapping. A unit test verifies that the unlimited-query path references and applies the stripping behavior.

Changes

Redshift SQL normalization

Layer / File(s)	Summary
Normalize and test Redshift queries core/wren/src/wren/connector/redshift.py, core/wren/tests/unit/test_redshift_strip_unlimited_query.py	query strips trailing semicolons before limit handling, and regression coverage validates the unlimited-query behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

• Strip trailing semicolon on the unlimited query() path across connectors #2497 — Directly covers stripping trailing semicolons on the Redshift unlimited query() path.

Possibly related PRs

• Canner/WrenAI#2407 — Applies the same semicolon normalization pattern before SQL wrapping.
• Canner/WrenAI#2489 — Adds analogous unlimited-query semicolon stripping and regression coverage.
• Canner/WrenAI#2534 — Aligns connector query() implementations around unconditional trailing-semicolon removal.

Poem

A rabbit found a semicolon bright,
Trailing at the query’s flight.
Strip it clean before limits hop,
Tests stand guard and never stop.
Redshift now runs smooth and neat—
Thump, thump, query complete!

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}