Repository navigation
feat(evidence): record completed break-glass review - #125
Merged
seonghobae merged 12 commits intoSep 4, 2026
Merged
seonghobae merged 12 commits into
seonghobae merged 12 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 12, 2026
Merge the current break-glass evidence prerequisite while retaining the completed-review receipt. Signed-off-by: Seongho Bae <me@seonghobae.me>
seonghobae
marked this pull request as ready for review
September 4, 2026 20:07
seonghobae
merged commit Sep 4, 2026
5c4eb5c
into
feat/sensitive-break-glass-evidence
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #10, stacked on PR #121.
Buyer/security gap
PR #121 records the mandatory post-event-review reference, due time, and retention deadline for one actual break-glass disclosure, but it deliberately does not prove that review occurred. A durable evidence owner needs a bounded credential-free review-completion receipt that remains recordable when review is late, binds to the exact break-glass receipt, prevents the disclosing actor from self-reviewing, and distinguishes compliant review from policy violation or incident escalation without carrying free-form sensitive findings.
Dependency / live alignment
Current exact #125 head is
4fd35204ba63d902edc4a65fee51417225964047; current exact prerequisite #121 head is6154bebb451e2a166b0ffb2a7ac913fd0d8f8d6c.This head merges the current prerequisite without rewriting history. Fresh comparison reports ahead 12 / behind 0, with merge base exactly the live prerequisite. The delta remains limited to five #125-owned paths:
CHANGELOG.md,crates/originweave-evidence/src/lib.rs,crates/originweave-evidence/src/sensitive_break_glass_review.rs,crates/originweave-evidence/tests/sensitive_break_glass_review_boundaries.rs, andcrates/originweave-evidence/tests/sensitive_break_glass_review_evidence.rs.Keep Draft while #121/#119/#90 and their prerequisites remain active. No prerequisite/predecessor check, review, status, coverage, mergeability, or synthetic-merge evidence transfers.
Implemented contract
SensitiveBreakGlassReviewEvidencebinds immutably to the exact request, decision, and mandatory review reference; requires a bounded reviewer identity distinct from the disclosing actor; enforces completion after disclosure and before retention expiry; records on-time or late completion; and validates outcome, finding count, and remediation reference without carrying free-form sensitive findings.Current-head verification
On exact head
4fd35204ba63d902edc4a65fee51417225964047against exact prerequisite6154bebb451e2a166b0ffb2a7ac913fd0d8f8d6c:cargo fmt --all -- --check: success;cargo test --locked --workspace --all-features: success;cargo clippy --locked --workspace --all-targets --all-features -- -D warnings: success;RUSTDOCFLAGS='-D warnings' cargo doc --locked --workspace --all-features --no-deps: success;The prior successful run
32108212412belongs to the previous head and is historical only. Security/SAST/central review workflows absent for this stacked Draft are absent, not passing. No predecessor-head, prerequisite-head, queued, pending, skipped, cancelled, stale, synthetic, status-only, or model-only evidence is promoted as current proof.Truth boundary
This slice is credential-free review metadata only. It does not authenticate the reviewer, prove organizational independence beyond exact identity inequality, inspect review content, prove remediation execution, persist or hash-chain evidence, enforce retention/deletion, close an incident, disclose protected data, implement the trusted broker, or close #10.
Passing automation is not independent approval. This scheduled actor does not merge, self-approve, alter workflows, add secrets, weaken checks, tag, or publish.