Skip to content

feat(evidence): record completed break-glass review - #125

Merged
seonghobae merged 12 commits into
feat/sensitive-break-glass-evidencefrom
feat/sensitive-break-glass-review-evidence
Sep 4, 2026
Merged

seonghobae merged 12 commits into
feat/sensitive-break-glass-evidencefrom
feat/sensitive-break-glass-review-evidence

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

Partial implementation of #10, stacked on PR #121.

Buyer/security gap

PR #121 records the mandatory post-event-review reference, due time, and retention deadline for one actual break-glass disclosure, but it deliberately does not prove that review occurred. A durable evidence owner needs a bounded credential-free review-completion receipt that remains recordable when review is late, binds to the exact break-glass receipt, prevents the disclosing actor from self-reviewing, and distinguishes compliant review from policy violation or incident escalation without carrying free-form sensitive findings.

Dependency / live alignment

Current exact #125 head is 4fd35204ba63d902edc4a65fee51417225964047; current exact prerequisite #121 head is 6154bebb451e2a166b0ffb2a7ac913fd0d8f8d6c.

This head merges the current prerequisite without rewriting history. Fresh comparison reports ahead 12 / behind 0, with merge base exactly the live prerequisite. The delta remains limited to five #125-owned paths: CHANGELOG.md, crates/originweave-evidence/src/lib.rs, crates/originweave-evidence/src/sensitive_break_glass_review.rs, crates/originweave-evidence/tests/sensitive_break_glass_review_boundaries.rs, and crates/originweave-evidence/tests/sensitive_break_glass_review_evidence.rs.

Keep Draft while #121/#119/#90 and their prerequisites remain active. No prerequisite/predecessor check, review, status, coverage, mergeability, or synthetic-merge evidence transfers.

Implemented contract

SensitiveBreakGlassReviewEvidence binds immutably to the exact request, decision, and mandatory review reference; requires a bounded reviewer identity distinct from the disclosing actor; enforces completion after disclosure and before retention expiry; records on-time or late completion; and validates outcome, finding count, and remediation reference without carrying free-form sensitive findings.

Current-head verification

On exact head 4fd35204ba63d902edc4a65fee51417225964047 against exact prerequisite 6154bebb451e2a166b0ffb2a7ac913fd0d8f8d6c:

  • cargo fmt --all -- --check: success;
  • cargo test --locked --workspace --all-features: success;
  • cargo clippy --locked --workspace --all-targets --all-features -- -D warnings: success;
  • RUSTDOCFLAGS='-D warnings' cargo doc --locked --workspace --all-features --no-deps: success;
  • exact-head CI: pending.

The prior successful run 32108212412 belongs to the previous head and is historical only. Security/SAST/central review workflows absent for this stacked Draft are absent, not passing. No predecessor-head, prerequisite-head, queued, pending, skipped, cancelled, stale, synthetic, status-only, or model-only evidence is promoted as current proof.

Truth boundary

This slice is credential-free review metadata only. It does not authenticate the reviewer, prove organizational independence beyond exact identity inequality, inspect review content, prove remediation execution, persist or hash-chain evidence, enforce retention/deletion, close an incident, disclose protected data, implement the trusted broker, or close #10.

Passing automation is not independent approval. This scheduled actor does not merge, self-approve, alter workflows, add secrets, weaken checks, tag, or publish.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review September 4, 2026 20:07
@seonghobae
seonghobae merged commit 5c4eb5c into feat/sensitive-break-glass-evidence Sep 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant