Repository navigation
fix(internal/config): accept udp:// in DD_DOGSTATSD_URL - #5587
Open
kjvalencik wants to merge 1 commit into
Open
kjvalencik wants to merge 1 commit into
kjvalencik wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Using DD_DOGSTATSD_URL=udp://host:port reached the statsd client verbatim and failed to parse with "too many colons in address." This form is already established and documented by datadog-go. These changes match the behavior along with default hostname and port. parseDogstatsdAddr only recognized unix:// and otherwise used the value verbatim as the host, so DD_DOGSTATSD_URL=udp://host:port reached the statsd client as "udp://host:port" and failed with "too many colons in address". The tracer then ran without a statsd client, dropping its runtime, health and contrib metrics. udp:// is the form datadog-go documents for DD_DOGSTATSD_URL. Parse it to host:port, defaulting the port to 8125 as datadog-go does. The same parser backs WithDogstatsdAddr, so that option accepts udp:// too. Also fix comments that called the scheme-less host:port form TCP; datadog-go sends it over UDP.
kjvalencik
force-pushed
the
kj/dogstatsd-url-udp-scheme
branch
from
October 14, 2026 12:01
5c45c0d to
80bdccd
Compare
Member
|
/gardener shadow |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 13 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 80bdccd | Docs | View more details | Give us feedback! |
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
parseDogstatsdAddrnow acceptsudp://host[:port]. It turns the value into thehost:portforminternal/configuses. It matches the default host and port behavior of datadog-go.Additionally, it fixes comments that called the scheme-less
host:portform "TCP". datadog-go sends it over UDP.Motivation
Since #4796 (first released in v2.10.0, still present in v2.11.2), the tracer reads
DD_DOGSTATSD_URL. The parser only recognizedunix://. Any other value was used as the host verbatim. So the form datadog-go documents for this variable fails:The tracer logs
Runtime and health metrics disabled: …and continues with a no-op statsd client. Contrib statsd clients fail the same way. So there are nodatadog.tracer.*health metrics, no runtime metrics, and no contrib metrics.Reviewer's Checklist
make lintlocally. (golangci-lint run ./internal/config/...clean,make lint/errloganalyzers clean oninternal/config)make testlocally. (Rango test ./...on the root module, themake test/unitequivalent, all passing. Integration and contrib suites not run locally.)make generatelocally. (N/A: no generated files touched)make fix-moduleslocally. (N/A: no go.mod changes)