Repository navigation
fix(internal/config): accept udp:// in DD_DOGSTATSD_URL [shadow] - #5853
Draft
dd-gardener-apm-dcs-lp[bot] wants to merge 1 commit into
Draft
dd-gardener-apm-dcs-lp[bot] wants to merge 1 commit into
dd-gardener-apm-dcs-lp[bot] wants to merge 1 commit into
Conversation
Using DD_DOGSTATSD_URL=udp://host:port reached the statsd client verbatim and failed to parse with "too many colons in address." This form is already established and documented by datadog-go. These changes match the behavior along with default hostname and port. parseDogstatsdAddr only recognized unix:// and otherwise used the value verbatim as the host, so DD_DOGSTATSD_URL=udp://host:port reached the statsd client as "udp://host:port" and failed with "too many colons in address". The tracer then ran without a statsd client, dropping its runtime, health and contrib metrics. udp:// is the form datadog-go documents for DD_DOGSTATSD_URL. Parse it to host:port, defaulting the port to 8125 as datadog-go does. The same parser backs WithDogstatsdAddr, so that option accepts udp:// too. Also fix comments that called the scheme-less host:port form TCP; datadog-go sends it over UDP.
Contributor
Config Audit |
Contributor
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 13 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed 🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 80bdccd | Docs | View more details | Give us feedback! |
BenchmarksBenchmark execution time: 2026-11-09 15:35:57 Comparing candidate commit 80bdccd in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 400 metrics, 1 unstable metrics, 1 flaky benchmarks without significant changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shadow of #5587 (#5587), opened automatically by Gardener so trusted CI can run against the fork's changes from within this repository.
Opened on behalf of @darccio.