Fix for undertow versions > 2.2.40, 2.3.25 and 2.4.0#11844
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 9fbd0c2 | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81d352e8ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Older versions match the decoded servlet path on redispatch, | ||
| // while the newer RequestParser expects the raw encoded path; | ||
| // using the other form either misses the servlet mapping or hangs. | ||
| asyncContext.dispatch(hasNewRequestParser() ? ep.rawPath : req.servletPath) |
There was a problem hiding this comment.
Migrate touched Groovy test to JUnit 5
This patch adds new behavior to an existing Groovy/Spock test, but the root AGENTS.md for this tree says to use JUnit 5 and to migrate an existing Groovy test when it is written in Groovy. Please move this updated coverage to a JUnit 5 test instead of extending UndertowServletAsyncTest.groovy.
Useful? React with 👍 / 👎.
What Does This Do
following this CVE fix, the HTTP parser changed.
Motivation
LatestDepTests failed
Additional Notes
since the old parser was an abstract class and the new one is a
final, we cannot reuse the existingInstrumenter.ForTypeHierarchyinstrumentation and need to create a new class that inherits fromInstrumenter.ForSingleTypeinstead.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]