-
Notifications
You must be signed in to change notification settings - Fork 344
Fix for undertow versions > 2.2.40, 2.3.25 and 2.4.0 #11844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vandonr
wants to merge
5
commits into
master
Choose a base branch
from
vandonr/fix2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
356509b
bump undertow lockfile
vandonr b2d0fb6
instrument new parser class for undertow
vandonr 81d352e
adapt test setup to parser used
vandonr 9fbd0c2
Merge branch 'master' into vandonr/fix2
vandonr 969c584
Merge branch 'master' into vandonr/fix2
sarahchen6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
....0/src/main/java/datadog/trace/instrumentation/undertow/RequestParserInstrumentation.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| package datadog.trace.instrumentation.undertow; | ||
|
|
||
| import static datadog.trace.agent.tooling.bytebuddy.matcher.NameMatchers.named; | ||
| import static net.bytebuddy.matcher.ElementMatchers.isMethod; | ||
| import static net.bytebuddy.matcher.ElementMatchers.takesArgument; | ||
|
|
||
| import com.google.auto.service.AutoService; | ||
| import datadog.trace.agent.tooling.Instrumenter; | ||
| import datadog.trace.agent.tooling.InstrumenterModule; | ||
|
|
||
| @AutoService(InstrumenterModule.class) | ||
| public class RequestParserInstrumentation extends InstrumenterModule.Tracing | ||
| implements Instrumenter.ForSingleType, Instrumenter.HasMethodAdvice { | ||
| public RequestParserInstrumentation() { | ||
| super("undertow", "undertow-2.2", "undertow-request-parse"); | ||
| } | ||
|
|
||
| @Override | ||
| public String instrumentedType() { | ||
| // new class added in new minor versions in | ||
| // https://github.com/undertow-io/undertow/pull/1949/changes | ||
| // from 2.2.40, 2.3.25 and 2.4.0 | ||
| // not instrumenting the hierarchy like in its predecessor HttpRequestParserInstrumentation | ||
| // because RequestParser is marked final. | ||
| return "io.undertow.server.protocol.http.RequestParser"; | ||
| } | ||
|
|
||
| @Override | ||
| public void methodAdvice(MethodTransformer transformer) { | ||
| transformer.applyAdvice( | ||
| isMethod() | ||
| .and(named("handle")) | ||
| .and(takesArgument(2, named("io.undertow.server.HttpServerExchange"))), | ||
| HttpRequestParserInstrumentation.class.getName() + "$RequestParseFailureAdvice"); | ||
| } | ||
|
|
||
| @Override | ||
| public String[] helperClassNames() { | ||
| return new String[] { | ||
| packageName + ".HttpServerExchangeURIDataAdapter", | ||
| packageName + ".UndertowDecorator", | ||
| packageName + ".UndertowBlockingHandler", | ||
| packageName + ".IgnoreSendAttribute", | ||
| packageName + ".UndertowBlockResponseFunction", | ||
| packageName + ".UndertowExtractAdapter", | ||
| packageName + ".UndertowExtractAdapter$Request", | ||
| packageName + ".UndertowExtractAdapter$Response" | ||
| }; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch adds new behavior to an existing Groovy/Spock test, but the root
AGENTS.mdfor this tree says to use JUnit 5 and to migrate an existing Groovy test when it is written in Groovy. Please move this updated coverage to a JUnit 5 test instead of extendingUndertowServletAsyncTest.groovy.Useful? React with 👍 / 👎.