Skip to content

Migrate gulp js-bundles-watch to NX - #34308

Merged
GoodDayForSurf merged 16 commits into
DevExpress:feature/gulp-to-nx-migrationfrom
GoodDayForSurf:nx-migrate-gulp-js-bundles-watch
Jul 15, 2026
Merged

Migrate gulp js-bundles-watch to NX#34308
GoodDayForSurf merged 16 commits into
DevExpress:feature/gulp-to-nx-migrationfrom
GoodDayForSurf:nx-migrate-gulp-js-bundles-watch

Conversation

@GoodDayForSurf

Copy link
Copy Markdown
Contributor

No description provided.

@GoodDayForSurf GoodDayForSurf self-assigned this Jul 14, 2026
@vorobey
vorobey force-pushed the feature/gulp-to-nx-migration branch from 54e53e9 to 3872ff4 Compare July 15, 2026 08:17
…Express/DevExtreme into nx-migrate-gulp-js-bundles-watch

# Conflicts:
#	packages/nx-infra-plugin/AGENTS.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the DevExtreme gulp js-bundles-watch workflow to an Nx target by extending the devextreme-nx-infra-plugin:bundle executor with a long-running Webpack watch mode, and wiring new Nx targets / gulp delegates to use it.

Changes:

  • Added watch support to the Nx bundle executor (schema + implementation) and introduced a devextreme:bundle:watch target.
  • Implemented Webpack watch execution in the bundle executor and added an E2E test covering initial watch compilation.
  • Updated DevExtreme gulp tasks to delegate js-bundles-* to Nx and removed the legacy gulp implementation.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/nx-infra-plugin/src/executors/bundle/schema.ts Adds watch?: boolean to executor options typing.
packages/nx-infra-plugin/src/executors/bundle/schema.json Exposes watch option in the executor JSON schema.
packages/nx-infra-plugin/src/executors/bundle/executor.e2e.spec.ts Adds an E2E test to validate initial output in watch mode.
packages/nx-infra-plugin/src/executors/bundle/bundle.impl.ts Implements Webpack watch mode and reuses warning/error helpers.
packages/nx-infra-plugin/AGENTS.md Documents the gulp→Nx migration mapping for js bundle tasks.
packages/devextreme/project.json Adds bundle:watch target using the bundle executor in watch mode.
packages/devextreme/gulpfile.js Switches js bundle gulp tasks to Nx delegation and adds js-bundles-watch.
packages/devextreme/build/gulp/js-bundles.js Removes the old gulp-based js bundle build/watch implementation.

Comment thread packages/nx-infra-plugin/src/executors/bundle/bundle.impl.ts Outdated
Comment thread packages/devextreme/gulpfile.js Outdated
@vorobey
vorobey force-pushed the feature/gulp-to-nx-migration branch from 3872ff4 to 336fe8f Compare July 15, 2026 10:49
GoodDayForSurf and others added 3 commits July 15, 2026 12:55
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Aliullov Vlad <91639107+GoodDayForSurf@users.noreply.github.com>
…Express/DevExtreme into nx-migrate-gulp-js-bundles-watch

# Conflicts:
#	packages/nx-infra-plugin/AGENTS.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Comment thread packages/nx-infra-plugin/src/executors/bundle/bundle.impl.ts Outdated
@GoodDayForSurf
GoodDayForSurf requested a review from a team July 15, 2026 11:34
@GoodDayForSurf
GoodDayForSurf marked this pull request as ready for review July 15, 2026 11:44
Comment thread packages/nx-infra-plugin/src/executors/bundle/bundle.impl.ts
…Express/DevExtreme into nx-migrate-gulp-js-bundles-watch

# Conflicts:
#	packages/nx-infra-plugin/AGENTS.md
@GoodDayForSurf
GoodDayForSurf merged commit ba0a9ff into DevExpress:feature/gulp-to-nx-migration Jul 15, 2026
99 checks passed
vorobey added a commit that referenced this pull request Jul 16, 2026
Signed-off-by: Aliullov Vlad <91639107+GoodDayForSurf@users.noreply.github.com>
Co-authored-by: Andrey Vorobev <738482+vorobey@users.noreply.github.com>
ajivanyandev pushed a commit to ajivanyandev/DevExtreme that referenced this pull request Jul 16, 2026
Signed-off-by: Aliullov Vlad <91639107+GoodDayForSurf@users.noreply.github.com>
Co-authored-by: Andrey Vorobev <738482+vorobey@users.noreply.github.com>
vorobey added a commit that referenced this pull request Jul 17, 2026
Signed-off-by: Aliullov Vlad <91639107+GoodDayForSurf@users.noreply.github.com>
Co-authored-by: Andrey Vorobev <738482+vorobey@users.noreply.github.com>
vorobey added a commit that referenced this pull request Jul 27, 2026
Signed-off-by: Aliullov Vlad <91639107+GoodDayForSurf@users.noreply.github.com>
Co-authored-by: Andrey Vorobev <738482+vorobey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants