Repository navigation
Description
Phase 3 — MenuItemWithTopDescription replacement preset
Part of the MenuItem decomposition rollout plan. Phase 1 landed in #97339 (MenuItemNavigation / MenuItemAction), Phase 2 in #98862 (MenuItemAvatarNavigation), Phase 4 is tracked in #100159. This is the biggest and most invasive phase.
Scope
Replace MenuItemWithTopDescription — today a 3-line wrapper that just sets shouldShowBasicTitle + shouldShowDescriptionOnTop on the monolith — with a real field-row preset built on the composition primitives, and migrate its call sites.
This is the form/detail row used across the whole app: label on top, value below, inline errorText / hintText, and helperText outside the pressable.
Already in flight: #100191 (draft) introduces MenuItemField (replacing MenuItemEmptyField), splits the text leaves into Title / Description / FieldName / FieldNamePlaceholder / FieldValue over two shared bases, re-keys the accessibility slots by line (top/bottom) rather than role, and migrates ~107 sites across 55 screens. This issue tracks the whole phase, of which that PR is the first slice.
Verified inventory
At c408634: 439 <MenuItemWithTopDescription call sites across 219 files — comfortably the largest cluster in the plan, and ~2.5× the direct MenuItem count.
Prop counts below are occurrences within a 14-line window after each opening tag, so treat them as close approximations rather than exact — but the ordering is what matters for batching.
| Prop | ~Sites | Note |
|---|---|---|
brickRoadIndicator |
~105 | The single most common prop on this shape, and the compound API has no leaf for it yet. Heavily concentrated in workspace/accounting connection rows. |
interactive={false} |
~96 | Read-only detail rows — no press target, no chevron. Worth confirming these still render as a single a11y element. |
numberOfLinesTitle |
~54 | Almost always 1 or 2; belongs on MenuItem.FieldValue, not on the preset. |
errorText |
~32 | Renders inside the pressable at MenuItem.tsx:1274-1281. |
hintText |
~31 | Also inside the pressable, MenuItem.tsx:1283-1291. |
titleComponent |
~30 | Escape hatch — a caller-supplied node in the value slot. Candidate for MenuItem.Content children instead of a prop. |
copyValue |
~21 | Long-press-to-copy affordance. |
helperText |
~17 | Renders outside the pressable, MenuItem.tsx:1297-1304 — same inside/outside split shawnborton settled for the label. |
shouldRenderAsHTML |
~14 | Plus shouldParseTitle (~6) and shouldParseHelperText. |
furtherDetails |
~8 | Third text line. |
shouldShowRightComponent |
~4 | Long-tail — may belong in Phase 6. |
The gap this phase has to close
The compound surface exported from MenuItem/index.ts is currently Root / Row / Leading / Content / Trailing / Icon / Title / Description / DescriptionPlaceholder / Chevron / RightLabel. Three things the field shape needs have no primitive yet:
MenuItem.BrickRoadIndicator— aTrailingleaf. It's in the plan's original API sketch but hasn't been built, and it's the most-used prop on this shape.MenuItem.Error/MenuItem.Hint— the inlineFormHelpMessagepair, rendered insideRootbelow the row.- A home for
helperText— it sits outside the pressable, so it's a sibling ofRoot, exactly like the label inMenuItemWithLabel. Decide whether that's a preset concern or aMenuItem.HelperTextleaf.
Work
- Land
MenuItemWithTopDescriptiondecomposition - simplest usages #100191 —MenuItemFieldpreset + the text-leaf split + the ~107 simplest migrations. - Add the missing primitives above, each with a Storybook comparison card.
- Batch the remaining ~330 sites by prop shape, not by page — one PR per cluster, so each diff is the same decision reviewed once:
- plain
name+valuerows (largest, mostly covered byMenuItemWithTopDescriptiondecomposition - simplest usages #100191) interactive={false}read-only rowsbrickRoadIndicatorrows (the accounting-connection cluster)errorText/hintTextrowshelperTextrowstitleComponent/furtherDetails/ HTML-parsing escape hatches
- plain
- Extend the
MenuItemComparisongallery with a card per prop shape as each cluster lands. Per the plan, the gallery is the primary visual-parity gate for this phase — reach is highest here, so if every scenario is covered visually the broad migration is safe. - Verify accessibility per cluster. Field rows invert the announce order relative to navigation rows (
MenuItem.tsx:656branches onshouldShowDescriptionOnTop), andbrickRoadIndicatorappends "your review is required" at:663. Both behaviors must survive. - Deprecate
MenuItemWithTopDescriptiononce the count reaches zero, and dropshouldShowBasicTitle/shouldShowDescriptionOnTopfrom the monolith.
Out of scope
- The 3
HighlightableMenuItemWithTopDescriptionsites andHighlightableMenuItem/FocusableMenuItem/MenuItemList/ PopoverMenu v2 rows — Phase 5. - Layout style props (
outerWrapperStyle,innerContainerStyle, …) — Phase 4 ([$175] MenuItem decomposition Phase 4 — style-prop remnants #100159). Text-level style props (titleStyle,descriptionTextStyle,labelStyle,helperTextStyle,errorTextStyle) belong here, since they attach to the leaves this phase creates. - Rows with 10+ props that fit no preset — Phase 6.
Notes
- Incremental and opt-in — the legacy
<MenuItem … />config API stays untouched. - Pure refactor: every migrated row must render identically to its old output. No behavioral or visual change.
- Cross-cutting rule still applies: no preset grows a prop for a minority need. A row that outgrows
MenuItemFielddrops to raw composition instead.
Parent: #96202
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022117354782726449253
- Upwork Job ID: 2117354782726449253
- Last Price Increase: 2026-11-02
Activity
war-in commentedon Sep 9, 2026
@roryabraham the first part of this issue is approved by @Pujan92 and waiting for your review - #100191
I'm currently working on the next
MenuItemWithTopDescriptionbatch here - #100704 (we need to wait for the previous PR to be merged)roryabraham commentedon Sep 9, 2026
#100191 merged
melvin-bot commentedon Sep 9, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Sep 9, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
war-in commentedon Sep 10, 2026
The above deploy blockers are just noise here. More details about the blocker here - #100771 (comment)
120 remaining items
MelvinBot commentedon Nov 15, 2026
Status — Nov 15: nine more migration PRs merged
Since the Nov 3 update, these batches have merged:
The Wallet deployment notice confirms production version 9.5.37-1 on Nov 13; its seven-day regression window runs through Nov 20. Other entries above are confirmed merged, not necessarily deployed.
Next: inventory the remaining top-description rows and select the next batch, coordinating shared wrappers with Phase 5 and complex rows with Phase 6. No currently open PR was found linking this phase. The previous 66-site count is stale and was not recounted for this update.
This remains code work, not just a payment hold. Current labels are
DailyandSkip Payment.Pujan92 commentedon Nov 15, 2026
@MelvinBot create a PR - add an
isCompactprop toMenuItem.Rootthat reproduces legacyviewMode={CONST.OPTION_MODE.COMPACT}: applystyles.alignItemsCenterandstyles.optionRowCompacton the pressable, and share the flag through MenuItem context soMenuItem.ContentusesStyleUtils.getMenuItemTextContainerStyle(isCompactPopover || isCompact)(nostyleprop onContent). Then migrate these 6 compact rows to the composable API, keeping each row's existingsentryLabel, onPress, selection/checkmark and right-side content, and removing their seatbelt entries:src/components/Search/FilterComponents/DatePresetFilterBase.tsx:423and:432,src/components/Search/FilterComponents/ReportField/index.tsx:294,src/components/Search/FilterDropdowns/AmountPopup.tsx:159,src/pages/workspace/companyCards/WorkspaceCompanyCardStatementCloseDateSelectionList/index.tsx:157, andsrc/pages/home/UpcomingTravelSection/UpcomingTravelItem.tsx:113.Mark it ready for review and write QA steps in the description
Pujan92 commentedon Nov 15, 2026
@MelvinBot create a PR - add an optional
isLoadingprop to the MenuItem icon leaves (MenuItem.IconandMenuItem.IconNarrow, implemented once insrc/components/MenuItem/leaves/leading/base/BaseMenuItemIcon.tsx) that reproduces legacyshouldShowLoadingSpinnerIcon: when true, render<ActivityIndicator color={theme.textSupporting} />inside a View with the same slot style instead of the glyph, so the row's text doesn't shift. Then migrate these 4 rows to the composable API, keeping their existingsentryLabels and removing their seatbelt entries: insrc/pages/Travel/DynamicTripDetailsPage.tsx:149("Modify trip",style={styles.mt3}) and:165("Trip support"), useMenuItem.Rootwith the same onPress wrapped incallIfAuthenticated,isDisabled={isLoading || isOffline}, a LeadingMenuItem.IconwithisLoading, aMenuItem.Title, and a TrailingMenuItem.NewWindowIcon(notExternalLink, since the URL is generated asynchronously); insrc/pages/iou/request/step/IOURequestStepDistanceGPS/Waypoints/index.tsx:82("Start") and:92("Stop"), use a non-interactiveMenuItem.Root(no onPress) withstyle={styles.pv3}, a LeadingMenuItem.IconNarrowwithisLoading, andMenuItemField.Contentwith the start/stop label as the name and the existing address/"..." title as the value.Mark it ready for review and write QA steps in the description
MelvinBot commentedon Nov 15, 2026
🤖 Web test steps verification results: ❌ fail
All five assertions remain unverified because the app rendered a blank page and snapshots returned zero nodes.

Custom date/range and preset checkmarks
Blocked by blank app.Amount modifiers and formatted values
Blocked by blank app.Report-field labels, values, and navigation
Blocked by blank app.Company-card custom close date
Empty/filled states, error indicator, picker, and selection remain unverified.Upcoming travel
Icons, typography, cancellation styling, and navigation remain unverified.Created Add compact sizing to composable MenuItem and migrate six rows, ready for review, assigned to
Pujan92, with QA steps.Implemented
isCompact, migrated all six sites, and removed their deprecation seatbelts. 148 targeted tests, lint, typecheck, direct compiler checks, formatting, and Storybook smoke passed. Full-suite timeout and browser limitations are documented in the PR.view run · no recording available
MelvinBot commentedon Nov 15, 2026
🤖 Web test steps verification results:⚠️ partial
Verification was blocked on dev NewDot web: no trip fixture was available in the exposed UI or setup tools, and GPS tracking requires the phone app. No behavioral pass is claimed.

Travel titles and icons
No trip fixture available.Travel spinners and stable text position
Blocked by missing trip fixture.Travel actions disabled offline
Missing fixture; offline emulation unavailable.Travel actions disabled while loading
Blocked by missing trip fixture.GPS read-only rows and labels
Web directs users to the phone app.GPS loading ellipses and spinners
GPS tracking unavailable on web.GPS icon restoration and spacing
GPS tracking unavailable on web.Created Add loading states to MenuItem icons and migrate four rows, ready for review, assigned to
Pujan92, with QA steps.Shared
isLoadingsupport and all four migrations are complete; seatbelts removed. 90 targeted tests, lint, typecheck, direct compiler checks, formatting, and Storybook smoke passed. Remaining verification limits are documented.view run · no recording available
mallenexpensify commentedon Nov 16, 2026
Please comment and tag me if/when payment is due, thx
melvin-bot commentedon Nov 16, 2026
@Pujan92
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.39-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
roryabraham commentedon Nov 16, 2026
@MelvinBot what code work remains on this issue?
MelvinBot commentedon Nov 16, 2026
There is still migration work—not just QA/payment. Recounted on current
mainat 51fc66d: 30 production<MenuItemWithTopDescription>sites across 24 files, excluding Storybook.What remains
Land the existing compact-sizing PR. It is open, awaiting review and visual verification. It removes 2 of those sites; the other four migrations are ordinary legacy menu rows. That leaves 28 sites.
Migrate the six smaller remaining rows:
Assign the remaining 20 complex rows to this phase or Phase 6 — long-tail cleanup. These include money-request details, travel previews, picker components, card details, workspace/profile fields, and expense-rule rows. All have 10+ explicit props, but that alone doesn’t establish Phase 6 ownership—the agreed criterion also requires that they fit no preset.
Resolve two wrapper dependencies with Phase 5 — shared wrappers: the highlightable wrapper and the NetSuite form wrapper. The latter appears unused and is a removal candidate.
Finally, finish comparison-gallery/accessibility coverage and remove the already-deprecated legacy wrapper once its dependencies are gone.
The original missing-primitives list is stale; those primitives exist, and loading-icon support has merged. The immediate next step is the six-row batch plus an explicit Phase 3/5/6 ownership split.
view run