Skip to content

[Due for payment 2026-10-16] [$175] [CFI] Edit bank account names in New Expensify #101251

Closed

Description

@joekaufmanexpensify

Coming from this Slack thread, let's let users rename their bank accounts in New Expensify so they can distinguish accounts with similar ending digits.

Details

  • Classic supports an editable Account Name field on eligible bank accounts. It updates the existing addressName field.
  • New Expensify already receives and displays this same field as the bank-account title, but does not provide a way to edit it. IE if you edit a name today in classic, the custom name appears in New Expensify
  • Add an editable Edit nickname field to eligible bank accounts in Wallet, for both personal and business bank accounts.
  • Persist changes through the existing bank-account update path, updating addressName. This is not a new alias data model or backend feature.
  • Keep the same editability rules as Classic. Classic only allows editing the field when the bank account is in the OPEN state.
  • Existing Classic account names should continue to display in New Expensify, and edits made in either product should be reflected in the other after the bank-account data refreshes.
  • UX: Tapping edit nickname button opens RHP with edit field. Default name is listed there, user can edit away from that. Field can't be empty.

NewDot nickname flow

Image Image Image Image
Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit

Activity

  1. melvin-bot commented on Sep 15, 2026

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

  2. joekaufmanexpensify commented on Sep 15, 2026

    @joekaufmanexpensify
    ContributorAuthor

    @dubielzyk-expensify Let me know your thoughts on UX here or if you have any questions on the feature!

  3. dubielzyk-expensify commented on Sep 16, 2026

    @dubielzyk-expensify
    Contributor

    On it! Should be a quick one 👍

  4. joekaufmanexpensify commented on Sep 16, 2026

    @joekaufmanexpensify
    ContributorAuthor

    thanks!

  5. dubielzyk-expensify commented on Sep 17, 2026

    @dubielzyk-expensify
    Contributor

    What about something like..... THIS!?

    Set nickname

    Image Image Image Image Image

    Edit nickname or remove once saved

    Image

    We could just say name, but I think nickname helps communicate that this is just a name that changes in Expensify and not the name as a whole. Might also need copy help from someone on the RHP part.

    cc @Expensify/design for feedback too

  6. dubielzyk-expensify commented on Sep 17, 2026

    @dubielzyk-expensify
    Contributor

    (Sidenote: Once we have Business Wallet/Treasury, we're likely gonna have a Bank Details RHP for all bank accounts. In that world, I expect nickname to just be a push input. So I think this simple direction can work for now)

  7. shawnborton commented on Sep 17, 2026

    @shawnborton
    Contributor

    That looks great to me, and yeah I think the simple direction is a good v1 until we have RHP views for these accounts.

  8. joekaufmanexpensify commented on Sep 17, 2026

    @joekaufmanexpensify
    ContributorAuthor

    Nice, yep, looks good to me. The only thing I would expect is the original name we give to the account to be the default for this field, rather than having it be blank. And then the user can change it from that.

  9. 64 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 13, 2026
  11. melvin-bot commented on Oct 15, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. melvin-bot commented on Oct 15, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  13. mallenexpensify commented on Oct 17, 2026

    @mallenexpensify
    Contributor

    Deploy Blocker #103538 was identified to be related to the PR #102366 that attempted to fix this issue.

    @shubham1206agra this issue and/or PR mention a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.

  14. shubham1206agra commented on Oct 20, 2026

    @shubham1206agra
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: NA
      Link to the comment on the Issue: NA

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    • Account has an open personal bank account and an open business bank account in Wallet.

    Test:

    1. Go to Account > Wallet.
    2. Click the three-dot menu on the personal bank account.
    3. Verify that an "Edit nickname" option appears.
    4. Click "Edit nickname".
    5. Verify that the "Nickname" field is prefilled with the name shown on the Wallet row.
    6. Clear the field and click "Save".
    7. Verify that a "This field is required" error appears and the page stays open.
    8. Enter a new nickname and click "Save".
    9. Verify that the page closes and the Wallet row shows the new nickname.
    10. Refresh the page.
    11. Verify that the Wallet row still shows the new nickname.
    12. Repeat steps 2 to 11 with the business bank account.

    Do we agree 👍 or 👎

  15. shubham1206agra commented on Oct 20, 2026

    @shubham1206agra
    Contributor

    @mallenexpensify About DB linked here

    #103538 - Dev environment only issue due to BE restrictions, works well in production.

  16. mallenexpensify commented on Oct 20, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @shubham1206agra due $175 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions