Skip to content

Spend - Vendor column is missing in the downloaded file when exported as current view #101858

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.91-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #101410
Email or phone of affected tester (no customers): djnoinsjojiosjo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Search

Action Performed:

Precondition:

  • Connect workspace to Sage Intacct.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a non-reimbursable expense.
  4. Add any vendor to the expense.
  5. Go to Spend > Expenses.
  6. Click Display > Edit columns.
  7. Select Vendor > Save.
  8. Select the expense via checkbox.
  9. Click Export > Current view.
  10. Open the downloaded file.

Expected Result:

Vendor column will be shown in the downloaded file.

Actual Result:

Vendor column is missing in the downloaded file.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7266054_1790061225003.15.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7266054

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 22, 2026
  2. applause-bot commented on Sep 22, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/381a7aa326727794dd23ab37fcad1f8a20735d7ea407ea845b795a9c209a70af

  3. melvin-bot commented on Sep 22, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #101410

  4. github-actions commented on Sep 22, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Sep 22, 2026

    @melvin-bot

    @Beamanator you have been assigned to this deploy blocker because you reviewed the offending PR: #101410

  6. melvin-bot commented on Sep 22, 2026

    @melvin-bot

    @c3024 you have been assigned to this deploy blocker because you authored the offending PR: #101410

  7. melvin-bot commented on Sep 22, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Sep 22, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: [Internal QA] Add Vendor column to expense Search and report tables - by @c3024 (High confidence that this PR introduced the Vendor column; Medium confidence that the actual code change lands backend-side)
    Related Issues: Deploy Checklist: New Expensify 2026-09-21

    Recommendation: ROLL FORWARD

    The App is already sending the vendor column correctly to the export command — the CSV itself is generated server-side, so adding vendor to the export's column map is a far smaller change than reverting the whole Vendor column feature. If that support can't land before this deploy goes out, the fallback is to revert #101410 (the feature is integration-gated and brand new, so the revert is low risk).

    Assigned: @c3024 (PR author), @Beamanator (approving reviewer) from #101410 — both were already auto-assigned, no change made.
    Labels: No changes. DeployBlockerCash is kept (an App PR shipped the feature, and this isn't reproducible in production). DeployBlocker was never applied, so nothing was removed.

    📋 Detailed Analysis

    Evidence

    • #101410 (merged 2026-09-20, on the 2026-09-21 staging checklist) is the only PR that introduces vendor as a Search table column. It adds VENDOR: 'vendor' to CONST.SEARCH.TABLE_COLUMNS and a VENDOR entry to COLUMN_AVAILABILITY with search: true, which is what puts "Vendor" in Display → Edit columns.
    • The two other recent vendor PRs are unrelated to Search columns: [Vendor matching CC] Vendor column in merchant-rules CSV importer (merchant-rules importer) and [No QA] Docs updates for E/A#100760 Updated vendor column in merchant rules import (docs).
    • Consistent with "N/A in production — new feature": the column does not exist in prod, so there is nothing to export there.
    • I checked every other PR on the open checklist against the export path (useSearchBulkActions, SearchUIUtils.getColumnsToShow, actions/Search.ts, SearchQueryUtils); none of them changed how columns are sent for export in a way that would single out Vendor.

    Verification

    Files in the affected path, at 538837e1610f7444208e4634adb4168225129956:

    1. The export column list is built here and does include vendor — the user's saved columns are passed through getColumnsToShow, and the custom-column branch returns them verbatim:
    2. The column key and header label are both sent: columns:...,vendor inside jsonQuery (src/libs/SearchQueryUtils.ts#L1213-L1220) and exportColumnLabels = {"vendor":"Vendor"} (src/hooks/useSearchBulkActions.ts#L1046-L1060, via getSearchColumnTranslationKey → common.vendor at SearchUIUtils.ts#L4419-L4420).
    3. The CSV is produced server-side — the App just POSTs to ExportSearchItemsToCSV and streams the response to disk: src/libs/actions/Search.ts#L1906-L1932.

    So the export request is well-formed; nothing on the App side drops the column.

    Root Cause

    The Vendor cell is a purely client-side column. Its value is never returned as a searchable/exportable field — the App resolves it locally from the transaction's comment.vendor.externalID against the workspace's synced vendor list:

    Two independent signals confirm the backend has no notion of a vendor column yet:

    • It is the only expense column with a null sorting property, and the header is explicitly isColumnSortable: false — src/libs/SearchUIUtils.ts#L325. Sorting is server-side, so a null here means the backend can't sort on it.
    • There is no vendor search filter key or grammar term anywhere in SearchQueryUtils / the search parser.

    Export > Current view asks the backend to render each column in jsonQuery.columns. Since vendor has no server-side resolver in the export's column map, the backend silently skips it and the column is absent from the downloaded file. The client-only rendering is exactly why the column looks correct in the table but vanishes in the CSV.

    Recommended fix (roll forward): add vendor to the server-side column map used by ExportSearchItemsToCSV, resolving the transaction's vendor ID to its name the same way getVendorDisplayName does (synced vendor list first, falling back to the name stored on the transaction). This needs a backend change; I could not inspect that code from here, so @c3024 / @Beamanator please confirm whether that support was ever shipped alongside #101410.

    Fallback (revert): revert #101410. That removes Vendor from Display → Edit columns entirely, so there is no column to be missing from the CSV. The feature is gated on vendor-matching-enabled workspaces and exists only on staging, so the blast radius of the revert is small.

  9. c3024 commented on Sep 22, 2026

    @c3024
    Contributor

    CSV generation is server-side. This needs a fix in Auth. I will open a PR there. Doc and issue description do not have any mention of this. This has nothing to do with App. I think we can demote this.

  10. lakchote commented on Sep 22, 2026

    @lakchote
    Contributor

    @c3024 is right. Demoting this one.

  11. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Sep 22, 2026
  12. Beamanator commented on Sep 22, 2026

    @Beamanator
    Contributor

    agreed, thanks y'all!

  13. c3024 commented on Sep 25, 2026

    @c3024
  14. c3024 commented on Sep 25, 2026

    @c3024
    Contributor

    Auth PR deployed to prod. Requested a retest. If it is good we can close this.

  15. m-natarajan commented on Sep 25, 2026

    @m-natarajan

    Chrome / v9.4.93-3, Passed

    bandicam.2026-09-25.15-01-39-477.mp4
  16. Beamanator commented on Sep 25, 2026

    @Beamanator
    Contributor

    niiice thanks! closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions