You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Spend - Vendor column is missing in the downloaded file when exported as current view #101858
Version Number: 9.4.91-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#101410 Email or phone of affected tester (no customers):djnoinsjojiosjo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Search
Action Performed:
Precondition:
Connect workspace to Sage Intacct.
Go to staging.new.expensify.com
Go to workspace chat.
Create a non-reimbursable expense.
Add any vendor to the expense.
Go to Spend > Expenses.
Click Display > Edit columns.
Select Vendor > Save.
Select the expense via checkbox.
Click Export > Current view.
Open the downloaded file.
Expected Result:
Vendor column will be shown in the downloaded file.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The App is already sending the vendor column correctly to the export command — the CSV itself is generated server-side, so adding vendor to the export's column map is a far smaller change than reverting the whole Vendor column feature. If that support can't land before this deploy goes out, the fallback is to revert #101410 (the feature is integration-gated and brand new, so the revert is low risk).
Assigned: @c3024 (PR author), @Beamanator (approving reviewer) from #101410 — both were already auto-assigned, no change made. Labels: No changes. DeployBlockerCash is kept (an App PR shipped the feature, and this isn't reproducible in production). DeployBlocker was never applied, so nothing was removed.
📋 Detailed Analysis
Evidence
#101410 (merged 2026-09-20, on the 2026-09-21 staging checklist) is the only PR that introduces vendor as a Search table column. It adds VENDOR: 'vendor' to CONST.SEARCH.TABLE_COLUMNS and a VENDOR entry to COLUMN_AVAILABILITY with search: true, which is what puts "Vendor" in Display → Edit columns.
Consistent with "N/A in production — new feature": the column does not exist in prod, so there is nothing to export there.
I checked every other PR on the open checklist against the export path (useSearchBulkActions, SearchUIUtils.getColumnsToShow, actions/Search.ts, SearchQueryUtils); none of them changed how columns are sent for export in a way that would single out Vendor.
Verification
Files in the affected path, at 538837e1610f7444208e4634adb4168225129956:
The export column list is built here and does include vendor — the user's saved columns are passed through getColumnsToShow, and the custom-column branch returns them verbatim:
The CSV is produced server-side — the App just POSTs to ExportSearchItemsToCSV and streams the response to disk: src/libs/actions/Search.ts#L1906-L1932.
So the export request is well-formed; nothing on the App side drops the column.
Root Cause
The Vendor cell is a purely client-side column. Its value is never returned as a searchable/exportable field — the App resolves it locally from the transaction's comment.vendor.externalID against the workspace's synced vendor list:
Two independent signals confirm the backend has no notion of a vendor column yet:
It is the only expense column with a null sorting property, and the header is explicitly isColumnSortable: false — src/libs/SearchUIUtils.ts#L325. Sorting is server-side, so a null here means the backend can't sort on it.
There is no vendor search filter key or grammar term anywhere in SearchQueryUtils / the search parser.
Export > Current view asks the backend to render each column in jsonQuery.columns. Since vendor has no server-side resolver in the export's column map, the backend silently skips it and the column is absent from the downloaded file. The client-only rendering is exactly why the column looks correct in the table but vanishes in the CSV.
Recommended fix (roll forward): add vendor to the server-side column map used by ExportSearchItemsToCSV, resolving the transaction's vendor ID to its name the same way getVendorDisplayName does (synced vendor list first, falling back to the name stored on the transaction). This needs a backend change; I could not inspect that code from here, so @c3024 / @Beamanator please confirm whether that support was ever shipped alongside #101410.
Fallback (revert): revert #101410. That removes Vendor from Display → Edit columns entirely, so there is no column to be missing from the CSV. The feature is gated on vendor-matching-enabled workspaces and exists only on staging, so the blast radius of the revert is small.
CSV generation is server-side. This needs a fix in Auth. I will open a PR there. Doc and issue description do not have any mention of this. This has nothing to do with App. I think we can demote this.
Activity
applause-bot commentedon Sep 22, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/381a7aa326727794dd23ab37fcad1f8a20735d7ea407ea845b795a9c209a70af
melvin-bot commentedon Sep 22, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #101410
github-actions commentedon Sep 22, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Sep 22, 2026
@Beamanator you have been assigned to this deploy blocker because you reviewed the offending PR: #101410
melvin-bot commentedon Sep 22, 2026
@c3024 you have been assigned to this deploy blocker because you authored the offending PR: #101410
melvin-bot commentedon Sep 22, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Sep 22, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: [Internal QA] Add Vendor column to expense Search and report tables - by @c3024 (High confidence that this PR introduced the Vendor column; Medium confidence that the actual code change lands backend-side)
Related Issues: Deploy Checklist: New Expensify 2026-09-21
Recommendation: ROLL FORWARD
The App is already sending the
vendorcolumn correctly to the export command — the CSV itself is generated server-side, so addingvendorto the export's column map is a far smaller change than reverting the whole Vendor column feature. If that support can't land before this deploy goes out, the fallback is to revert #101410 (the feature is integration-gated and brand new, so the revert is low risk).Assigned: @c3024 (PR author), @Beamanator (approving reviewer) from #101410 — both were already auto-assigned, no change made.
Labels: No changes.
DeployBlockerCashis kept (an App PR shipped the feature, and this isn't reproducible in production).DeployBlockerwas never applied, so nothing was removed.📋 Detailed Analysis
Evidence
vendoras a Search table column. It addsVENDOR: 'vendor'toCONST.SEARCH.TABLE_COLUMNSand aVENDORentry toCOLUMN_AVAILABILITYwithsearch: true, which is what puts "Vendor" in Display → Edit columns.useSearchBulkActions,SearchUIUtils.getColumnsToShow,actions/Search.ts,SearchQueryUtils); none of them changed how columns are sent for export in a way that would single out Vendor.Verification
Files in the affected path, at
538837e1610f7444208e4634adb4168225129956:vendor— the user's saved columns are passed throughgetColumnsToShow, and the custom-column branch returns them verbatim:src/hooks/useSearchBulkActions.ts#L1033-L1049src/libs/SearchUIUtils.ts#L6542-L6546—allowedColumnscomes fromTYPE_CUSTOM_COLUMNS.EXPENSE, which is derived fromCOLUMN_AVAILABILITYand therefore containsvendorafter [Internal QA] Add Vendor column to expense Search and report tables #101410.src/libs/SearchUIUtils.ts#L6581-L6595and#L6761-L6768— the custom-column result is returned unfiltered (onlyviolationsis ever stripped).columns:...,vendorinsidejsonQuery(src/libs/SearchQueryUtils.ts#L1213-L1220) andexportColumnLabels={"vendor":"Vendor"}(src/hooks/useSearchBulkActions.ts#L1046-L1060, viagetSearchColumnTranslationKey→common.vendoratSearchUIUtils.ts#L4419-L4420).ExportSearchItemsToCSVand streams the response to disk:src/libs/actions/Search.ts#L1906-L1932.So the export request is well-formed; nothing on the App side drops the column.
Root Cause
The Vendor cell is a purely client-side column. Its value is never returned as a searchable/exportable field — the App resolves it locally from the transaction's
comment.vendor.externalIDagainst the workspace's synced vendor list:src/components/TransactionItemRow/TransactionItemRowWide.tsx#L395-L403src/libs/PolicyUtils.ts#L3019-L3024(getVendorDisplayName)Two independent signals confirm the backend has no notion of a
vendorcolumn yet:nullsorting property, and the header is explicitlyisColumnSortable: false—src/libs/SearchUIUtils.ts#L325. Sorting is server-side, so anullhere means the backend can't sort on it.vendorsearch filter key or grammar term anywhere inSearchQueryUtils/ the search parser.Export > Current viewasks the backend to render each column injsonQuery.columns. Sincevendorhas no server-side resolver in the export's column map, the backend silently skips it and the column is absent from the downloaded file. The client-only rendering is exactly why the column looks correct in the table but vanishes in the CSV.Recommended fix (roll forward): add
vendorto the server-side column map used byExportSearchItemsToCSV, resolving the transaction's vendor ID to its name the same waygetVendorDisplayNamedoes (synced vendor list first, falling back to the name stored on the transaction). This needs a backend change; I could not inspect that code from here, so @c3024 / @Beamanator please confirm whether that support was ever shipped alongside #101410.Fallback (revert): revert #101410. That removes Vendor from Display → Edit columns entirely, so there is no column to be missing from the CSV. The feature is gated on vendor-matching-enabled workspaces and exists only on staging, so the blast radius of the revert is small.
c3024 commentedon Sep 22, 2026
CSV generation is server-side. This needs a fix in Auth. I will open a PR there. Doc and issue description do not have any mention of this. This has nothing to do with App. I think we can demote this.
lakchote commentedon Sep 22, 2026
@c3024 is right. Demoting this one.
Beamanator commentedon Sep 22, 2026
agreed, thanks y'all!
c3024 commentedon Sep 25, 2026
c3024 commentedon Sep 25, 2026
Auth PR deployed to prod. Requested a retest. If it is good we can close this.
m-natarajan commentedon Sep 25, 2026
Chrome / v9.4.93-3, Passed
bandicam.2026-09-25.15-01-39-477.mp4
Beamanator commentedon Sep 25, 2026
niiice thanks! closing!