Skip to content

[No QA] Docs updates for E/A#100760 Updated vendor column in merchant rules import - #101634

Merged
strepanier03 merged 3 commits into
mainfrom
melvin-docs-vendor-merchant-rules-import
Sep 21, 2026
Merged

strepanier03 merged 3 commits into
mainfrom
melvin-docs-vendor-merchant-rules-import

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for [Vendor matching CC] Vendor column in merchant-rules CSV importer, which added an Updated vendor option to the merchant-rules spreadsheet importer.

The two published articles that document the merchant-rules importer listed every mappable field except the new one. This PR adds it, trimmed down to the minimum after review feedback.

docs/articles/new-expensify/workspaces/Import-Merchant-Rules.md

  • Added Updated vendor to the list of fields you can map in step 6.
  • Added a one-line prerequisite note under Who can import Merchant Rules stating the field only appears where vendor matching is active, linking to the QuickBooks Online vendor matching article.

docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.md

  • Added Updated vendor to the spreadsheet column list in How to import multiple Merchant Rules.
  • Added Vendor to the "What expense fields can be updated by Merchant Rules?" FAQ, which was already out of date for the manually-created rule field.

Every label was taken from src/languages/en.ts (importColumnUpdatedVendor: 'Updated vendor'), and the Rules page path — Expense defaults tab, More, Import merchant rules — was verified against the live web app.

docs/assets/Files/merchant-rule-import-template.csv was not changed. Adding an Updated vendor column would put an unmappable column in the template for every workspace without vendor matching. Say the word and I'll add it.

Fixed Issues

$ #100762
PROPOSAL:

Tests

None

Offline tests

N/A — help site markdown only.

QA Steps

None

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…port

Co-authored-by: Dominic Tu <dominictb@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 18, 2026 20:34
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 18, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream melvin-docs-vendor-merchant-rules-import
git checkout -b melvin-docs-vendor-merchant-rules-import upstream/melvin-docs-vendor-merchant-rules-import
git push -u origin melvin-docs-vendor-merchant-rules-import

Then you can close this PR and open a new one from your fork.

@dominictb dominictb left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot Cleanup to maintain conciseness

description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, and how Tag values are interpreted for single-level and multi-level tags.
keywords: [New Expensify, import merchant rules, merchant rules spreadsheet, bulk merchant rules, import rules CSV, workspace rules, multi-level tags import]
internalScope: Audience is Workspace Admins on the Control plan with Rules enabled. Covers bulk-creating Merchant Rules by importing a spreadsheet and how Tag cells are interpreted for single-level and multi-level tags. Does not cover creating Merchant Rules manually, personal expense rules, or importing tags themselves.
description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags, and how Updated vendor cells are matched to your vendor list.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags, and how Updated vendor cells are matched to your vendor list.
description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 03a0cb4.

keywords: [New Expensify, import merchant rules, merchant rules spreadsheet, bulk merchant rules, import rules CSV, workspace rules, multi-level tags import]
internalScope: Audience is Workspace Admins on the Control plan with Rules enabled. Covers bulk-creating Merchant Rules by importing a spreadsheet and how Tag cells are interpreted for single-level and multi-level tags. Does not cover creating Merchant Rules manually, personal expense rules, or importing tags themselves.
description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags, and how Updated vendor cells are matched to your vendor list.
keywords: [New Expensify, import merchant rules, merchant rules spreadsheet, bulk merchant rules, import rules CSV, workspace rules, multi-level tags import, updated vendor column, vendor skipped import]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
keywords: [New Expensify, import merchant rules, merchant rules spreadsheet, bulk merchant rules, import rules CSV, workspace rules, multi-level tags import, updated vendor column, vendor skipped import]
keywords: [New Expensify, import merchant rules, merchant rules spreadsheet, bulk merchant rules, import rules CSV, workspace rules, multi-level tags import]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 03a0cb4.

internalScope: Audience is Workspace Admins on the Control plan with Rules enabled. Covers bulk-creating Merchant Rules by importing a spreadsheet and how Tag cells are interpreted for single-level and multi-level tags. Does not cover creating Merchant Rules manually, personal expense rules, or importing tags themselves.
description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags, and how Updated vendor cells are matched to your vendor list.
keywords: [New Expensify, import merchant rules, merchant rules spreadsheet, bulk merchant rules, import rules CSV, workspace rules, multi-level tags import, updated vendor column, vendor skipped import]
internalScope: Audience is Workspace Admins on the Control plan with Rules enabled. Covers bulk-creating Merchant Rules by importing a spreadsheet, how Tag cells are interpreted for single-level and multi-level tags, and how Updated vendor cells are matched to the workspace vendor list. Does not cover creating Merchant Rules manually, personal expense rules, importing tags themselves, or setting up vendor matching for an accounting connection.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
internalScope: Audience is Workspace Admins on the Control plan with Rules enabled. Covers bulk-creating Merchant Rules by importing a spreadsheet, how Tag cells are interpreted for single-level and multi-level tags, and how Updated vendor cells are matched to the workspace vendor list. Does not cover creating Merchant Rules manually, personal expense rules, importing tags themselves, or setting up vendor matching for an accounting connection.
internalScope: Audience is Workspace Admins on the Control plan with Rules enabled. Covers bulk-creating Merchant Rules by importing a spreadsheet and how Tag cells are interpreted for single-level and multi-level tags. Does not cover creating Merchant Rules manually, personal expense rules, or importing tags themselves.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 03a0cb4.


If **Rules** is not enabled, [learn how to enable Workspace Rules](/articles/new-expensify/workspaces/Workspace-Rules#how-to-enable-workspace-rules).

The **Updated vendor** field is offered only on a workspace where vendor matching is active, which requires an accounting connection that assigns vendors to company card expenses. Learn more about [vendor matching for QuickBooks Online](/articles/new-expensify/connections/quickbooks-online/Manage-Vendor-Matching-for-QuickBooks-Online).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The **Updated vendor** field is offered only on a workspace where vendor matching is active, which requires an accounting connection that assigns vendors to company card expenses. Learn more about [vendor matching for QuickBooks Online](/articles/new-expensify/connections/quickbooks-online/Manage-Vendor-Matching-for-QuickBooks-Online).
The **Updated vendor** field is offered only on a workspace where vendor matching is active. Learn more about [vendor matching for QuickBooks Online](/articles/new-expensify/connections/quickbooks-online/Manage-Vendor-Matching-for-QuickBooks-Online).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 03a0cb4.

Comment on lines +58 to +69
## How Updated vendor values are matched when importing Merchant Rules

An **Updated vendor** cell holds the vendor's name, and Expensify matches that name against the vendor list imported from your accounting connection.

- Matching ignores capitalization and trims spaces around the name, so a cell of `starbucks ` matches a vendor named `Starbucks`.
- A vendor cell is skipped when no vendor in the workspace has that name, or when more than one vendor shares that name. The row's other updates still import.
- If **Updated vendor** was the only field the row updated, the whole row is skipped and no rule is created for it.

Sync your accounting connection before importing so the vendor list Expensify matches against is current.

---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## How Updated vendor values are matched when importing Merchant Rules
An **Updated vendor** cell holds the vendor's name, and Expensify matches that name against the vendor list imported from your accounting connection.
- Matching ignores capitalization and trims spaces around the name, so a cell of `starbucks ` matches a vendor named `Starbucks`.
- A vendor cell is skipped when no vendor in the workspace has that name, or when more than one vendor shares that name. The row's other updates still import.
- If **Updated vendor** was the only field the row updated, the whole row is skipped and no rule is created for it.
Sync your accounting connection before importing so the vendor list Expensify matches against is current.
---

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 03a0cb4.

Comment on lines +88 to +89

Check the spelling against your vendor list, then sync your accounting connection and import the remaining rows again.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Check the spelling against your vendor list, then sync your accounting connection and import the remaining rows again.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 03a0cb4.

Comment on lines +95 to +98
## Can I name my spreadsheet column Updated supplier instead of Updated vendor?

Yes. A column headed either `Updated vendor` or `Updated supplier` is detected automatically when you upload the file. The field you map it to is called **Updated vendor** on every workspace, including a workspace connected to Xero, where the rule itself shows the value as **Supplier**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Can I name my spreadsheet column Updated supplier instead of Updated vendor?
Yes. A column headed either `Updated vendor` or `Updated supplier` is detected automatically when you upload the file. The field you map it to is called **Updated vendor** on every workspace, including a workspace connected to Xero, where the rule itself shows the value as **Supplier**.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 03a0cb4.

title: Merchant Rules
description: Learn how to enable and use Merchant Rules to automatically apply consistent expense coding based on the expense merchant name.
keywords: [New Expensify, workspace merchant rules, merchant rules, auto-categorize by merchant, expense automation, expense rules, workspace settings, import merchant rules, bulk import merchant rules, merchant rules spreadsheet, merchant rule deleted tag, tag missing from merchant rule]
keywords: [New Expensify, workspace merchant rules, merchant rules, auto-categorize by merchant, expense automation, expense rules, workspace settings, import merchant rules, bulk import merchant rules, merchant rules spreadsheet, merchant rule deleted tag, tag missing from merchant rule, merchant rule vendor, updated vendor column]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
keywords: [New Expensify, workspace merchant rules, merchant rules, auto-categorize by merchant, expense automation, expense rules, workspace settings, import merchant rules, bulk import merchant rules, merchant rules spreadsheet, merchant rule deleted tag, tag missing from merchant rule, merchant rule vendor, updated vendor column]
keywords: [New Expensify, workspace merchant rules, merchant rules, auto-categorize by merchant, expense automation, expense rules, workspace settings, import merchant rules, bulk import merchant rules, merchant rules spreadsheet, merchant rule deleted tag, tag missing from merchant rule, merchant rule vendor]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 03a0cb4.

- Reimbursable status
- Billable status
- Tax
- Vendor (only on a workspace where vendor matching is active)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Vendor (only on a workspace where vendor matching is active)
- Vendor

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 03a0cb4.

- **Updated description** — Apply a description (optional).
- **Reimbursable** — Set reimbursable status to **True** or **False** (optional).
- **Billable** — Set billable status to **True** or **False** (optional).
- **Updated vendor** — Apply a vendor by name (optional, and only on a workspace where vendor matching is active).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Updated vendor** — Apply a vendor by name (optional, and only on a workspace where vendor matching is active).
- **Updated vendor** — Apply a vendor by name (optional).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 03a0cb4.

@dominictb

Copy link
Copy Markdown
Contributor

@MelvinBot Check my requested changes above

Co-authored-by: dominictb <dominictb@users.noreply.github.com>
Co-authored-by: Dominic Tu <dominictb@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Applied all 12 suggestions in 03a0cb4. The PR is now 6 added lines across the two articles, down from 37.

What's left:

File Change
Import-Merchant-Rules.md Updated vendor added to the step 6 field list; one-line prerequisite note linking the QBO vendor matching article
Workspace-Merchant-Rules.md Updated vendor added to the spreadsheet column list; Vendor added to the "What expense fields can be updated" FAQ

What was removed: the whole How Updated vendor values are matched section, the vendor-skipped confirmation bullet, both new FAQs, and every frontmatter change on Import-Merchant-Rules.md. The row-skip FAQ is back to its original wording.

Two small deviations from the literal suggestion text
  • The description: suggestion dropped the word "and" (…spreadsheet, how Tag values are interpreted…). I restored the original line verbatim instead, so Import-Merchant-Rules.md frontmatter is now byte-identical to main — no incidental one-word diff.
  • The deletion suggestions on the two new FAQs were anchored to their last lines. I removed each FAQ heading and body in full, which is what the trailing blank-line deletions imply; leaving a bare heading would have broken the page.
Checks run
  • ./.github/scripts/createDocsRoutes.sh — passed, routes file up to date.
  • npm run spell-changed — could not run: it fails at git merge-base because this checkout is shallow. Unrelated to these edits, and the change is net deletions plus text already present on main.

The PR description has been updated to match the trimmed scope. docs/assets/Files/merchant-rule-import-template.csv is still unchanged — say the word if you want the Updated vendor column added there.

@github-actions github-actions Bot changed the title Docs updates for E/A#100760 Updated vendor column in merchant rules import [No QA] Docs updates for E/A#100760 Updated vendor column in merchant rules import Sep 21, 2026
@OSBotify

This comment has been minimized.

Co-authored-by: dominictb <dominictb@users.noreply.github.com>
Co-authored-by: Dominic Tu <dominictb@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Checked all 12. Eleven were already correct; one wasn't, and I've just fixed it in 12909c8.

The one that was off: the description: suggestion. Last run I substituted main's original wording (which has "and") instead of your literal text. You asked me to check, so I've now applied your suggestion verbatim — byte-confirmed with grep -F:

description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags.

One thing to flag so you can overrule me either way: main reads …spreadsheet, and how Tag values…. Your version drops that "and", leaving a two-item list without a conjunction. It's now your text as written — tell me if you'd rather keep main's and I'll revert that one line.

Verification of all 12 suggestions against the branch

Verified with literal grep -F on the pushed files, not by eye.

Import-Merchant-Rules.md

# Suggestion Result
1 description: reverted ✅ fixed in 12909c8 (was the one miss)
2 keywords: reverted ✅ matches
3 internalScope: reverted ✅ matches
4 Prerequisite note shortened ✅ matches
5 Delete How Updated vendor values are matched section ✅ absent
6 Delete vendors-skipped confirmation bullet ✅ absent
7 Row-skip FAQ reverted ✅ matches
8 Delete Why was the vendor skipped FAQ ✅ absent
9 Delete Updated supplier FAQ ✅ absent

Workspace-Merchant-Rules.md

# Suggestion Result
10 keywords: trimmed ✅ matches
11 - Vendor ✅ matches (line 164)
12 - **Updated vendor** — Apply a vendor by name (optional). ✅ matches (line 44)

A sweep for the removed prose (how updated vendor values, vendors were skipped, why was the vendor skipped, updated supplier, sync your accounting connection) returns only the one intended prerequisite line on 23 — nothing else survived.

The PR is now 7 added lines, 3 removed, across the two articles. ./.github/scripts/createDocsRoutes.sh passes. npm run spell-changed still can't run here — it fails at git merge-base on this shallow checkout, which is unrelated to the change.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://edc100d7.helpdot.pages.dev ⚡️

Updated articles:

@dominictb

Copy link
Copy Markdown
Contributor

@MelvinBot Fill both "Tests" and "QA Tests" as "None" then mark this PR as ready for review

@dominictb

Copy link
Copy Markdown
Contributor

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot
MelvinBot marked this pull request as ready for review September 21, 2026 11:23
@melvin-bot

melvin-bot Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @strepanier03

@melvin-bot
melvin-bot Bot requested review from strepanier03 and removed request for a team September 21, 2026 11:24
@melvin-bot

melvin-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

@strepanier03 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Done. Both Tests and QA Steps now read None, and the PR is out of draft and ready for review.

I left the PR Author Checklist boxes unchecked. Those are your attestations as co-author — several (all-platform testing, High Traffic account, screenshots) aren't things I can truthfully check on your behalf. PR Author Checklist / checklist will fail until you tick them.

---
title: Import Merchant Rules using a spreadsheet
description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, and how Tag values are interpreted for single-level and multi-level tags.
description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability: Removing "and" leaves an ungrammatical run-on list ("...importing a spreadsheet, how Tag values are interpreted..."). Restore the conjunction so the two clauses read cleanly.

Suggested change
description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags.
description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, and how Tag values are interpreted for single-level and multi-level tags.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR is a small, well-scoped follow-up that adds the new Updated vendor field to the two articles documenting the merchant-rules spreadsheet importer. The changes are surgical, insert content into existing task-based structures, and use UI-exact labels sourced from en.ts, staying consistent with the surrounding content and the governance standards.

Scores Summary

  • Readability: 8/10 - Additions are concise and follow the existing list/step formatting cleanly. One description-line change slightly reduces sentence clarity (see Key Findings).
  • AI Readiness: 9/10 - Full feature name (Updated vendor) used consistently, internalScope metadata preserved, keyword updated (merchant rule vendor), no heading-hierarchy changes introduced. Additions slot cleanly into existing task-based sections.
  • Style Compliance: 9/10 - UI labels are bolded, in Sentence case, and match the product exactly. Navigation phrasing and the QuickBooks Online cross-link follow the naming and cross-linking standards.

Key Findings

  • Positive: The Updated vendor label matches the en.ts source string (importColumnUpdatedVendor) verbatim and is bolded per Button/Section naming standards.
  • Positive: The prerequisite note in Import-Merchant-Rules.md is placed as an explanatory sentence (not inside a numbered step), with a descriptive relative-link anchor - fully compliant with the Cross-Linking Standards.
  • Positive: The FAQ answer "What expense fields can be updated by Merchant Rules?" now includes Vendor, bringing the list back in sync with the actual field set.
  • Minor: In Import-Merchant-Rules.md, the description frontmatter dropped the word "and" (from "spreadsheet, and how Tag values are interpreted" to "spreadsheet, how Tag values are interpreted"), leaving two comma-joined clauses that read slightly less smoothly. This edit is unrelated to the vendor change and could be reverted or reworded.
  • Consistency: The Workspace-Merchant-Rules column list adds Updated vendor after Reimbursable/Billable, while Import-Merchant-Rules step 6 lists it after Updated description. Field ordering differs between the two articles - consider aligning.

Recommendations

  • Restore "and" (or otherwise smooth the clause) in the Import-Merchant-Rules.md description line.
  • Align the ordering of the Updated vendor field across both articles for a consistent reader experience.
  • Confirm whether the CSV template should also gain an Updated vendor column (author flagged this as intentionally omitted - reasonable, since it would be unmappable for non-vendor-matching workspaces).

Files Reviewed

  • docs/articles/new-expensify/workspaces/Import-Merchant-Rules.md - Compliant; minor description wording nit.
  • docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.md - Compliant; field-ordering consistency suggestion.

Note: Detailed line-by-line feedback has been provided as inline comments.

@strepanier03 strepanier03 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super solid, updates are good.

@strepanier03
strepanier03 merged commit f2c359b into main Sep 21, 2026
18 of 20 checks passed
@strepanier03
strepanier03 deleted the melvin-docs-vendor-merchant-rules-import branch September 21, 2026 21:49
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/strepanier03 in version: 9.4.92-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants