Repository navigation
[No QA] Docs updates for E/A#100760 Updated vendor column in merchant rules import - #101634
Conversation
…port Co-authored-by: Dominic Tu <dominictb@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
| description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, and how Tag values are interpreted for single-level and multi-level tags. | ||
| keywords: [New Expensify, import merchant rules, merchant rules spreadsheet, bulk merchant rules, import rules CSV, workspace rules, multi-level tags import] | ||
| internalScope: Audience is Workspace Admins on the Control plan with Rules enabled. Covers bulk-creating Merchant Rules by importing a spreadsheet and how Tag cells are interpreted for single-level and multi-level tags. Does not cover creating Merchant Rules manually, personal expense rules, or importing tags themselves. | ||
| description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags, and how Updated vendor cells are matched to your vendor list. |
There was a problem hiding this comment.
| description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags, and how Updated vendor cells are matched to your vendor list. | |
| description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags. |
| keywords: [New Expensify, import merchant rules, merchant rules spreadsheet, bulk merchant rules, import rules CSV, workspace rules, multi-level tags import] | ||
| internalScope: Audience is Workspace Admins on the Control plan with Rules enabled. Covers bulk-creating Merchant Rules by importing a spreadsheet and how Tag cells are interpreted for single-level and multi-level tags. Does not cover creating Merchant Rules manually, personal expense rules, or importing tags themselves. | ||
| description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags, and how Updated vendor cells are matched to your vendor list. | ||
| keywords: [New Expensify, import merchant rules, merchant rules spreadsheet, bulk merchant rules, import rules CSV, workspace rules, multi-level tags import, updated vendor column, vendor skipped import] |
There was a problem hiding this comment.
| keywords: [New Expensify, import merchant rules, merchant rules spreadsheet, bulk merchant rules, import rules CSV, workspace rules, multi-level tags import, updated vendor column, vendor skipped import] | |
| keywords: [New Expensify, import merchant rules, merchant rules spreadsheet, bulk merchant rules, import rules CSV, workspace rules, multi-level tags import] |
| internalScope: Audience is Workspace Admins on the Control plan with Rules enabled. Covers bulk-creating Merchant Rules by importing a spreadsheet and how Tag cells are interpreted for single-level and multi-level tags. Does not cover creating Merchant Rules manually, personal expense rules, or importing tags themselves. | ||
| description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags, and how Updated vendor cells are matched to your vendor list. | ||
| keywords: [New Expensify, import merchant rules, merchant rules spreadsheet, bulk merchant rules, import rules CSV, workspace rules, multi-level tags import, updated vendor column, vendor skipped import] | ||
| internalScope: Audience is Workspace Admins on the Control plan with Rules enabled. Covers bulk-creating Merchant Rules by importing a spreadsheet, how Tag cells are interpreted for single-level and multi-level tags, and how Updated vendor cells are matched to the workspace vendor list. Does not cover creating Merchant Rules manually, personal expense rules, importing tags themselves, or setting up vendor matching for an accounting connection. |
There was a problem hiding this comment.
| internalScope: Audience is Workspace Admins on the Control plan with Rules enabled. Covers bulk-creating Merchant Rules by importing a spreadsheet, how Tag cells are interpreted for single-level and multi-level tags, and how Updated vendor cells are matched to the workspace vendor list. Does not cover creating Merchant Rules manually, personal expense rules, importing tags themselves, or setting up vendor matching for an accounting connection. | |
| internalScope: Audience is Workspace Admins on the Control plan with Rules enabled. Covers bulk-creating Merchant Rules by importing a spreadsheet and how Tag cells are interpreted for single-level and multi-level tags. Does not cover creating Merchant Rules manually, personal expense rules, or importing tags themselves. |
|
|
||
| If **Rules** is not enabled, [learn how to enable Workspace Rules](/articles/new-expensify/workspaces/Workspace-Rules#how-to-enable-workspace-rules). | ||
|
|
||
| The **Updated vendor** field is offered only on a workspace where vendor matching is active, which requires an accounting connection that assigns vendors to company card expenses. Learn more about [vendor matching for QuickBooks Online](/articles/new-expensify/connections/quickbooks-online/Manage-Vendor-Matching-for-QuickBooks-Online). |
There was a problem hiding this comment.
| The **Updated vendor** field is offered only on a workspace where vendor matching is active, which requires an accounting connection that assigns vendors to company card expenses. Learn more about [vendor matching for QuickBooks Online](/articles/new-expensify/connections/quickbooks-online/Manage-Vendor-Matching-for-QuickBooks-Online). | |
| The **Updated vendor** field is offered only on a workspace where vendor matching is active. Learn more about [vendor matching for QuickBooks Online](/articles/new-expensify/connections/quickbooks-online/Manage-Vendor-Matching-for-QuickBooks-Online). |
| ## How Updated vendor values are matched when importing Merchant Rules | ||
|
|
||
| An **Updated vendor** cell holds the vendor's name, and Expensify matches that name against the vendor list imported from your accounting connection. | ||
|
|
||
| - Matching ignores capitalization and trims spaces around the name, so a cell of `starbucks ` matches a vendor named `Starbucks`. | ||
| - A vendor cell is skipped when no vendor in the workspace has that name, or when more than one vendor shares that name. The row's other updates still import. | ||
| - If **Updated vendor** was the only field the row updated, the whole row is skipped and no rule is created for it. | ||
|
|
||
| Sync your accounting connection before importing so the vendor list Expensify matches against is current. | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
| ## How Updated vendor values are matched when importing Merchant Rules | |
| An **Updated vendor** cell holds the vendor's name, and Expensify matches that name against the vendor list imported from your accounting connection. | |
| - Matching ignores capitalization and trims spaces around the name, so a cell of `starbucks ` matches a vendor named `Starbucks`. | |
| - A vendor cell is skipped when no vendor in the workspace has that name, or when more than one vendor shares that name. The row's other updates still import. | |
| - If **Updated vendor** was the only field the row updated, the whole row is skipped and no rule is created for it. | |
| Sync your accounting connection before importing so the vendor list Expensify matches against is current. | |
| --- |
|
|
||
| Check the spelling against your vendor list, then sync your accounting connection and import the remaining rows again. |
There was a problem hiding this comment.
| Check the spelling against your vendor list, then sync your accounting connection and import the remaining rows again. |
| ## Can I name my spreadsheet column Updated supplier instead of Updated vendor? | ||
|
|
||
| Yes. A column headed either `Updated vendor` or `Updated supplier` is detected automatically when you upload the file. The field you map it to is called **Updated vendor** on every workspace, including a workspace connected to Xero, where the rule itself shows the value as **Supplier**. | ||
|
|
There was a problem hiding this comment.
| ## Can I name my spreadsheet column Updated supplier instead of Updated vendor? | |
| Yes. A column headed either `Updated vendor` or `Updated supplier` is detected automatically when you upload the file. The field you map it to is called **Updated vendor** on every workspace, including a workspace connected to Xero, where the rule itself shows the value as **Supplier**. |
| title: Merchant Rules | ||
| description: Learn how to enable and use Merchant Rules to automatically apply consistent expense coding based on the expense merchant name. | ||
| keywords: [New Expensify, workspace merchant rules, merchant rules, auto-categorize by merchant, expense automation, expense rules, workspace settings, import merchant rules, bulk import merchant rules, merchant rules spreadsheet, merchant rule deleted tag, tag missing from merchant rule] | ||
| keywords: [New Expensify, workspace merchant rules, merchant rules, auto-categorize by merchant, expense automation, expense rules, workspace settings, import merchant rules, bulk import merchant rules, merchant rules spreadsheet, merchant rule deleted tag, tag missing from merchant rule, merchant rule vendor, updated vendor column] |
There was a problem hiding this comment.
| keywords: [New Expensify, workspace merchant rules, merchant rules, auto-categorize by merchant, expense automation, expense rules, workspace settings, import merchant rules, bulk import merchant rules, merchant rules spreadsheet, merchant rule deleted tag, tag missing from merchant rule, merchant rule vendor, updated vendor column] | |
| keywords: [New Expensify, workspace merchant rules, merchant rules, auto-categorize by merchant, expense automation, expense rules, workspace settings, import merchant rules, bulk import merchant rules, merchant rules spreadsheet, merchant rule deleted tag, tag missing from merchant rule, merchant rule vendor] |
| - Reimbursable status | ||
| - Billable status | ||
| - Tax | ||
| - Vendor (only on a workspace where vendor matching is active) |
There was a problem hiding this comment.
| - Vendor (only on a workspace where vendor matching is active) | |
| - Vendor |
| - **Updated description** — Apply a description (optional). | ||
| - **Reimbursable** — Set reimbursable status to **True** or **False** (optional). | ||
| - **Billable** — Set billable status to **True** or **False** (optional). | ||
| - **Updated vendor** — Apply a vendor by name (optional, and only on a workspace where vendor matching is active). |
There was a problem hiding this comment.
| - **Updated vendor** — Apply a vendor by name (optional, and only on a workspace where vendor matching is active). | |
| - **Updated vendor** — Apply a vendor by name (optional). |
|
@MelvinBot Check my requested changes above |
Co-authored-by: dominictb <dominictb@users.noreply.github.com> Co-authored-by: Dominic Tu <dominictb@users.noreply.github.com>
|
Applied all 12 suggestions in 03a0cb4. The PR is now 6 added lines across the two articles, down from 37. What's left:
What was removed: the whole How Updated vendor values are matched section, the vendor-skipped confirmation bullet, both new FAQs, and every frontmatter change on Two small deviations from the literal suggestion text
Checks run
The PR description has been updated to match the trimmed scope. |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: dominictb <dominictb@users.noreply.github.com> Co-authored-by: Dominic Tu <dominictb@users.noreply.github.com>
|
Checked all 12. Eleven were already correct; one wasn't, and I've just fixed it in 12909c8. The one that was off: the One thing to flag so you can overrule me either way: Verification of all 12 suggestions against the branchVerified with literal
A sweep for the removed prose ( The PR is now 7 added lines, 3 removed, across the two articles. |
|
A preview of your ExpensifyHelp changes have been deployed to https://edc100d7.helpdot.pages.dev ⚡️ Updated articles: |
|
@MelvinBot Fill both "Tests" and "QA Tests" as "None" then mark this PR as ready for review |
PR Author Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / Safari |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@strepanier03 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Done. Both Tests and QA Steps now read I left the PR Author Checklist boxes unchecked. Those are your attestations as co-author — several (all-platform testing, High Traffic account, screenshots) aren't things I can truthfully check on your behalf. |
| --- | ||
| title: Import Merchant Rules using a spreadsheet | ||
| description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, and how Tag values are interpreted for single-level and multi-level tags. | ||
| description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags. |
There was a problem hiding this comment.
Readability: Removing "and" leaves an ungrammatical run-on list ("...importing a spreadsheet, how Tag values are interpreted..."). Restore the conjunction so the two clauses read cleanly.
| description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, how Tag values are interpreted for single-level and multi-level tags. | |
| description: Learn how to bulk-create Merchant Rules by importing a spreadsheet, and how Tag values are interpreted for single-level and multi-level tags. |
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
strepanier03
left a comment
There was a problem hiding this comment.
Super solid, updates are good.
|
🚀 Deployed to staging by https://github.com/strepanier03 in version: 9.4.92-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Help site follow-up for [Vendor matching CC] Vendor column in merchant-rules CSV importer, which added an Updated vendor option to the merchant-rules spreadsheet importer.
The two published articles that document the merchant-rules importer listed every mappable field except the new one. This PR adds it, trimmed down to the minimum after review feedback.
docs/articles/new-expensify/workspaces/Import-Merchant-Rules.mddocs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.mdEvery label was taken from
src/languages/en.ts(importColumnUpdatedVendor: 'Updated vendor'), and the Rules page path — Expense defaults tab, More, Import merchant rules — was verified against the live web app.docs/assets/Files/merchant-rule-import-template.csvwas not changed. Adding anUpdated vendorcolumn would put an unmappable column in the template for every workspace without vendor matching. Say the word and I'll add it.Fixed Issues
$ #100762
PROPOSAL:
Tests
None
Offline tests
N/A — help site markdown only.
QA Steps
None
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari