Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.4.95-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #101893
Email or phone of affected tester (no customers): ibellicotest+2766@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 / Chrome
App Component: Money Requests
Action Performed:
Prerequisite: Account has a workspace.
Prerequisite 2: Approvals and payments enabled.
- Open the staging.new.expensify.com website.
- Navigate to workspace chat.
- Create at least two manual expenses.
- Open the report of the just created expenses.
- Submit and approve the expenses.
- Click on the "Pay" button on top of report.
- Note that payment options are "Pay with business account" and "Mark as paid". None of the options show the amount to pay,
- Select the created expenses.
- Click on the "Pay" button on the floating menu.
- Note that the payment options now are "Pay XX as a business" and "Mark XX as paid". Both options show the amount to pay.
Expected Result:
Payment options in submenu should be displayed in a consistent way on header button and on floating menu.
Actual Result:
Payment options in submenu are displayed in inconsistent way on header button and on floating menu. Options in floating menu show the amount to pay, while options in header don´t.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7272035_1790637495580.Float_5.mp4
Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7272035
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022104798901091083312
- Upwork Job ID: 2104798901091083312
- Last Price Increase: 2026-09-29
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsNo status
Activity
applause-bot commentedon Sep 29, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/7e3702ed3aaaad1fa64c510fce7d7fc1a32ed631f3fb7f7eef7042c2b29b89d0
MelvinBot commentedon Sep 29, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On an approved report, the header Pay $XX submenu shows "Pay with business account" and "Mark as paid". The floating bulk action bar Pay $XX submenu shows "Pay $XX as a business" and "Mark $XX as paid". The two menus should match.
What is the root cause of that problem?
The two menus build their options in different places.
SettlementButtongets its options fromuseSettlementButtonPaymentMethods, which always passes''as the amount (SettlementButtonUtils.ts:24,:31).useSelectionModePayment→usePaymentOptions. That hook still passesformattedAmounttoiou.settleBusinessandiou.payElsewhere(usePaymentOptions.ts:123,:128).Leaving the amount out is the app-wide convention. feat: standardize pay button for expenses and IOUs set it, and
usePaymentOptionswas never updated to follow it. Its own personal-account option at line 118 already passes''.This has been wrong for a while. It became visible after Use the floating bulk action bar for the report view table, because the header now stays on screen next to the floating bar (
MoneyReportHeaderActions/index.tsx:71).What changes do you think we should make in order to solve the problem?
In
usePaymentOptions, pass''instead offormattedAmountfor theVBBA(settleBusiness) andELSEWHERE(payElsewhere) options. Keep the invoice options that include the amount, because every builder shows the amount for invoices.Every caller already shows the amount in the parent Pay $XX item, so nothing is lost. This one change also fixes the same inconsistency in:
What alternative solutions did you explore? (Optional)
Add the amount to
SettlementButtonUtilsinstead. I don't recommend it. It goes against the standardize pay button convention and would change the report preview, the Search Pay cell, and Search bulk Pay.Supporting evidence
AnimatedSettlementButtonwithformattedAmount, but only uses it for the "Pay $XX" button label (PayPrimaryAction.tsx:204-222).formattedAmount: totalAmountintouseSelectionModePaymentand builds the "Pay $XX" parent item withpaymentSubMenuItems(useSelectionModeReportActions.ts:274-284).useSettlementButtonPaymentMethodswith no amounts (useBulkPayOptions.ts:79).en.ts:1585-1586).tests/unit/hooks/useSelectionModeReportActions.test.tsmocksusePaymentOptions, so it should not break.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/102490)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
melvin-bot commentedon Sep 29, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)[-]Web - Report - Options in payment submenu are inconsistent on header and floating menu.[/-][+][$175] Web - Report - Options in payment submenu are inconsistent on header and floating menu.[/+]melvin-bot commentedon Sep 29, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022104798901091083312
bconnnnn commentedon Sep 29, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On an approved report, the header Pay $XX submenu shows “Pay with business account” and “Mark as paid,” while the floating bulk-action submenu shows “Pay $XX as a business” and “Mark $XX as paid.” Both menus should use the same option labels.
What is the root cause of that problem?
The two menus build the same payment actions through different hooks. useSettlementButtonPaymentMethods passes an empty amount to the business-account and pay-elsewhere translations in the header. The floating menu uses usePaymentOptions, which passes
formattedAmountto those same two translation keys. The parent Pay button already displays the amount, so including it again in only the floating submenu creates the inconsistency.What changes do you think we should make in order to solve the problem?
In
usePaymentOptions, pass an empty amount to theVBBA(settleBusiness) andELSEWHERE(payElsewhere) options, matching the header hook. Keep the amount on the parent Pay action and preserve amounts in invoice options where they are part of the established label.What tests should be added?
Add coverage for the payment option labels returned by
usePaymentOptions: business-account and pay-elsewhere submenu labels should omit the amount, while the parent Pay action still shows it. Include invoice options in the test to ensure their amount labels remain unchanged, and verify the header and floating menus present matching text.Concrete code change
In
src/hooks/usePaymentOptions.ts, keep the amount on the parent Pay action, but use the same empty amount argument asuseSettlementButtonPaymentMethodsfor these two submenu entries:Keep
formattedAmountfor the approval and invoice labels that use it. Add a test with a non-empty amount proving the floating submenu matches the header while the parent Pay button still shows the amount.franklincg commentedon Sep 29, 2026
Proposal
Root cause
The inconsistency comes from the two payment menus formatting the same actions differently.
The report header path already follows the app-wide convention and omits the amount from submenu labels. The floating selection-mode path still passes
formattedAmountinto the business-account and pay-elsewhere translation keys, so it renders labels such as “Pay $XX as a business” / “Mark $XX as paid”.The amount is already shown by the parent Pay action, so repeating it only in the floating submenu makes the two menus diverge.
Fix
Align the floating-menu payment options with the header:
usePaymentOptions, pass an empty amount for the business-account and pay-elsewhere submenu labels;This keeps the change scoped to label formatting and avoids changing settlement behavior.
Validation
I would cover:
bonnhatnguyen commentedon Sep 29, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On an approved expense report, clicking the Pay $XX primary button in the report header displays payment submenu options without amounts ("Pay with business account", "Mark as paid"), whereas selecting expenses and clicking Pay $XX on the floating bulk action bar displays submenu options with amounts ("Pay $XX as a business", "Mark $XX as paid"). The payment submenus between the header and floating menu diverge, creating an inconsistent user experience.
What is the root cause of that problem?
Header Settlement Button Convention:
In
src/libs/SettlementButtonUtils.ts(lines 24 & 31),useSettlementButtonPaymentMethodspasses an empty string''totranslate('iou.settleBusiness', '')andtranslate('iou.payElsewhere', ''):Per app-wide convention, because the parent button already displays the total settlement amount ("Pay $XX"), the submenu options omit the redundant amount to keep the menu items concise and clean ("Pay with business account", "Mark as paid").
Inconsistency in
usePaymentOptions.ts:The floating bulk action bar derives its payment submenu items via
useSelectionModePayment→usePaymentOptions.ts(lines 116–132).Notice that line 118 (
CONST.IOU.PAYMENT_TYPE.EXPENSIFY) was already updated to pass'':However,
VBBA(line 123) andELSEWHERE(line 128) were missed and continued to passformattedAmount:Because
translate('iou.settleBusiness', formattedAmount)evaluates to"Pay ${formattedAmount} as a business"whenformattedAmountis non-empty, and"Pay with business account"when empty, passingformattedAmountcauses the floating submenu to diverge from the header submenu.Furthermore,
MoneyReportHeaderSecondaryActions.tsx(when Pay is placed inside the secondary More menu) also consumesusePaymentOptions, inheriting this same repetitive label format.What changes do you think we should make in order to solve the problem?
In
src/hooks/usePaymentOptions.ts, updatepaymentMethodsforCONST.IOU.PAYMENT_TYPE.VBBAandCONST.IOU.PAYMENT_TYPE.ELSEWHEREto pass an empty string''instead offormattedAmount:Why this is the complete and robust fix:
CONST.IOU.PAYMENT_TYPE.EXPENSIFYat line 118 in the same hook, which already passes''.MoneyReportHeaderSecondaryActionswithout touching secondary action plumbing.''for their sub-items).Automated Unit Tests:
Add unit test coverage in
tests/unit/hooks/usePaymentOptionsTest.ts:formattedAmount = '$50.00', verify thatVBBAreturnstext: 'Pay with business account'andELSEWHEREreturnstext: 'Mark as paid'.approveButtonOption) continues to receive{formattedAmount}.What alternative solutions did you explore? (Optional)
formattedAmounttoSettlementButtonUtils.ts:Rejected because the parent button already displays
"Pay $XX". Repeating the amount on every child submenu row adds visual clutter and contradicts the established design pattern introduced in PR feat: standardize pay button for expenses and IOUs #66790.Contributor details
Your Expensify account email: bonnhatnguyen0@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0139ed4098bdc50182
melvin-bot commentedon Sep 29, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
bconnnnn commentedon Sep 30, 2026
@MelvinBot @mananjadhav I added the exact label change and regression-test coverage to my proposal above. I’m available to implement it. Could you review the updated proposal and let me know if I should take this issue?
17 remaining items
jeffrey-graham commentedon Nov 7, 2026
melvin-bot commentedon Nov 7, 2026
melvin-bot commentedon Nov 10, 2026
@mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!
mananjadhav commentedon Nov 12, 2026
@MelvinBot implement this
MelvinBot commentedon Nov 12, 2026
🤖 Web test steps verification results:⚠️ partial
Verified app access and workspace chat on dev NewDot web. Expense creation was blocked by dialog-targeting errors; the payment submenu fix remains unverified.

1. Open the web app
Authenticated Home screen confirmed.2. Navigate to workspace chat
Workspace expense chat confirmed.3. Create two manual expenses
Automation could not dismiss the location-access dialog. No expenses created.4. Open their report
Not verified: expenses unavailable.5. Submit and approve expenses
Not verified: report unavailable.6. Open header Pay
Not verified: approved report unavailable.7. Check header submenu labels
Payment submenu not reached.8. Select both expenses
Not verified: expenses unavailable.9. Open floating Pay
Selection prerequisite unavailable.10. Compare submenu labels and parent amount
Neither payment submenu was reached.Implemented in Draft PR: Align expense payment submenu labels with report header, assigned to
mananjadhav.59 targeted tests, lint, typecheck, spelling, and Storybook smoke passed. Full-suite testing timed out; remaining tooling limitations are documented in the PR. Manual payment-menu verification is still required.
view run · no recording available
expensify-chore-bot commentedon Nov 15, 2026
Triggered auto assignment to @NicolasBonet, see https://stackoverflow.com/c/expensify/questions/7972 for more details.