Repository navigation
Align expense payment submenu labels with report header - #106781
Conversation
Co-authored-by: Manan <mananjadhav@users.noreply.github.com>
|
🤖 Android test steps verification results: Verified steps 1–10 on standalone Android NewDot: both Pay submenus show amount-free options, while selection Pay retains $30.00. Console-error verification was blocked by log-access restrictions; no functional failures were demonstrated.
|
Co-authored-by: Manan <mananjadhav@users.noreply.github.com>
|
Pushed 06471c3 to fix the Oxfmt failure—test formatting only, no runtime changes. Passed locally: formatting, targeted lint, TypeScript, and 13 targeted tests. Broader checks timed out; limitations are recorded in the PR. New CI results aren’t available yet. Independent approval still requires human review. |
|
🤖 Web test steps verification results: Verified dev NewDot web and workspace-chat navigation, with approvals and payments configured. Expense creation was blocked by a location-access dialog whose controls the driver repeatedly reported as covered; payment-menu behavior remains unverified.
view run · no recording available |
|
|
|
@MelvinBot Rerun Web test steps verification |
|
🤖 Web test steps verification results: Verified the dev NewDot web app and opened the newly created workspace chat. Expense creation was blocked because the driver rejected clicks on the visible Create expense option as covered by a dialog; payment-menu behavior remains unverified.
view run · no recording available |
|
@MelvinBot Mark it ready for review. |
|
Marked Align expense payment submenu labels with report header ready for review. |
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Code changes look fine. Working on the checklist now. |
QA StepsPrecondition: Workspace with Approvals and Payments enabled. The report-header Pay menu shows "Pay with business account" and "Mark as paid".
Offline StepsSame as the QA Steps. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-pay-button.moviOS: HybridAppios-pay-button.moviOS: mWeb Safarimweb-safari-pay-button.movMacOS: Chrome / Safariweb-pay-button.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #102490 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
@NicolasBonet Can you help update the QA steps in the PR body. |
NicolasBonet
left a comment
There was a problem hiding this comment.
@mananjadhav we need to fill the other parts of the pr description like offline tests
|
@NicolasBonet The QA steps and Offline steps are the same. I've marked the comment to reflect that. |
Let's mark the checkboxes accordingly to know what's missing, please |
|
@NicolasBonet This PR is from MelvinBot and we (C+ members) don't have the access to update the author checklist. Generally hence as C+ members we post our Reviewer Checklist and add the QA steps in a comment. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR only removes redundant amounts from payment submenu labels, without changing the payment workflow or making any existing article sentence incorrect. |












Explanation of Change
Align expense payment submenu labels with the report header by omitting the redundant amount from the business-account and mark-as-paid options. The parent Pay amount and invoice category amounts remain unchanged.
Add regression coverage comparing header and selection payment labels and preserving invoice amounts.
Fixed Issues
$ #102490
PROPOSAL: #102490 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
// TODO: The human co-author must fill out the offline tests before marking this PR as "ready for review".
QA Steps
Precondition: Workspace with Approvals and Payments enabled. The report-header Pay menu shows "Pay with business account" and "Mark as paid".
AI Tests
Formatting-check follow-up (2026-11-12):
npm run fmt; a second run produced no additional changes.npm run typecheck, and all 13 tests in the payment-options and settlement-button suites.lint-changedandspell-changedtimed out fetching main history. The repository now uses Oxfmt (npm run fmt), replacing the older Prettier command in the test matrix.Original implementation validation:
Contributor branch ownership
To move the branch to your fork:
You can then close this draft and open a replacement from your fork.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web test setup blocker (not evidence of the payment submenu fix):
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari