Skip to content

[HeaderWithBackButton migration] Central Pane: HeaderCentralPane preset + Split Navigator root screens #102546

Open

Description

@MelvinBot

Part of #96611 — migration of legacy HeaderWithBackButton call-sites to the composed Header API.

Scope

Central Pane batch — adds a HeaderCentralPane preset and migrates the Split Navigator root screens (Workspace/Settings/Domain) to it.

Draft PR: #102523

Background

Central Pane headers share the same shape:

  • a headline title
  • a back button shown only on narrow layout (on wide layout, the sidebar covers "back")
  • the Side Panel help button

Without a dedicated preset, each of these ~32 screens would hand-roll the same useResponsiveLayout + conditional <HeaderBackButton> + <HeaderRight>{children}<SidePanelButton/></HeaderRight> composition. A targeted preset keeps call-sites concise and easier to use and test.

Context: #96611 (comment)

Changes

  • Add src/components/Header/composed/HeaderCentralPane.tsx, with an optional child slot (for example, SearchButton on the Settings pages that need it).
  • Migrate 32 root screens (top-level Settings pages, Domain pages, and every WorkspacePageWithSections-based workspace page) to HeaderCentralPane.
  • Keep 31 non-root screens (workspace/rules/*, WalletStatementPage, ValidateCodeActionContent) on HeaderWithBackButtonAndTitle.
  • Compose Header primitives directly in DynamicTripDetailsPage and VictoryChartExpandModal, since neither fits a preset.
  • Delete the now caller-less HeaderWithBackButtonComposed/HeaderWithBackButton.tsx drop-in.

No behavior or visual change intended.

Full batch plan: #96611 (comment)

Files

99 files (from the draft PR)

config/eslint/eslint.config.mjs
config/eslint/eslint.seatbelt.tsv
src/components/AvatarWithDisplayName.tsx
src/components/HTMLEngineProvider/HTMLRenderers/VictoryChartRenderer/components/VictoryChartExpandModal.tsx
src/components/Header/Header.tsx
src/components/Header/composed/HeaderCentralPane.tsx
src/components/Header/composed/HeaderWithBackButtonAndTitle.tsx
src/components/Header/context/HeaderContext.tsx
src/components/Header/index.tsx
src/components/Header/layout/HeaderActions.tsx
src/components/Header/layout/HeaderRight.tsx
src/components/Header/primitives/HeaderAvatarWithDisplayName.tsx
src/components/Header/primitives/HeaderBackButton.tsx
src/components/Header/primitives/HeaderCloseButton.tsx
src/components/Header/primitives/HeaderDownloadButton.tsx
src/components/Header/primitives/HeaderIcon.tsx
src/components/Header/primitives/HeaderIconButton.tsx
src/components/Header/primitives/HeaderThreeDotsMenu.tsx
src/components/Header/primitives/HeaderTitle.tsx
src/components/HeaderWithBackButtonComposed/HeaderWithBackButton.tsx
src/components/HeaderWithBackButtonComposed/index.tsx
src/components/HeaderWithBackButtonComposed/primitives/HeaderTitle.tsx
src/components/HeaderWithBackButtonComposed/styles/useHeaderStyles.ts
src/components/ValidateCodeActionModal/ValidateCodeActionContent.tsx
src/pages/TeachersUnite/SaveTheWorldPage.tsx
src/pages/Travel/DynamicTravelUpgrade.tsx
src/pages/Travel/DynamicTripDetailsPage.tsx
src/pages/domain/Admins/DomainAdminsPage.tsx
src/pages/domain/DomainSamlPage.tsx
src/pages/domain/Groups/DomainGroupsPage.tsx
src/pages/domain/Members/DomainMembersPage.tsx
src/pages/settings/AboutPage/AboutPage.tsx
src/pages/settings/Agents/AgentsPage.tsx
src/pages/settings/Copilot/CopilotPage.tsx
src/pages/settings/HelpPage/HelpPage.tsx
src/pages/settings/Preferences/PreferencesPage.tsx
src/pages/settings/Profile/ProfilePage.tsx
src/pages/settings/Rules/ExpenseRulesPage.tsx
src/pages/settings/Security/SecuritySettingsPage.tsx
src/pages/settings/Subscription/PaymentHistoryPage/index.tsx
src/pages/settings/Subscription/SubscriptionSettingsPage.tsx
src/pages/settings/Troubleshoot/TroubleshootPage.tsx
src/pages/settings/Wallet/WalletPage/index.tsx
src/pages/wallet/WalletStatementPage.tsx
src/pages/workspace/WorkspaceMoreFeaturesPage/index.tsx
src/pages/workspace/WorkspacePageWithSections.tsx
src/pages/workspace/accounting/PolicyAccountingPage.tsx
src/pages/workspace/categories/WorkspaceCategoriesPage.tsx
src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx
src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx
src/pages/workspace/mcp/WorkspaceMCPPage.tsx
src/pages/workspace/merge/MergeConnectionsPageBase.tsx
src/pages/workspace/merge/MergeFinalApproverPageBase.tsx
src/pages/workspace/merge/MergeSyncResultsPageBase.tsx
src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx
src/pages/workspace/receiptPartners/WorkspaceReceiptPartnersPage.tsx
src/pages/workspace/recruiting/approver/MergeATSApprovalModePage.tsx
src/pages/workspace/recruiting/approver/MergeATSApproverFieldPage.tsx
src/pages/workspace/recruiting/merge/filters/MergeATSFilterSelectionPage.tsx
src/pages/workspace/recruiting/merge/filters/MergeATSFiltersPage.tsx
src/pages/workspace/reports/WorkspaceReportsPage.tsx
src/pages/workspace/rooms/WorkspaceRoomsPage.tsx
src/pages/workspace/rules/AgentRules/AddAgentRulePage.tsx
src/pages/workspace/rules/AgentRules/EditAgentRulePage.tsx
src/pages/workspace/rules/FlagForReviewRules/FlagForReviewRuleAmountPageBase.tsx
src/pages/workspace/rules/FlagForReviewRules/FlagForReviewRulePageBase.tsx
src/pages/workspace/rules/MerchantRules/AddCategoryToMatchPage.tsx
src/pages/workspace/rules/MerchantRules/AddMatchTypePage.tsx
src/pages/workspace/rules/MerchantRules/AddMerchantToMatchPage.tsx
src/pages/workspace/rules/MerchantRules/ExpenseDefaultTypePage.tsx
src/pages/workspace/rules/MerchantRules/ImportedMerchantRulesPage.tsx
src/pages/workspace/rules/MerchantRules/MerchantRulePageBase.tsx
src/pages/workspace/rules/MerchantRules/PreviewMatchesPage.tsx
src/pages/workspace/rules/MerchantTypeRules/MerchantTypeRulePageBase.tsx
src/pages/workspace/rules/RequireFieldsRules/RequireFieldsRulePageBase.tsx
src/pages/workspace/rules/RulesAutoApproveReportsUnderPage.tsx
src/pages/workspace/rules/RulesAutoPayReportsUnderPage.tsx
src/pages/workspace/rules/RulesBillableDefaultPage.tsx
src/pages/workspace/rules/RulesCustomPage.tsx
src/pages/workspace/rules/RulesItemizedReceiptRequiredAmountPage.tsx
src/pages/workspace/rules/RulesMaxExpenseAgePage.tsx
src/pages/workspace/rules/RulesMaxExpenseAmountPage.tsx
src/pages/workspace/rules/RulesNewPage.tsx
src/pages/workspace/rules/RulesProhibitedDefaultPage.tsx
src/pages/workspace/rules/RulesRandomReportAuditPage.tsx
src/pages/workspace/rules/RulesReceiptRequiredAmountPage.tsx
src/pages/workspace/rules/RulesReimbursableDefaultPage.tsx
src/pages/workspace/rules/RulesRequireFieldsPage.tsx
src/pages/workspace/rules/RulesRequireReceiptsPage.tsx
src/pages/workspace/rules/SpendRules/SpendRuleCardPage.tsx
src/pages/workspace/rules/SpendRules/SpendRulePageBase.tsx
src/pages/workspace/rules/useRuleDeleteHeaderProps.ts
src/pages/workspace/tags/WorkspaceTagsPage.tsx
src/pages/workspace/taxes/WorkspaceTaxesPage.tsx
src/pages/workspace/travel/PolicyTravelPage.tsx
src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx
src/pages/workspace/vendors/WorkspaceVendorsPage.tsx
tests/ui/SpendRuleCardPageTest.tsx
tests/ui/components/MoneyReportHeaderFocusSelectionModeTest.tsx

Activity

  1. added
    Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.
    on Sep 29, 2026
  2. melvin-bot commented on Oct 26, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @mountiny, @Guccio163, @gijoe0295 eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  3. Guccio163 commented on Oct 27, 2026

    @Guccio163
    Contributor

    I've discussed styling change with designers, so I'll get back to this shortly 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

MonthlyKSv2ReviewingHas a PR in reviewSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions