You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-15] [$175] Home - Not here page when accessing just deleted offline expense from arrow button #103083
Version Number: 102948 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/40579099/test-cases/116695500 Email or phone of affected tester (no customers):gatantm+697@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: macOS Safari App Component: Other
Action Performed:
Launch new expensify
Open Home and make sure there are recent expenses so that the Recently added section is shown
Use CMD+D or CTRL+D to access dev tools and enable force offline
Click on the first Expense > More and delete it
Back on Home click on the next expense to the deleted one (under the strike out one)
Use the left arrow to access the deleted expense
Expected Result:
The deleted expense is shown
Actual Result:
"Hmm... it's not here" error is shown on the Right hand modal
Opening an expense from Home's "Recently added" section seeds the carousel with every row, including the struck-out, pending-delete row. On the reported build, the arrow component used this list unfiltered. The left arrow therefore opened the deleted expense's thread.
The offline delete marks that thread's parent IOU action as pendingAction: DELETE. ReportNotFoundGuard treats a pending-delete parent action as a deleted transaction thread and shows "Hmm... it's not here".
Tapping the struck-out row on Home already does nothing on purpose. The arrows had no matching guard.
The new filter from the PR above: useCarouselTransactionIDs.ts:43. Before that PR, MoneyRequestReportTransactionsNavigation read TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS directly with no filter.
What changes do you think we should make in order to solve the problem?
Close a remaining gap: in RecentlyAddedSection/index.tsx, build siblingTransactionIDs and the descriptor map from rows that are not pending delete. Today, if the device comes back online while the RHP is open, the transaction is removed from Onyx. useCarouselTransactionIDs.ts:39-41 then keeps the ID because a descriptor exists, so the arrow could lead to "not here" again. I found this by reading the code; I haven't reproduced it.
What alternative solutions did you explore? (Optional)
Showing the deleted expense, as the issue's expected result says, would mean relaxing the deleted-thread check in TransactionNavigationUtils.ts. That check covers every deleted-thread case in the app, so I don't recommend it. Product should confirm whether "skip the deleted expense" is the intended behavior.
Confidence and testing
Medium confidence. The code evidence is clear, but I couldn't run a web test: the test session didn't load past sign-in. The PR's own unit test covers the report-level version of this bug (tests/unit/components/MoneyRequestReportTransactionsNavigation.test.tsx).
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/103083) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Home - Not here page when accessing just deleted offline expense from arrow button[/-][+][$175] Home - Not here page when accessing just deleted offline expense from arrow button[/+]on Oct 5, 2026
The PR stops Home's "Recently added" section from adding pending-delete expenses to the carousel. The arrows can no longer reach the deleted expense, including after the device comes back online. A new unit test covers this. The related tests, typecheck, lint and spell check pass.
I couldn't run a web test because the test browser session didn't load. The React Compiler check also couldn't run here. CI will run it.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.5-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-15. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A — not a critical regression, it only affected the carousel arrows for pending-delete expenses.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Log in and open the Home page
Make sure the "Recently added" section shows at least 3 expenses
Test:
Open dev tools (CMD+D / CTRL+D) and enable Force offline
Open the first (newest) expense, select More > Delete
Go back to Home and verify the deleted expense shows with strikethrough
Open the expense right below the deleted one
Verify the previous carousel arrow does not navigate to the deleted expense
Verify "Hmm... it's not here" is never shown
Use the next and previous arrows and verify they only move between non-deleted expenses
Turn off Force offline and wait for the delete to sync
Verify the deleted expense is removed and the arrows still skip it
Activity
applause-bot commentedon Oct 5, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/4daef7510e1e13c6631386ac4a9adbae8dc77df33c4c6b231bbaefb4544b1081
MelvinBot commentedon Oct 5, 2026
Proposal
Likely already fixed on
main. The reported build (deploy checklist Deploy Checklist: New Expensify 2026-10-04) predates Standardize Expense Report and Expense header with predictable button placement and carousel counter, merged 2026-10-05. That PR removes pending-delete expenses from the carousel arrows. Please retest on the next staging build. One small gap remains, described below.What is the root cause of that problem?
Opening an expense from Home's "Recently added" section seeds the carousel with every row, including the struck-out, pending-delete row. On the reported build, the arrow component used this list unfiltered. The left arrow therefore opened the deleted expense's thread.
The offline delete marks that thread's parent IOU action as
pendingAction: DELETE.ReportNotFoundGuardtreats a pending-delete parent action as a deleted transaction thread and shows "Hmm... it's not here".Tapping the struck-out row on Home already does nothing on purpose. The arrows had no matching guard.
Code references
RecentlyAddedSection/index.tsx:71-81TransactionNavigationUtils.ts:65, used inReportNotFoundGuard.tsx:155-163RecentlyAddedRow.tsx:89-99useCarouselTransactionIDs.ts:43. Before that PR,MoneyRequestReportTransactionsNavigationreadTRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDSdirectly with no filter.What changes do you think we should make in order to solve the problem?
RecentlyAddedSection/index.tsx, buildsiblingTransactionIDsand the descriptor map from rows that are not pending delete. Today, if the device comes back online while the RHP is open, the transaction is removed from Onyx.useCarouselTransactionIDs.ts:39-41then keeps the ID because a descriptor exists, so the arrow could lead to "not here" again. I found this by reading the code; I haven't reproduced it.What alternative solutions did you explore? (Optional)
Showing the deleted expense, as the issue's expected result says, would mean relaxing the deleted-thread check in
TransactionNavigationUtils.ts. That check covers every deleted-thread case in the app, so I don't recommend it. Product should confirm whether "skip the deleted expense" is the intended behavior.Confidence and testing
Medium confidence. The code evidence is clear, but I couldn't run a web test: the test session didn't load past sign-in. The PR's own unit test covers the report-level version of this bug (
tests/unit/components/MoneyRequestReportTransactionsNavigation.test.tsx).Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/103083)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run · no recording available
melvin-bot commentedon Oct 5, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abzokhattab (
External)[-]Home - Not here page when accessing just deleted offline expense from arrow button[/-][+][$175] Home - Not here page when accessing just deleted offline expense from arrow button[/+]melvin-bot commentedon Oct 5, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022107211091505742272
abzokhattab commentedon Oct 6, 2026
@MelvinBot implement this
MelvinBot commentedon Oct 6, 2026
🤖 Draft PR created: Keep pending-delete expenses out of the Recently added carousel
Please mark it as "Ready for review" when it is ready for review.
The PR stops Home's "Recently added" section from adding pending-delete expenses to the carousel. The arrows can no longer reach the deleted expense, including after the device comes back online. A new unit test covers this. The related tests, typecheck, lint and spell check pass.
I couldn't run a web test because the test browser session didn't load. The React Compiler check also couldn't run here. CI will run it.
view run · no recording available
abzokhattab commentedon Oct 6, 2026
MelvinBot proposal looks good to me
🎀 👀 🎀 C+ reviewed
melvin-bot commentedon Oct 6, 2026
Triggered auto assignment to @chuckdries, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
7 remaining items
melvin-bot commentedon Oct 8, 2026
@abzokhattab
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.5-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-15. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
abzokhattab commentedon Oct 12, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: [Home Page] Add Recently added slot to Home #93451 (comment)
Link to the comment on the Issue: N/A
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A — not a critical regression, it only affected the carousel arrows for pending-delete expenses.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Oct 14, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 14, 2026
Payment Summary
Resolving PRs:
Keep pending-delete expenses out of the Recently added carousel #103109
Reviewer: @abzokhattab owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Oct 17, 2026
Payment Summary
Contributor+: @abzokhattab due $175 via NewDot