Repository navigation
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
Triggered an adhoc, will test when it's ready. |
This comment has been minimized.
This comment has been minimized.
|
It works for me, though the most recent expenses don't seem to be right. |
|
It's showing my most recent expense as april 12, though on the Spend page my most recent expense is June 12 |
|
I'll share my details in Slack. Also for the empty state, we ended up changing the wording. The sub-text should be "Create one or drag a receipt here." |
|
Totally agree with those points Jon. Ideally we would share styles between the two if possible so we don't need to manage the same exact thing in multiple places. |
This comment has been minimized.
This comment has been minimized.
TDD red phase: cover the recent-expenses data hook selection (sort by inserted, current-user scope, 5-row cap, status agnostic), the section's empty state, rows, RHP navigation and overflow menu, and the updated Home slot ordering with Discover relocation. Implementation follows.
a1f0f5a to
815f807
Compare
|
@adamgrzybowski ping when youre ready for a build! |
|
@grgia I am fixing one more thing, will let you know soon |
|
@grgia @JmillsExpensify Should work now. You can retest it. I will clean the code from any leftovers tomorrow, so I would skip the code review for now |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Deploy Blocker #94237 was identified to be related to this PR. |
|
Deploy Blocker #94240 was identified to be related to this PR. |
|
Deploy Blocker #94247 was identified to be related to this PR. |
|
Deploy Blocker #94249 was identified to be related to this PR. |
|
Deploy Blocker #94250 was identified to be related to this PR. |
|
Deploy Blocker #94251 was identified to be related to this PR. |
|
Deploy Blocker #94272 was identified to be related to this PR. |
|
Deploy Blocker #94311 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
|
This PR added the A search that was still in flight, or one that had failed, produced that same empty array, which is why Home told users with plenty of expenses that they had none. The hook now returns This was fixed here: #98969 More information is available here: #98895 |
|
The carousel seeding in const siblingDescriptorsByTransactionID = transactions.reduce<Record<string, TransactionThreadNavigationDescriptor>>((map, sibling) => {
map[sibling.transactionID] = {
reportID: sibling.reportID,
transaction: sibling.transaction,
reportAction: sibling.reportAction,
report: sibling.report,
};
return map;
}, {});While tapping the struck-out row was already disabled ( Fixed in #103109 |




Explanation of Change
insertedtimestamp (when the expense was added to the system), most recent first and independent of the expense date, and capped at five rows. Each row shows the receipt thumbnail, expense date, merchant, and amount.Fixed Issues
$ #92658
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-16.at.14.23.20.mov