Skip to content

[Due for payment 2026-07-02] [Due for payment 2026-07-01] [$250] Home/Spend-App becomes unresponsive after tapping View all expenses #94410

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.18-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #93451
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 iOS 26.5
App Component: Other

Action Performed:

  1. Sign up to ND with a new gmail account with "Manage" purpose
  2. Tap FAB - Create expense - Scan
  3. Scan a valid receipt in the workspace chat, selecting a category
  4. When the scan is complete, open Home tab, tap 3 dots in "Recently added" section, then tap "View all expenses"
  5. When navigated to the Spend tab, try to tap on anything to open another tab or page

Expected Result:

The app is functioning after navigating to the Spend tab via View all expenses

Actual Result:

The app becomes unresponsive after tapping View all expenses in Home

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7189153_1782255636549.Recently_added.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7189153

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. applause-bot commented on Jun 24, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/b6d149f1467bad64e9b693fd938524a10fa9eb8f7e5b7e147a3dc1d1b1beda92

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 24, 2026
  3. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #93451

  4. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 24, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 24, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    After scanning a receipt, tapping the 3-dot overflow in the new Recently added Home slot and selecting View all expenses navigates to the Spend tab, but the app then becomes unresponsive to all taps (iOS native). Introduced by #93451.

    What is the root cause of that problem?

    The View all expenses menu item navigates synchronously inside onSelected while the popover is still open, with no shouldCallAfterModalHide. On iOS native the PopoverMenu is a full-screen Modal with a touch-capturing backdrop, and the Home tab stays mounted when you switch tabs. So the Navigation.navigate(SEARCH_ROOT) races the modal's slide-out dismissal, and the still-mounted backdrop ends up layered on top of the Spend tab, swallowing every tap.

    The onSelected callback fires Navigation.navigate(...) in the same synchronous tick as setIsOverflowMenuVisible(false) — RecentlyAddedSection/index.tsx:98-104 and :129-135.

    Evidence & ruled-out alternatives
    • PopoverMenu fires onSelected immediately, same tick as the close — with no shouldCallAfterModalHide, selectItem falls to the final else branch that calls onItemSelected and selectedItem.onSelected() synchronously: PopoverMenu/index.tsx:397-427. The safe branch defers the action via Modal.close(...) until the modal has hidden.
    • On native the popover is a full-screen Modal with a backdrop — Popover/index.native.tsx:10-22.
    • Home tab stays mounted on tab switch (freezeOnBlur, not unmount) — TabNavigator.native.tsx:33-39, so the open popover Modal remains on top of the now-focused Spend tab.
    • Established safe pattern — menu items that navigate to another screen/tab gate shouldCallAfterModalHide on narrow layout, e.g. CreateReportMenuItem.tsx:88-91,109 and ExpenseMenuItem.tsx:32-37. RecentlyAddedSection omits it.
    • Ruled out: WideRHP / active-transaction-IDs. navigateToExpensesPage never calls markReportIDAsExpense/setActiveTransactionIDs (those are only in the row-tap openExpense path). On native, WideRHP renders no overlay (WideRHPContextProvider/index.native.tsx, markReportIDAsExpense is a no-op default), and the Spend root renders none of this PR's code. The only new-code touchpoint on this flow is the PopoverMenu.

    What changes do you think we should make in order to solve the problem?

    Defer the navigation until the popover has fully dismissed by adding shouldCallAfterModalHide to the View all expenses menu item, matching the FAB pattern:

    menuItems={[
        {
            text: translate('homePage.recentlyAddedSection.viewAll'),
            icon: icons.Receipt,
            onSelected: navigateToExpensesPage,
            shouldCallAfterModalHide: true,
        },
    ]}

    This routes navigateToExpensesPage through Modal.close() so it runs from the modal's onModalHide, after the backdrop is gone — so no stuck overlay can layer over the Spend tab. (Gating on shouldUseNarrowLayout like the FAB items is also acceptable, since the issue only manifests on narrow/native layouts.)

    What alternative solutions did you explore?

    Closing the popover first and navigating from an InteractionManager/onModalHide callback would also work, but shouldCallAfterModalHide is the established, DRY mechanism already used across the app for exactly this case.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94410) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. mhawryluk commented on Jun 24, 2026

    @mhawryluk
    Member

    @ZhenjaHorbach I was able to reproduce the issue and the Melvin's proposed solution does indeed fix it

  8. ZhenjaHorbach commented on Jun 24, 2026

    @ZhenjaHorbach
    Contributor

    Nice
    Thanks for checking!

  9. ZhenjaHorbach commented on Jun 24, 2026

    @ZhenjaHorbach
    Contributor

    @MelvinBot
    Implement your proposal

  10. MelvinBot commented on Jun 24, 2026

    @MelvinBot
    Contributor

    🤖 Draft PR created: #94435
    Please mark it as "Ready for review" when it is ready for review.

  11. 4 remaining items

  12. self-assigned this
    on Jun 24, 2026
  13. m-natarajan commented on Jun 24, 2026

    @m-natarajan

    Not repro, iPhone 13/iOS26.5, v9.4.18-2

    Retest.94410.mp4
  14. changed the title [-][$250] Home/Spend-App becomes unresponsive after tapping View all expenses[/-] [+][Due for payment 2026-07-01] [$250] Home/Spend-App becomes unresponsive after tapping View all expenses[/+] on Jun 24, 2026
  15. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.18-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-01. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  18. changed the title [-][Due for payment 2026-07-01] [$250] Home/Spend-App becomes unresponsive after tapping View all expenses[/-] [+][Due for payment 2026-07-02] [Due for payment 2026-07-01] [$250] Home/Spend-App becomes unresponsive after tapping View all expenses[/+] on Jun 25, 2026
  19. melvin-bot commented on Jun 25, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-02. 🎊

    For reference, here are some details about the assignees on this issue:

  20. melvin-bot commented on Jun 25, 2026

    @melvin-bot

    @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions