You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-16] [$175] Home - marked as paid system message thread opens when opened from Recently added #99611
Version Number: 9.4.62-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#98611 Email or phone of affected tester (no customers):sdsiodjnosdjiodsj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Open 1:1 DM with any user.
Click + > Pay.
Enter amount > Next.
Click Mark as paid.
Go to Home.
Open the expense in Step 5 from Recently added.
Expected Result:
Expense report will open.
Actual Result:
marked as paid system message thread opens when opened from Recently added.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug (fix required in Expensify/App) Causing PR: #93451 - "[Home Page] Add Recently added slot to Home" by @adamgrzybowski (Medium confidence for the origin PR / High confidence on the root-cause code) Not the cause: #98611 - the auto-flagged PR (see below) Related Issues: Feature origin #90366 (the header standardization tracked by #98611)
Recommendation: ROLL FORWARD (targeted fix)
Reverting the auto-flagged PR #98611 will not fix this bug — it does not touch the code that chooses which report opens. The fix is a small, targeted change to how the tapped expense's IOU action is resolved in the Recently added slot, so we should roll forward rather than revert.
Assigned: (kept existing melvin auto-assignees) + added @adamgrzybowski (author), @ZhenjaHorbach and @grgia (approving reviewers) of the origin PR #93451, since the fix belongs in that feature code. Labels: No change. DeployBlockerCash is correctly retained (Frontend bug, App deploy blocked). No DeployBlocker (Web) label was present, so none removed.
PR #98611 ("Standardize Expense Report and Expense header…") is the PR Melvin auto-assigned because its author merged it and its BrowserStack field literally links to it. Its only change to the Recently added flow is a signature update in RecentlyAddedSection/index.tsx:
This inserts an undefined for the new snapshotHash parameter of setActiveTransactionIDs. It affects only the idempotency/dedup of the carousel's sibling transaction-ID list — it does not change which reportID is navigated to for the tapped expense. The navigation target is computed by getReportIDToOpenForExpense(...), which #98611 does not modify (its file list contains neither TransactionThreadNavigationUtils.ts, ReportActionsUtils.ts, nor useRecentlyAddedData.ts).
When you Pay someone in a 1:1 DM and Mark as paid, the transaction has two IOU actions that both satisfy isMoneyRequestAction (type IOU) and both carry the same IOUTransactionID:
the original CREATE money-request action (its childReportID is the expense/transaction thread), and
the PAY action (the "marked as paid" system message — its childReportID is the pay message thread).
.find() returns whichever appears first in the snapshot's report-actions array; when that is the PAY action, expense.reportAction becomes the pay action.
So the app navigates to the "marked as paid" message thread instead of the expense — exactly the reported symptom.
Verification
Affected files: useRecentlyAddedData.ts (chooses the wrong IOU action) and TransactionThreadNavigationUtils.ts (getReportIDToOpenForExpense, which trusts that action's childReportID).
Reproduces on staging only, consistent with the feature not yet being in production.
Suggested fix direction
Resolve the expense's IOU action to the money-request (create/track) action rather than any IOU action — e.g. filter out pay-type IOU actions in getIOUActionForTransactionID for this call site, or select the action whose originalMessage.type is a request/track type, so getReportIDToOpenForExpense lands on the expense's transaction thread instead of the pay message thread.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.6-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Aug 26, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e6b5a427206b3605bf00a62154a6406d3ef035a6461f2fab7967020168bc91c8
melvin-bot commentedon Aug 26, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #98611
melvin-bot commentedon Aug 26, 2026
@JS00001 @ShridharGoel you have been assigned to this deploy blocker because you reviewed the offending PR: #98611
github-actions commentedon Aug 26, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Aug 26, 2026
@thelullabyy you have been assigned to this deploy blocker because you authored the offending PR: #98611
melvin-bot commentedon Aug 26, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Aug 26, 2026
🔍 Investigation Summary
Classification: Frontend bug (fix required in
Expensify/App)Causing PR: #93451 - "[Home Page] Add Recently added slot to Home" by @adamgrzybowski (Medium confidence for the origin PR / High confidence on the root-cause code)
Not the cause: #98611 - the auto-flagged PR (see below)
Related Issues: Feature origin #90366 (the header standardization tracked by #98611)
Recommendation: ROLL FORWARD (targeted fix)
Reverting the auto-flagged PR #98611 will not fix this bug — it does not touch the code that chooses which report opens. The fix is a small, targeted change to how the tapped expense's IOU action is resolved in the Recently added slot, so we should roll forward rather than revert.
Assigned: (kept existing melvin auto-assignees) + added @adamgrzybowski (author), @ZhenjaHorbach and @grgia (approving reviewers) of the origin PR #93451, since the fix belongs in that feature code.
Labels: No change.
DeployBlockerCashis correctly retained (Frontend bug, App deploy blocked). NoDeployBlocker(Web) label was present, so none removed.📋 Detailed Analysis
Why #98611 is NOT the cause
PR #98611 ("Standardize Expense Report and Expense header…") is the PR Melvin auto-assigned because its author merged it and its BrowserStack field literally links to it. Its only change to the Recently added flow is a signature update in
RecentlyAddedSection/index.tsx:This inserts an
undefinedfor the newsnapshotHashparameter ofsetActiveTransactionIDs. It affects only the idempotency/dedup of the carousel's sibling transaction-ID list — it does not change whichreportIDis navigated to for the tapped expense. The navigation target is computed bygetReportIDToOpenForExpense(...), which #98611 does not modify (its file list contains neitherTransactionThreadNavigationUtils.ts,ReportActionsUtils.ts, noruseRecentlyAddedData.ts).Root Cause
The Recently added slot picks the IOU action for each expense here:
src/pages/home/RecentlyAddedSection/useRecentlyAddedData.ts#L275getIOUActionForTransactionIDreturns the first report action matching the transaction:src/libs/ReportActionsUtils.ts#L2697-L2702When you Pay someone in a 1:1 DM and Mark as paid, the transaction has two IOU actions that both satisfy
isMoneyRequestAction(typeIOU) and both carry the sameIOUTransactionID:childReportIDis the expense/transaction thread), andchildReportIDis the pay message thread)..find()returns whichever appears first in the snapshot's report-actions array; when that is the PAY action,expense.reportActionbecomes the pay action.Navigation then uses that action's
childReportIDdirectly:src/libs/TransactionThreadNavigationUtils.ts#L59-L60So the app navigates to the "marked as paid" message thread instead of the expense — exactly the reported symptom.
Verification
useRecentlyAddedData.ts(chooses the wrong IOU action) andTransactionThreadNavigationUtils.ts(getReportIDToOpenForExpense, which trusts that action'schildReportID).Suggested fix direction
Resolve the expense's IOU action to the money-request (create/track) action rather than any IOU action — e.g. filter out
pay-type IOU actions ingetIOUActionForTransactionIDfor this call site, or select the action whoseoriginalMessage.typeis a request/track type, sogetReportIDToOpenForExpenselands on the expense's transaction thread instead of the pay message thread.23 remaining items
melvin-bot commentedon Oct 9, 2026
@ZhenjaHorbach
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.6-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
JS00001 commentedon Oct 12, 2026
Waiting on payment here
melvin-bot commentedon Oct 12, 2026
@ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Oct 14, 2026
@ZhenjaHorbach Huh... This is 4 days overdue. Who can take care of this?
grgia commentedon Oct 15, 2026
Regression period, payment 2026-10-16, not overdue
melvin-bot commentedon Oct 15, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 15, 2026
Payment Summary
Resolving PRs:
Fix: open expense report (not pay message thread) for paid expenses in Recently added #99668
Contributor: @adamgrzybowski does not require payment (Contractor)
Reviewer: @ZhenjaHorbach owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Oct 18, 2026
@ZhenjaHorbach I'm assuming this isn't due payment cuz it's a regression and you worked on the offending PR
@ZhenjaHorbach plz complete the Contributor+ checklist and tag me in a post once you have. Thx
ZhenjaHorbach commentedon Oct 19, 2026
ZhenjaHorbach commentedon Oct 19, 2026
Oh
Right
Let's add tests and close this!