Skip to content

Home - Expense when deleted offline does not have offline feedback #94240

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.17-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #93451
Email or phone of affected tester (no customers): joisjdnosjdoijso@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Go to Home.
  5. Click on the expense in Recently added section.
  6. Go offline.
  7. Click More > Delete > Delete.
  8. Click on the deleted expense again.

Expected Result:

Expense when deleted offline will show strikethrough and cannot be clicked.

Actual Result:

Expense when deleted offline does not show strikethrough and can be clicked, which opens error page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7188073_1782170670328.5.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7188073

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 23, 2026
  2. applause-bot commented on Jun 23, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/d9f126acf13370958d83ae5ebcb528eb14d60eff3c5f24bd0abb3391ea98ccce

  3. melvin-bot commented on Jun 23, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #93451

  4. melvin-bot commented on Jun 23, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 23, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 23, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On Home, the new Recently added slot (added in #93451) renders an expense that is deleted while offline without any offline feedback: no strikethrough, still tappable, and tapping it opens an error page. Deleted-offline expenses everywhere else in the app show a strikethrough and are non‑interactive until the queued delete syncs.

    What is the root cause of that problem?

    The Recently added row is a plain interactive row with no offline-feedback handling — unlike every other transaction row in the app.

    • RecentlyAddedRow.tsx:124-136 wraps the content in a bare PressableWithFeedback. There is no OfflineWithFeedback wrapper and no pendingAction, so a transaction with pendingAction = DELETE renders at full opacity with no strikethrough, and onPress stays active.
    • useRecentlyAddedData.ts:140-150 filters only by report ownership — it never inspects pendingAction, so the pending-delete transaction is still surfaced in the list.

    Because the row stays pressable, tapping it runs openExpense → Navigation.navigate(SEARCH_REPORT…) (index.tsx:67-89) into a report/thread whose deletion is queued → the error page.

    How other transaction rows handle this (the missing pattern)

    MoneyRequestReportTransactionItem.tsx is the canonical pattern: it wraps the row in OfflineWithFeedback with the transaction's pending action and disables the press while pending delete:

    • MoneyRequestReportTransactionItem.tsx:134-135 — isPendingDelete = isTransactionPendingDelete(transaction) and pendingAction = getTransactionPendingAction(transaction)
    • :155-156 — wraps in <OfflineWithFeedback pendingAction={pendingAction}> (applies the strikethrough)
    • :214 — isDisabled={isPendingDelete} on the pressable (blocks the tap)

    Helpers already exist: getTransactionPendingAction and isTransactionPendingDelete in TransactionUtils.

    What changes do you think we should make in order to solve the problem?

    Apply the same offline-feedback pattern to the Recently added row:

    1. In RecentlyAddedRow.tsx, wrap the PressableWithFeedback in <OfflineWithFeedback pendingAction={getTransactionPendingAction(expense.transaction)}> so a pending-delete expense gets the standard strikethrough, and pass isDisabled={isTransactionPendingDelete(expense.transaction)} to the pressable so it can't be tapped.
    2. This requires carrying pendingAction through to the row. The mapped RecentlyAddedExpense already keeps the full transaction object (useRecentlyAddedData.ts:167-176), so the helpers can read expense.transaction.pendingAction directly — no data-shape change needed.

    This matches the expected behavior ("shows strikethrough and cannot be clicked") and reuses existing helpers/components, so it stays consistent with the rest of the app.

    Related issues

    Same PR (#93451), same Recently added slot — likely worth fixing/tracking together:


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement this to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. ZhenjaHorbach commented on Jun 23, 2026

    @ZhenjaHorbach
    Contributor

    We already have an issue for the offline state for Recently added
    Let's close this
    CC: @grgia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions