Skip to content

[Due for payment 2026-10-22] Payment issue for E/App PR#103940 #104120

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #103940
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/691361.
Contributor+ member who reviewed the PR - @ikevin127.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Oct 15, 2026

    @melvin-bot
    Author

    @ikevin127 The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. ikevin127 commented on Oct 16, 2026

    @ikevin127
    Contributor

    BugZero Checklist

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A - Result of the original design

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Prerequisite: Enable the supportTicket beta for the test account.

    Connected network

    1. Go to Settings > Help and select Talk to a human.
    2. While creation is pending, verify the header displays Support ticket instead of a title skeleton or the assigned support rep's name. Any pending LHN entry should also use the support-ticket title.
    3. Let the request finish and verify the full dated support-ticket title and conversation load without a not-found page.
    4. Reopen a resolved ticket and verify it opens the ticket chosen by the server.

    Offline steps

    1. Open Settings > Help, turn Wi-Fi / internet off, and select Talk to a human.
    2. While the request is pending, verify the header displays Support ticket. The messages can remain loading until the request completes.
    3. Wait for creation to fail (about 5 seconds). Verify the optimistic LHN entry is removed and the app redirects to Concierge without an error message. Reconnect and verify no support ticket was created.
    4. Repeat using the app's Force offline toggle. This can let the backend create a ticket while the client discards the response. Verify the same redirect to Concierge after the failure. Disable Force offline and synchronize: the server-created ticket should appear in the LHN, while the current chat stays on Concierge. Open the ticket from the LHN and verify it loads.

    Reload during creation

    1. With Wi-Fi / internet off, select Talk to a human, then reload within about 2 seconds while the Support ticket header is showing.
    2. Reconnect and verify the report resolves to content if the server created it, or the normal not-found screen if it did not. It must not remain on the loading skeleton, and the URL must lose isPendingCreation=true.
    3. Repeat with Force offline, then disable the toggle after reloading. If the server created the ticket, verify its conversation loads on the restored URL.

    Do we agree 👍 or 👎.

  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 16, 2026
  4. melvin-bot commented on Oct 21, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  5. melvin-bot commented on Oct 21, 2026

    @melvin-bot
    Author

    Payment Summary

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  6. mallenexpensify commented on Oct 24, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @ikevin127 due $175 via NewDot

  7. quinthar commented on Oct 27, 2026

    @quinthar
    Contributor

    Approved $175 to @ikevin127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions