Repository navigation
[Payment due @ikevin127] [CP stag] Show the support ticket title while creation is pending - #103940
Conversation
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0ce55196f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
|
(Jasper's Agent) The unrelated Jest failure is already tracked in App issue 103714 and fixed by App PR 103747. It passes in isolation on the refreshed branch, so no change is needed here. Failed run: test job 7. |
|
@ikevin127 yep! sorry it should be ready for review now. Please remind me to create an App issue for review payment once this is done |
Reviewer Checklist
Screenshots/Videos
|
| const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportOnyx?.chatReportID}`); | ||
| const [reportMetadata = defaultReportMetadata] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportIDFromRoute}`); | ||
| const [reportLoadingState = defaultReportLoadingState] = useOnyx(`${ONYXKEYS.COLLECTION.RAM_ONLY_REPORT_LOADING_STATE}${reportIDFromRoute}`); | ||
| const isPendingReportCreation = !!reportMetadata.isOptimisticReport || !!reportLoadingState.isCreatingSupportTicket; |
There was a problem hiding this comment.
🟢 src/pages/inbox/ReportFetchHandler.tsx:133
Now that the guard lives in RAM_ONLY_REPORT_LOADING_STATE, nothing sets reportMetadata.isOptimisticReport for a pending-creation route. Support tickets are the only caller of isPendingCreation, and they don't write REPORT_METADATA anymore.
Keeping it in isPendingReportCreation brings back the persisted guard we just moved away from. If any flow ever pairs isPendingCreation with a persisted isOptimisticReport: true, the reload bug comes back. Could we drop it ?
const isPendingReportCreation = !!reportLoadingState.isCreatingSupportTicket;There was a problem hiding this comment.
ah yeah makes sense, fixing this
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM - Thanks for addressing the comments!
🟢 Drop reportMetadata.isOptimisticReport from isPendingReportCreation. Approving, but it's a one-line cleanup that closes off the reload bug for good.
|
🎯 @ikevin127, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here. |
…-title [Payment due @ikevin127] [CP stag] Show the support ticket title while creation is pending (cherry picked from commit 1fde4bc) (cherry-picked to staging by jasperhuangg)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.5.9-2 🚀
|
|
No help site update is needed. This PR fixes a loading-state bug in support ticket creation, which is still behind the |
Can you help with steps 2 to 4? |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.9-4 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #104120 |
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.5.10-0 🚀
|
|
No help site update is needed. This PR fixes a loading-state bug in support ticket creation, which is still behind the |
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.5.12-0 🚀
|
|
No help site update is needed. This PR fixes the title shown while a support ticket is being created, and the Talk to a human entry point is still behind the |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/691361
PROPOSAL:
Tests
Prerequisite: Enable the
supportTicketbeta for the test account.Connected network
Offline steps
Reload during creation
isPendingCreation=true.QA Steps
Repeat the connected-network, offline, and reload steps above on staging with the
supportTicketbeta enabled.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected in all cases)npm run compress-svg)Avatar, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Not included. This fixes a brief pending-state race and does not change the final UI.
AI Tests