Repository navigation
[No QA][Scan] Stop the untouched-scan test leaking a late submit into later tests - #103747
Merged
Merged
Conversation
…ed scan The untouched-scan test pressed Create, which started a live location read, and ended without waiting for it. getCurrentPosition is automocked and never answers, so the 3s SUBMIT_WAIT_TIMEOUT fallback added in #102191 fired during whichever test was running three seconds later and recorded a stray requestMoney call with no report. The "Report selection guard" tests read mock.calls.at(0), so when the fallback landed between their clearAllMocks and their assertion they saw report undefined (#103613, #103714, #103569). Answer the position read in that test and wait for its write so nothing outlives the test.
This was referenced Oct 12, 2026
…ion-page-flaky-test
40 tasks
…ion-page-flaky-test
36 of 38 tasks
…ion-page-flaky-test
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
situchan
approved these changes
Oct 15, 2026
amyevans
approved these changes
Oct 15, 2026
68 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.5.13-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.13-6 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The scan confirmation test that submits an untouched scan now answers the location read and waits for its submit before ending.
Since PR 102191, pressing Create on a scan arms a 3 second fallback that submits without a location. In this test the location read is automocked and never answers, and the test ends right after the press, so the fallback fires three seconds later inside whichever test is running. When that lands in a "Report selection guard" test between
clearAllMocksand itsrequestMoneyassertion, the assertion reads the stray call (no report) and fails withExpected: "101" Received: undefinedor"202". Resolving the read in the originating test makes the page submit immediately, and the later fallback hits the settled guard ingetCurrentPositionWithinCapand does nothing.Fixed Issues
$ #103714
$ #103613
$ #103569
PROPOSAL:
Tests
npx jest tests/ui/components/IOURequestStepConfirmationPageTest.tsxthree times.Offline tests
N/A, test-only change.
QA Steps
N/A, test-only change.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A, test-only change.
Android: mWeb Chrome
N/A, test-only change.
iOS: Native
N/A, test-only change.
iOS: mWeb Safari
N/A, test-only change.
MacOS: Chrome / Safari
N/A, test-only change.