Skip to content

[No QA][Scan] Stop the untouched-scan test leaking a late submit into later tests - #103747

Merged
amyevans merged 4 commits into
mainfrom
georgia-fix-confirmation-page-flaky-test
Oct 15, 2026
Merged

amyevans merged 4 commits into
mainfrom
georgia-fix-confirmation-page-flaky-test

Conversation

@grgia

@grgia grgia commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The scan confirmation test that submits an untouched scan now answers the location read and waits for its submit before ending.

Since PR 102191, pressing Create on a scan arms a 3 second fallback that submits without a location. In this test the location read is automocked and never answers, and the test ends right after the press, so the fallback fires three seconds later inside whichever test is running. When that lands in a "Report selection guard" test between clearAllMocks and its requestMoney assertion, the assertion reads the stray call (no report) and fails with Expected: "101" Received: undefined or "202". Resolving the read in the originating test makes the page submit immediately, and the later fallback hits the settled guard in getCurrentPositionWithinCap and does nothing.

  • Whole file passes 5/5 locally
  • Forcing the window onto the 101 test (1 s delay) now passes too
  • No production code changed

Fixed Issues

$ #103714
$ #103613
$ #103569
PROPOSAL:

Tests

  1. Run npx jest tests/ui/components/IOURequestStepConfirmationPageTest.tsx three times.
  2. Verify every run passes, including the "Report selection guard tests" block.
  • Verify that no errors appear in the JS console

Offline tests

N/A, test-only change.

QA Steps

N/A, test-only change.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A, test-only change.

Android: mWeb Chrome

N/A, test-only change.

iOS: Native

N/A, test-only change.

iOS: mWeb Safari

N/A, test-only change.

MacOS: Chrome / Safari

N/A, test-only change.

…ed scan

The untouched-scan test pressed Create, which started a live location read, and ended without waiting for it. getCurrentPosition is automocked and never answers, so the 3s SUBMIT_WAIT_TIMEOUT fallback added in #102191 fired during whichever test was running three seconds later and recorded a stray requestMoney call with no report. The "Report selection guard" tests read mock.calls.at(0), so when the fallback landed between their clearAllMocks and their assertion they saw report undefined (#103613, #103714, #103569).

Answer the position read in that test and wait for its write so nothing outlives the test.
@grgia
grgia marked this pull request as ready for review October 15, 2026 16:41
@grgia
grgia requested a review from a team as a code owner October 15, 2026 16:41
@melvin-bot
melvin-bot Bot requested review from situchan and removed request for a team October 15, 2026 16:41
@melvin-bot

melvin-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T16:47:20.230099Z 682381f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested a review from amyevans October 15, 2026 16:44
@melvin-bot

melvin-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@amyevans
amyevans merged commit 703f1f0 into main Oct 15, 2026
41 of 44 checks passed
@amyevans
amyevans deleted the georgia-fix-confirmation-page-flaky-test branch October 15, 2026 18:24
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/amyevans in version: 9.5.13-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.5.13-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants