You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-03] [CFI] Add the Withdrawal ID custom column to expense report searches #104139
Add the Withdrawal ID column to the custom columns on Spend > Reports (type:expense-report searches).
Background
The Withdrawal ID column already exists as a custom column on expense searches (added in #88384). Bank reconciliation also uses it. Expense report searches don't offer it as a custom column.
Problem
Customers want to see the withdrawal ID tied to each report, when one applies. Today they can filter reports by withdrawal ID. They can't show it as a column, so they have to open each report to find it.
Solution
Add Withdrawal ID as a selectable custom column on expense report searches. It should match the expense-level column.
changed the title [-]Add the `Withdrawal ID` custom column to expense report searches[/-][+][CFI] Add the `Withdrawal ID` custom column to expense report searches[/+]on Oct 15, 2026
Please re-state the problem that we are trying to solve in this issue.
Expense report searches (type:expense-report) don't offer Withdrawal ID as a custom column, though expense searches do.
What is the root cause of that problem?
Two gaps:
App:WITHDRAWAL_ID isn't in the report column list, TYPE_CUSTOM_COLUMNS.EXPENSE_REPORT. The report row and header don't render it either.
Data: The expense column reads transaction.withdrawalID (TransactionItemRowWide.tsx:683-690). The Report type has no withdrawal ID field, so Search returns nothing for the App to show on report rows.
What changes do you think we should make in order to solve the problem?
Backend first (internal): Search should return a report-level withdrawalID on each report in type:expense-report results. It should also support sortBy:withdrawalID. An internal engineer needs to make this change.
App: Follow the pattern used for ORDER_DEAL_NUMBERS (International Reimbursement IDs):
Add WITHDRAWAL_ID to TYPE_CUSTOM_COLUMNS.EXPENSE_REPORT, but not to the default columns. The column key, query value, style and common.withdrawalID translation already exist.
Add withdrawalID?: string to Report, whitelistedReportKeys.ts, the report selector, and DebugUtils.
Add tests in tests/unit/Search/SearchUIUtilsTest.ts, modeled on the Amount debited tests. Cover sorting, and cover showing or hiding the column in getColumnsToShow.
Decided (confirmed by trjExpensify): if a report has several withdrawals (for example, a reimbursement and an Expensify Card settlement), the backend returns them as one comma-separated string in withdrawalID, like International Reimbursement IDs. The App shows that string as is.
What alternative solutions did you explore? (Optional)
Derive the ID from each row's transactions in the App. I rejected this. A row may not hold every transaction on the report, a report can have several IDs, and sorting across pages needs the backend.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/104139) to create a draft PR. Do this after the backend returns withdrawalID on reports. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Decide before the backend work starts: if a report has several withdrawals (for example, a reimbursement and an Expensify Card settlement), show them comma-joined, like International Reimbursement IDs.
Backend first (internal): Search should return a report-level withdrawalID on each report in type:expense-report results. It should also support sortBy:withdrawalID. An internal engineer needs to make this change.
The backend returns one comma-separated string in the report's withdrawalID, and the App shows it as is. International Reimbursement IDs work the same way: the App renders orderDealNumbers directly (ExpenseReportListItemRowWide.tsx:239). No extra App formatting is needed.
Activity
[-]Add the `Withdrawal ID` custom column to expense report searches[/-][+][CFI] Add the `Withdrawal ID` custom column to expense report searches[/+]trjExpensify commentedon Oct 15, 2026
@MelvinBot propose a solution to this.
MelvinBot commentedon Oct 15, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense report searches (
type:expense-report) don't offerWithdrawal IDas a custom column, though expense searches do.What is the root cause of that problem?
Two gaps:
WITHDRAWAL_IDisn't in the report column list,TYPE_CUSTOM_COLUMNS.EXPENSE_REPORT. The report row and header don't render it either.transaction.withdrawalID(TransactionItemRowWide.tsx:683-690). TheReporttype has no withdrawal ID field, so Search returns nothing for the App to show on report rows.What changes do you think we should make in order to solve the problem?
Backend first (internal): Search should return a report-level
withdrawalIDon each report intype:expense-reportresults. It should also supportsortBy:withdrawalID. An internal engineer needs to make this change.App: Follow the pattern used for
ORDER_DEAL_NUMBERS(International Reimbursement IDs):WITHDRAWAL_IDtoTYPE_CUSTOM_COLUMNS.EXPENSE_REPORT, but not to the default columns. The column key, query value, style andcommon.withdrawalIDtranslation already exist.withdrawalID?: stringtoReport,whitelistedReportKeys.ts, the report selector, andDebugUtils.TextCellinExpenseReportListItemRowWide.tsx. Add a header entry ingetExpenseReportHeaders.WITHDRAWAL_IDcase togetReportCustomColumnValue.reportCustomColumns, so it hides when no report on the page has a value. Add it to the report sort branch atSearchUIUtils.ts:4260.getExpenseReportColumnContentToMeasurefor column width.tests/unit/Search/SearchUIUtilsTest.ts, modeled on the Amount debited tests. Cover sorting, and cover showing or hiding the column ingetColumnsToShow.Decided (confirmed by
trjExpensify): if a report has several withdrawals (for example, a reimbursement and an Expensify Card settlement), the backend returns them as one comma-separated string inwithdrawalID, like International Reimbursement IDs. The App shows that string as is.What alternative solutions did you explore? (Optional)
Derive the ID from each row's transactions in the App. I rejected this. A row may not hold every transaction on the report, a report can have several IDs, and sorting across pages needs the backend.
References
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/104139)to create a draft PR. Do this after the backend returnswithdrawalIDon reports.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
trjExpensify commentedon Oct 15, 2026
@MelvinBot makes sense to comma-separate them. 👍
trjExpensify commentedon Oct 15, 2026
@c3024 fancy this one after
paid:? CC: @JS00001MelvinBot commentedon Oct 15, 2026
👍 I updated the proposal to record this decision.
The backend returns one comma-separated string in the report's
withdrawalID, and the App shows it as is. International Reimbursement IDs work the same way: the App rendersorderDealNumbersdirectly (ExpenseReportListItemRowWide.tsx:239). No extra App formatting is needed.JS00001 commentedon Oct 16, 2026
Cool, lets do it
JS00001 commentedon Oct 19, 2026
Looks like a PR is in progress ^
17 remaining items
melvin-bot commentedon Nov 2, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Nov 2, 2026
Payment Summary
Resolving PRs:
Add the Withdrawal ID custom column to expense report searches #104671
Contributor: @c3024 does not require payment (Contractor)
Reviewer: @truph01 owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
melvin-bot commentedon Nov 5, 2026
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mallenexpensify commentedon Nov 6, 2026
Payment Summary
Contributor+: @truph01 due $175 via NewDot