Repository navigation
Add the Withdrawal ID custom column to expense report searches - #104671
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b4023f88c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
Bug: The Withdrawal ID column is empty on the report details screenSteps to Reproduce
Actual ResultThe Withdrawal ID column is empty, even though the report contains Withdrawal ID data. Expected ResultThe Withdrawal ID should be displayed in the corresponding column on the report details screen. Screen.Recording.2026-10-23.at.12.48.18.mov |
|
does this happen on staging too? This PR does not touch this logic. It looks like OpenReport is not returning this value. |
Yes, it happens on staging as well. Since it is out of scope of this issue, we can skip it |
|
Got it. I created a followup issue. |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-10-23.at.13.52.52.mov |
….com:c3024/App into chaitanya/104139-report-withdrawal-id-column # Conflicts: # tests/unit/Search/SearchUIUtilsTest.ts
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.21-0 🚀
|
|
No help site update needed. This PR adds Withdrawal ID as another optional column on the Reports view, but no existing article sentence becomes wrong. Why
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.23-0 🚀
|
|
No help site update needed. This PR only adds Withdrawal ID as an optional column on the Reports view, and no existing article sentence becomes wrong. Why
|
|
@c3024 @trjExpensify step 4: We don't have expensify card settlement withdrawal , can we just test with only reimbursement? |
|
I think that is fine. I tested that part of report with more than one settled withdrawal on dev. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.23-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Adds a Withdrawal ID custom column to Spend > Reports. Auth PR 25635 returns
withdrawalIDson each report, the report's settled withdrawal IDs comma separated in ascending order.withdrawalIDsis added to theReporttype, whitelisted report keys, report selector and Debug validators.Fixed Issues
$ #104139
PROPOSAL: #104139 (comment)
Tests
status:drafts) and confirm the Withdrawal ID column is still shown, with empty cells.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari