Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.5.21-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #104671
Email or phone of affected tester (no customers): ibellicotest+3215@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Search
Action Performed:
- Open the Expensify app.
- Navigate to "Spend" > "Expenses"
- Tap on "FIlters" icon > "Withdrawal ID"
- Enter any ID > "Confirm" > "Apply Filters"
- Tap on exposed filter.
- Tap on text input to open keyboard.
- Note that "Apply" button is overlapped by keyboard and user can´t scroll down to it.
Expected Result:
"Apply" button should be completelly visible while editing withdrawal ID via exposed filter.
Actual Result:
"Apply" button is overlapped by keyboard while editing withdrawal ID via exposed filter and user is unable to scroll down to it.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7297588_1793067821661.Withdrawal.mp4
Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7297588
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022115102803454012561
- Upwork Job ID: 2115102803454012561
- Last Price Increase: 2026-11-10
Issue Owner
Current Issue Owner: @puneetlathMetadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsNo status
Activity
applause-bot commentedon Oct 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/5641d273a629159887b0e9f777cf54c0e74e54c456366f0b042cdebb6b14df5a
MelvinBot commentedon Oct 27, 2026
Proposal
What is the root cause of that problem?
On small screens, every text filter chip (Withdrawal ID, Description, Title, Report ID, and others) opens
TextFilterPopupinside a bottom-dockedFilterPopupButtonsheet. Two problems stack up:avoidKeyboard. That flag wraps the sheet in a paddingKeyboardAvoidingView(ReanimatedModal/index.tsx:244). On this Android device it adds too little padding, or none, so the keyboard covers "Apply". The selection-list sheets stopped usingavoidKeyboardfor inputs for this reason. They pad the content withuseReanimatedKeyboardAnimationinstead (useSelectionListPopoverLayout.ts:90-105).BasePopupis a plainViewwith the input and thenActionButtons.FilterPopupButtonalso turns off the modal's onlyScrollViewwrapper (line 160). Once "Apply" is covered, you can't scroll to it.What changes do you think we should make in order to solve the problem?
In
FilterPopupButton, on small screens, follow theuseSelectionListPopoverLayoutpattern:avoidKeyboardtoPopoverWithMeasuredContent.Animated.View. Set itspaddingBottomtomax(safeAreaBottom, -keyboardHeight)fromuseReanimatedKeyboardAnimation. The sheet then rises with the keyboard and keeps "Apply" visible.This fixes all text filter chips at once, since they share this wrapper.
What alternative solutions did you explore? (Optional)
BasePopup's children andActionButtonsin aScrollViewwithkeyboardShouldPersistTaps="handled". This makes "Apply" reachable but doesn't keep it in view. It is a good safety net to pair with the main fix.automaticOffseton the sharedKeyboardAvoidingViewinReanimatedModal. This changes every modal that usesavoidKeyboard, so it needs much broader QA.Investigation notes
avoidKeyboardreaches Android intact:PopoverWithMeasuredContent→Popover/index.native(bottom-docked) →Modal/index.android→BaseModal→ReanimatedModal. TheavoidKeyboard={false}inModal/index.tsxapplies only on web.FilterPopupButtondon't touch keyboard handling.MerchantFilterPopupuses the same layout, so the Merchant chip is likely affected too.Possibly related: Android & iOS - Spend - Unable to scroll down Describe your search page in landscape, "Describe your search" box hidden behind keyboard when put cursor on it in landscape
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/105145)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
j3ffffff commentedon Oct 27, 2026
melvin-bot commentedon Oct 27, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (
External)[-]Android - Spend - "Apply" button is overlapped by keyboard in exposed filter.[/-][+][$175] Android - Spend - "Apply" button is overlapped by keyboard in exposed filter.[/+]melvin-bot commentedon Oct 27, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022115102803454012561
camesenin commentedon Oct 27, 2026
melvin-bot commentedon Oct 27, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
apoorv-xs commentedon Oct 27, 2026
huhuli083-creator commentedon Oct 27, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On Android native, when opening an exposed filter popup in Spend (such as the Merchant, Description, Category, or Title filter popup) and focusing the text input, the soft keyboard overlaps the bottom "Apply" button instead of pushing the popup cleanly above the keyboard.
What is the root cause of that problem?
The exposed filter popups (
TextFilterPopup, etc.) are rendered inside<PopoverWithMeasuredContent>viasrc/components/Search/FilterDropdowns/FilterPopupButton.tsx(lines 84–99):Across the entire codebase,
<KeyboardProvider>(src/components/KeyboardProvider/index.tsxlines 7–9),<BaseModal>(src/components/Modal/BaseModal.tsxlines 117–118), and<ReanimatedModal>(src/components/Modal/ReanimatedModal/index.tsxlines 55–56) all default to:However,
src/components/PopoverWithMeasuredContent/PopoverWithMeasuredContentBase.tsx(line 58) is the only modal wrapper in the codebase that still defaultsstatusBarTranslucenttofalse:and passes
statusBarTranslucent={statusBarTranslucent}down to<Popover>(line 237) -><Modal>(BaseModal.tsxline 322) -><ReanimatedModal>-> React Native's<Modal>.Why
statusBarTranslucent = false(combined withnavigationBarTranslucent = true) causes the exact keyboard overlap on Android:ReactModalHostView.kt,navigationBarTranslucent = trueenables edge-to-edge on the modalDialogwindow, whilestatusBarTranslucent = falsesetsfitsSystemWindows = trueon the modal'scontentView(FrameLayout).fitsSystemWindows = trueis set oncontentView, Android insets the modal's root view group from the top bystatusBarHeight(e.g.40dp/80pxon Pixel 7 Pro) and from the bottom bynavigationBarHeight.ReanimatedModal(src/components/Modal/ReanimatedModal/index.tsxlines 254–260), whenavoidKeyboardistrue, the modal content is wrapped inreact-native-keyboard-controller's<KeyboardAvoidingView behavior="padding">.react-native-keyboard-controller'sKeyboardAvoidingView(src/components/KeyboardAvoidingView/index.tsxlines 98–107),relativeKeyboardHeight()computes:screenHeightcomes from the Activity's full edge-to-edge window (wherestatusBarTranslucent = true), whileframe.valuecomes fromonLayoutinside the modal'sdialogRootViewGroup(frame.value.y = 0,frame.value.height = screenHeight - statusBarHeight - navigationBarHeight).frame.value.yis0relative todialogRootViewGroupinstead of reflecting thestatusBarHeighttop offset applied byfitsSystemWindows = true,frame.value.y + frame.value.heightunder-reports the view's bottom screen coordinate bystatusBarHeight.KeyboardAvoidingViewappliespaddingBottomthat is short bystatusBarHeight, leaving the bottom-docked"Apply"button overlapped by the top of the Android keyboard!What changes do you think we should make in order to solve the problem?
In
src/components/PopoverWithMeasuredContent/PopoverWithMeasuredContentBase.tsx(line 58), change the default value ofstatusBarTranslucentfromfalsetotruesoPopoverWithMeasuredContentis consistent withBaseModal,ReanimatedModal, andKeyboardProvider:With
statusBarTranslucent = true, the modal's coordinate space on Android matches the main window andKeyboardProvider, soKeyboardAvoidingViewcalculates the exactrelativeKeyboardHeightand pushes the"Apply"button completely above the keyboard.What alternative solutions did you explore? (Optional)
statusBarTranslucentonly inFilterPopupButton.tsxwas considered, but every other modal in the app already defaultsstatusBarTranslucent = trueinBaseModal.tsxandReanimatedModal/index.tsx. Updating the default inPopoverWithMeasuredContentBase.tsxfixes allPopoverWithMeasuredContentpopups with inputs on Android consistently.101 remaining items
brunovjk commentedon Nov 11, 2026
Let me check in a moment
emkhalid commentedon Nov 11, 2026
@brunovjk, thanks for reviewing this and picking a scoped approach that reuses the app's existing keyboard pattern. My proposal follows that exact direction without touching shared modal code, while also catching the safe-area drop—and while testing the selected proposal, I found a regression to flag.
Regression: Landscape rotation clips the heading and covers Apply
Expected: The heading, input, and Apply button stay visible and usable.
Actual: The heading clips at the top and Apply gets covered by the keyboard.
VID_20261112_143051.mp4
Why my proposal is stronger (and already used in the app)
Mine identified both parts of the root cause (including how safe-area spacing drops when the keyboard opens), stays scoped to the filter popup, and can handle landscape cleanly in the PR too. This same bottom-sheet pattern is already proven in production across the anchored selection-list popovers (used by the Category and Tag picker modals):
App/src/hooks/useSelectionListPopoverLayout.ts
Lines 95 to 113 in 77f3036
Could you please take another look and reconsider moving forward with my proposal? Happy to open the PR right away!
github-actions commentedon Nov 11, 2026
neerajbachani commentedon Nov 11, 2026
@brunovjk @puneetlath, I retested the selected padding fix against the two reconsiderations, on a Pixel 7 (API 34, 1080×2400), and I updated my proposal from those numbers. I think we should switch the selection.
Both objections to the selected approach are real. Neither one is a reason to keep it, and the landscape guard does not finish the job.
What the bug actually is. The sheet already lifts. On that phone the keyboard top is at y=1517 and Apply's bottom is at y=1611, so the button is covered by 94px. The missing lift is 136px, the status bar.
The other 63px under the dialog is the navigation bar, which the keyboard height already includes.
KeyboardAvoidingViewmeasures its parent, not the window, and this dialog's parent is short by that status bar. That is the same offset the distance screen already passes, capped so we do not also add the navigation bar.x-dev90's split-screen point. I implemented the selected padding (
avoidKeyboardoff, pad by the full keyboard height). In a lower split pane that is exactly the over-lift you described: the pad is the whole keyboard, not the missing status bar, so the heading is pushed out and Apply sits on a large empty gap. KeepingavoidKeyboardand adding onlymin(measured gap, status bar height)cannot do that. The correction is at most one status bar, and it is zero when the dialog already fills the window. I would still like that lower pane checked on the PR with the keyboard open. It is not a reason to pad by the keyboard height.emkhalid's landscape point. Also real, and it is about rotation, not the chip tap. The chip in landscape already leaves this sheet and opens the advanced filters page. Rotating while the sheet is open, with the selected padding and no landscape guard, clips the heading to 15px and still covers Apply by 49px. Adding
!isInLandscapeModesaves the heading, but Apply is still covered by 32px, and the guard flipsavoidKeyboardon rotate. That swaps the modal wrapper.useSelectionListPopoverLayoutalready refuses that, because the sheet remounts and the input loses focus. So the guard does not make the padding approach safe, and it is not the pattern that hook is asking us to copy.What I measured for the capped offset, on the same phone:
avoidKeyboardkept, landscape skippedThe portrait case is the bug in the issue. This is the only approach that clears Apply by the distance that is actually missing, leaves the heading up, and does not turn the keyboard avoidance off. Landscape rotation is left as it is today instead of being made worse. The chip tap in landscape is unchanged.
Happy to take the PR. The lower split pane with the keyboard open should be on the test plan.
github-actions commentedon Nov 11, 2026
mukhrr commentedon Nov 12, 2026
oh so much AI things above 🤯
I dont think this is real. at least I am not able to reproduce this.
And what
@emkhalid@neerajbachanipointed seems valid. But their solution sounds too overmessed to me. We can just use a prop to fix it as we do forAnchoredSelectionListPopover.no
!isInLandscapeModegueard, no new prop throughModal,BaseModalandReanimatedModal, etc.let me update proposal only with this line
@brunovjk wdyt? cc @puneetlath
github-actions commentedon Nov 12, 2026
emkhalid commentedon Nov 12, 2026
@brunovjk, thanks for reviewing this and picking a scoped approach that reuses the app's existing keyboard pattern. My proposal follows that exact direction without touching shared modal code, while also catching the safe-area drop—and while testing the selected proposal, I found a regression to flag.
Regression: Landscape rotation clips the heading and covers Apply
Expected: The heading, input, and Apply button stay visible and usable.
Actual: The heading clips at the top and Apply gets covered by the keyboard.
VID_20261112_143051.mp4
Why my proposal is stronger (and already used in the app)
Mine identified both parts of the root cause (including how safe-area spacing drops when the keyboard opens), stays scoped to the filter popup, and can handle landscape cleanly in the PR too. This same bottom-sheet pattern is already proven in production across the anchored selection-list popovers (used by the Category and Tag picker modals):
App/src/hooks/useSelectionListPopoverLayout.ts
Lines 95 to 113 in 77f3036
Could you please take another look and reconsider moving forward with my proposal? Happy to open the PR right away!
github-actions commentedon Nov 12, 2026
x-dev90 commentedon Nov 12, 2026
@brunovjk, an update on how the approaches compare against main:
16dpin the testedAndroid 12lower pane, pushing a partially visible heading completely outside it. The cap limits the extra movement, but it does not prevent an incorrect movement.I also need to correct my earlier statement: some lower-pane clipping and excessive spacing already exist on main. Landscape Apply overlap and Merchant content collapse also pre-exist. Those are separate from the original portrait-overlap issue, though this fix should not make them worse.
The native coordinate correction in my proposal fixes the reported portrait overlap by calculating the view position and keyboard top relative to the same activity content. It avoids the extra split-screen shift, and no new regressions.. It does not claim to resolve the separate existing layout problems.
Reusing a pattern already used elsewhere in the app makes sense only if it also works correctly here. In these comparisons, the padding and capped-offset approaches introduce or worsen clipping, while the coordinate correction preserves baseline behavior and fixes the reported issue.
cc @puneetlath
samranahm commentedon Nov 12, 2026
@brunovjk I reported another issue we have in the same flow and proposed the fix for that as well in my proposal. Mind sharing your thoughts about this?
emkhalid commentedon Nov 13, 2026
@brunovjk, following up on the recent discussion:
I retested the rotation claim on an Android device, and the issue does not happen with my proposal (perhaps an incomplete version was tested). The heading stays visible, the input is accessible, and the Apply button is never covered.
video demo:
video_2026-11-13_16-37-19.mp4
To make reviewing simple, I created a clean test branch with my full changes applied here:
test branch: https://github.com/Expensify/App/compare/main...emkhalid:App:test-branch-105145?expand=1
Why this proposal remains the best fit:
Why my proposal is stronger (and already used in the app)
Mine identified both parts of the root cause (including how safe-area spacing drops when the keyboard opens), stays scoped to the filter popup, and can handle landscape cleanly in the PR too. This same bottom-sheet pattern is already proven in production across the anchored selection-list popovers (used by the Category and Tag picker modals):
App/src/hooks/useSelectionListPopoverLayout.ts
Lines 95 to 113 in 77f3036
Could you please take a look? Happy to open the PR right away!
github-actions commentedon Nov 13, 2026
brunovjk commentedon Nov 13, 2026
I’m a bit busy with another PR; I’ll get back here to review the latest comments ASAP. Thanks.