Skip to content

[$250] Android - Spend - "Apply" button is overlapped by keyboard in exposed filter. #105145

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.21-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #104671
Email or phone of affected tester (no customers): ibellicotest+3215@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Search

Action Performed:

  1. Open the Expensify app.
  2. Navigate to "Spend" > "Expenses"
  3. Tap on "FIlters" icon > "Withdrawal ID"
  4. Enter any ID > "Confirm" > "Apply Filters"
  5. Tap on exposed filter.
  6. Tap on text input to open keyboard.
  7. Note that "Apply" button is overlapped by keyboard and user can´t scroll down to it.

Expected Result:

"Apply" button should be completelly visible while editing withdrawal ID via exposed filter.

Actual Result:

"Apply" button is overlapped by keyboard while editing withdrawal ID via exposed filter and user is unable to scroll down to it.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7297588_1793067821661.Withdrawal.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7297588

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @puneetlath

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 27, 2026
  2. applause-bot commented on Oct 27, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/5641d273a629159887b0e9f777cf54c0e74e54c456366f0b042cdebb6b14df5a

  3. MelvinBot commented on Oct 27, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    On small screens, every text filter chip (Withdrawal ID, Description, Title, Report ID, and others) opens TextFilterPopup inside a bottom-docked FilterPopupButton sheet. Two problems stack up:

    1. Keyboard room comes only from the modal-level avoidKeyboard. That flag wraps the sheet in a padding KeyboardAvoidingView (ReanimatedModal/index.tsx:244). On this Android device it adds too little padding, or none, so the keyboard covers "Apply". The selection-list sheets stopped using avoidKeyboard for inputs for this reason. They pad the content with useReanimatedKeyboardAnimation instead (useSelectionListPopoverLayout.ts:90-105).
    2. There is no scroll fallback. BasePopup is a plain View with the input and then ActionButtons. FilterPopupButton also turns off the modal's only ScrollView wrapper (line 160). Once "Apply" is covered, you can't scroll to it.

    What changes do you think we should make in order to solve the problem?

    In FilterPopupButton, on small screens, follow the useSelectionListPopoverLayout pattern:

    • Stop passing avoidKeyboard to PopoverWithMeasuredContent.
    • Make the content wrapper (line 163) an Animated.View. Set its paddingBottom to max(safeAreaBottom, -keyboardHeight) from useReanimatedKeyboardAnimation. The sheet then rises with the keyboard and keeps "Apply" visible.

    This fixes all text filter chips at once, since they share this wrapper.

    What alternative solutions did you explore? (Optional)

    • Wrap BasePopup's children and ActionButtons in a ScrollView with keyboardShouldPersistTaps="handled". This makes "Apply" reachable but doesn't keep it in view. It is a good safety net to pair with the main fix.
    • Set automaticOffset on the shared KeyboardAvoidingView in ReanimatedModal. This changes every modal that uses avoidKeyboard, so it needs much broader QA.
    Investigation notes
    • Confidence: medium. The component chain and the missing scroll fallback are confirmed in code. The native reason the padding falls short is not confirmed. One likely cause is a mismatch between the Dialog window height and the screen height (for example, the 3-button nav bar on HybridApp). This run could only test on web, so it couldn't reproduce the Android keyboard. Check the fix on a physical Android device with 3-button navigation.
    • avoidKeyboard reaches Android intact: PopoverWithMeasuredContent → Popover/index.native (bottom-docked) → Modal/index.android → BaseModal → ReanimatedModal. The avoidKeyboard={false} in Modal/index.tsx applies only on web.
    • This is not a regression from Add the Withdrawal ID custom column to expense report searches. That PR only changes columns and sorting, and the issue also reproduces in production. Recent commits to FilterPopupButton don't touch keyboard handling.
    • MerchantFilterPopup uses the same layout, so the Merchant chip is likely affected too.

    Possibly related: Android & iOS - Spend - Unable to scroll down Describe your search page in landscape, "Describe your search" box hidden behind keyboard when put cursor on it in landscape


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/105145) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 27, 2026
  5. j3ffffff commented on Oct 27, 2026

    @j3ffffff
  6. melvin-bot commented on Oct 27, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

  7. changed the title [-]Android - Spend - "Apply" button is overlapped by keyboard in exposed filter.[/-] [+][$175] Android - Spend - "Apply" button is overlapped by keyboard in exposed filter.[/+] on Oct 27, 2026
  8. melvin-bot commented on Oct 27, 2026

    @melvin-bot
  9. camesenin commented on Oct 27, 2026

    @camesenin
  10. melvin-bot commented on Oct 27, 2026

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  11. apoorv-xs commented on Oct 27, 2026

    @apoorv-xs
  12. huhuli083-creator commented on Oct 27, 2026

    @huhuli083-creator

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On Android native, when opening an exposed filter popup in Spend (such as the Merchant, Description, Category, or Title filter popup) and focusing the text input, the soft keyboard overlaps the bottom "Apply" button instead of pushing the popup cleanly above the keyboard.

    What is the root cause of that problem?

    1. The exposed filter popups (TextFilterPopup, etc.) are rendered inside <PopoverWithMeasuredContent> via src/components/Search/FilterDropdowns/FilterPopupButton.tsx (lines 84–99):

      <PopoverWithMeasuredContent
          shouldHandleNavigationBack
          anchorRef={buttonRef}
          anchorPosition={popoverAnchorPosition}
          anchorAlignment={anchorAlignment}
          onClose={closePopup}
          isVisible={isPopupVisible}
          ...
    2. Across the entire codebase, <KeyboardProvider> (src/components/KeyboardProvider/index.tsx lines 7–9), <BaseModal> (src/components/Modal/BaseModal.tsx lines 117–118), and <ReanimatedModal> (src/components/Modal/ReanimatedModal/index.tsx lines 55–56) all default to:

      statusBarTranslucent = true,
      navigationBarTranslucent = true,

      However, src/components/PopoverWithMeasuredContent/PopoverWithMeasuredContentBase.tsx (line 58) is the only modal wrapper in the codebase that still defaults statusBarTranslucent to false:

      statusBarTranslucent = false,

      and passes statusBarTranslucent={statusBarTranslucent} down to <Popover> (line 237) -> <Modal> (BaseModal.tsx line 322) -> <ReanimatedModal> -> React Native's <Modal>.

    3. Why statusBarTranslucent = false (combined with navigationBarTranslucent = true) causes the exact keyboard overlap on Android:

      • In React Native's Android ReactModalHostView.kt, navigationBarTranslucent = true enables edge-to-edge on the modal Dialog window, while statusBarTranslucent = false sets fitsSystemWindows = true on the modal's contentView (FrameLayout).
      • Because fitsSystemWindows = true is set on contentView, Android insets the modal's root view group from the top by statusBarHeight (e.g. 40dp / 80px on Pixel 7 Pro) and from the bottom by navigationBarHeight.
      • Inside ReanimatedModal (src/components/Modal/ReanimatedModal/index.tsx lines 254–260), when avoidKeyboard is true, the modal content is wrapped in react-native-keyboard-controller's <KeyboardAvoidingView behavior="padding">.
      • In react-native-keyboard-controller's KeyboardAvoidingView (src/components/KeyboardAvoidingView/index.tsx lines 98–107), relativeKeyboardHeight() computes:
        const keyboardY = screenHeight - keyboard.height.value;
        return Math.max(frame.value.y + frame.value.height - keyboardY, 0);
        Here, screenHeight comes from the Activity's full edge-to-edge window (where statusBarTranslucent = true), while frame.value comes from onLayout inside the modal's dialogRootViewGroup (frame.value.y = 0, frame.value.height = screenHeight - statusBarHeight - navigationBarHeight).
      • Because frame.value.y is 0 relative to dialogRootViewGroup instead of reflecting the statusBarHeight top offset applied by fitsSystemWindows = true, frame.value.y + frame.value.height under-reports the view's bottom screen coordinate by statusBarHeight.
      • As a result, KeyboardAvoidingView applies paddingBottom that is short by statusBarHeight, leaving the bottom-docked "Apply" button overlapped by the top of the Android keyboard!

    What changes do you think we should make in order to solve the problem?

    In src/components/PopoverWithMeasuredContent/PopoverWithMeasuredContentBase.tsx (line 58), change the default value of statusBarTranslucent from false to true so PopoverWithMeasuredContent is consistent with BaseModal, ReanimatedModal, and KeyboardProvider:

    --- a/src/components/PopoverWithMeasuredContent/PopoverWithMeasuredContentBase.tsx
    +++ b/src/components/PopoverWithMeasuredContent/PopoverWithMeasuredContentBase.tsx
    @@ -55,7 +55,7 @@ function PopoverWithMeasuredContentBase({
         shouldSwitchPositionIfOverflow = false,
         shouldHandleNavigationBack = false,
    -    statusBarTranslucent = false,
    +    statusBarTranslucent = true,
         avoidKeyboard = true,
         ...props
     }: PopoverWithMeasuredContentProps) {

    With statusBarTranslucent = true, the modal's coordinate space on Android matches the main window and KeyboardProvider, so KeyboardAvoidingView calculates the exact relativeKeyboardHeight and pushes the "Apply" button completely above the keyboard.

    What alternative solutions did you explore? (Optional)

    • Passing statusBarTranslucent only in FilterPopupButton.tsx was considered, but every other modal in the app already defaults statusBarTranslucent = true in BaseModal.tsx and ReanimatedModal/index.tsx. Updating the default in PopoverWithMeasuredContentBase.tsx fixes all PopoverWithMeasuredContent popups with inputs on Android consistently.
  13. 101 remaining items

  14. brunovjk commented on Nov 11, 2026

    @brunovjk
    Contributor

    @brunovjk, I think we should reconsider the selection because the selected approach introduces the split-screen regression mentioned in my #105145 (comment).

    In an actual-App test on an Android 12 emulator, implementing the proposed keyboard-height padding with avoidKeyboard disabled fixed the full-screen overlap. However, with Expensify in the lower split-screen pane, it pushed the Withdrawal ID heading partly outside the visible pane and left excessive space below Apply. The baseline kept the heading, input and Apply visible.

    Keeping the fix scoped to filters makes sense, but reusing the selection-list padding pattern doesn’t resolve this case. Could we revisit the selection and compare the approaches against this regression before proceeding?

    cc @puneetlath

    Let me check in a moment

  15. emkhalid commented on Nov 11, 2026

    @emkhalid
    Contributor

    @brunovjk, thanks for reviewing this and picking a scoped approach that reuses the app's existing keyboard pattern. My proposal follows that exact direction without touching shared modal code, while also catching the safe-area drop—and while testing the selected proposal, I found a regression to flag.

    Regression: Landscape rotation clips the heading and covers Apply

    • Open Spend on Android in portrait and tap a text filter (such as Withdrawal ID).
    • Tap the input field so the keyboard opens.
    • Rotate the phone to landscape.

    Expected: The heading, input, and Apply button stay visible and usable.
    Actual: The heading clips at the top and Apply gets covered by the keyboard.

    VID_20261112_143051.mp4

    Why my proposal is stronger (and already used in the app)
    Mine identified both parts of the root cause (including how safe-area spacing drops when the keyboard opens), stays scoped to the filter popup, and can handle landscape cleanly in the PR too. This same bottom-sheet pattern is already proven in production across the anchored selection-list popovers (used by the Category and Tag picker modals):

    // The keyboard's offset is negative while it is open. It covers the home indicator, so the sheet pads for whichever is taller.
    const {height: keyboardOffset} = useReanimatedKeyboardAnimation();
    const keyboardRoomStyle = useAnimatedStyle(() => ({paddingBottom: Math.max(safeAreaPaddingBottom, -keyboardOffset.get())}));
    return {
    popoverDimensions: {width: popoverWidth, height},
    innerContainerStyle: isSmallScreenWidth ? undefined : StyleUtils.getWidthStyle(popoverWidth),
    // Mobile Safari ignores `interactive-widget=resizes-content` and leaves the sheet docked behind the keyboard, so on mobile browsers
    // the sheet is sized and offset to the visual viewport, which the keyboard does shrink.
    outerStyle: isSmallScreenWidth ? {...styles.w100, ...StyleUtils.getOuterModalStyle(windowHeight, viewportOffsetTop)} : undefined,
    avoidKeyboard: isSmallScreenWidth && !shouldPadForKeyboard,
    /** Style for an `Animated.View` holding the header and the list, since the keyboard room animates with the keyboard */
    contentStyle: [
    StyleUtils.getHeight(height),
    styles.flexColumn,
    !shouldSkipListTopPadding && styles.pt4,
    shouldPadForKeyboard ? keyboardRoomStyle : StyleUtils.getPaddingBottom(bottomSafeAreaPadding),
    ],
    };

    Could you please take another look and reconsider moving forward with my proposal? Happy to open the PR right away!

  16. github-actions commented on Nov 11, 2026

    @github-actions
    Contributor

    ⚠️ @emkhalid Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  17. neerajbachani commented on Nov 11, 2026

    @neerajbachani
    Contributor

    @brunovjk @puneetlath, I retested the selected padding fix against the two reconsiderations, on a Pixel 7 (API 34, 1080×2400), and I updated my proposal from those numbers. I think we should switch the selection.

    Both objections to the selected approach are real. Neither one is a reason to keep it, and the landscape guard does not finish the job.

    What the bug actually is. The sheet already lifts. On that phone the keyboard top is at y=1517 and Apply's bottom is at y=1611, so the button is covered by 94px. The missing lift is 136px, the status bar.
    The other 63px under the dialog is the navigation bar, which the keyboard height already includes. KeyboardAvoidingView measures its parent, not the window, and this dialog's parent is short by that status bar. That is the same offset the distance screen already passes, capped so we do not also add the navigation bar.

    x-dev90's split-screen point. I implemented the selected padding (avoidKeyboard off, pad by the full keyboard height). In a lower split pane that is exactly the over-lift you described: the pad is the whole keyboard, not the missing status bar, so the heading is pushed out and Apply sits on a large empty gap. Keeping avoidKeyboard and adding only min(measured gap, status bar height) cannot do that. The correction is at most one status bar, and it is zero when the dialog already fills the window. I would still like that lower pane checked on the PR with the keyboard open. It is not a reason to pad by the keyboard height.

    emkhalid's landscape point. Also real, and it is about rotation, not the chip tap. The chip in landscape already leaves this sheet and opens the advanced filters page. Rotating while the sheet is open, with the selected padding and no landscape guard, clips the heading to 15px and still covers Apply by 49px. Adding !isInLandscapeMode saves the heading, but Apply is still covered by 32px, and the guard flips avoidKeyboard on rotate. That swaps the modal wrapper. useSelectionListPopoverLayout already refuses that, because the sheet remounts and the input loses focus. So the guard does not make the padding approach safe, and it is not the pattern that hook is asking us to copy.

    What I measured for the capped offset, on the same phone:

    Portrait Rotate, keyboard still open
    Unfixed Apply covered 94px, heading visible Apply covered 74px, heading visible
    Selected padding Apply clear (42px gap) Heading clipped to 15px, Apply covered 49px
    Padding + landscape guard Apply clear Heading saved, Apply still covered 32px
    Uncapped measured gap Apply clear, but 105px of empty space (63px too much) Sheet gone
    Capped offset, avoidKeyboard kept, landscape skipped Apply clear, 42px gap, extra lift is exactly the 136px status bar, heading visible Heading stays. Apply still covered 74px, same as today

    The portrait case is the bug in the issue. This is the only approach that clears Apply by the distance that is actually missing, leaves the heading up, and does not turn the keyboard avoidance off. Landscape rotation is left as it is today instead of being made worse. The chip tap in landscape is unchanged.

    Happy to take the PR. The lower split pane with the keyboard open should be on the test plan.

  18. github-actions commented on Nov 11, 2026

    @github-actions
    Contributor

    ⚠️ @neerajbachani Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  19. mukhrr commented on Nov 12, 2026

    @mukhrr
    Contributor

    oh so much AI things above 🤯

    @brunovjk, I think we should reconsider the selection because the selected approach introduces the split-screen regression mentioned in my #105145 (comment).

    In an actual-App test on an Android 12 emulator, implementing the proposed keyboard-height padding with avoidKeyboard disabled fixed the full-screen overlap. However, with Expensify in the lower split-screen pane, it pushed the Withdrawal ID heading partly outside the visible pane and left excessive space below Apply. The baseline kept the heading, input and Apply visible.

    Keeping the fix scoped to filters makes sense, but reusing the selection-list padding pattern doesn’t resolve this case. Could we revisit the selection and compare the approaches against this regression before proceeding?

    cc @puneetlath

    I dont think this is real. at least I am not able to reproduce this.

    And what @emkhalid @neerajbachani pointed seems valid. But their solution sounds too overmessed to me. We can just use a prop to fix it as we do for AnchoredSelectionListPopover.

    shouldLimitHeightIfBottomDockedInLandscapeMode={!shouldPadForKeyboard}

    no !isInLandscapeMode gueard, no new prop through Modal, BaseModal and ReanimatedModal, etc.
    let me update proposal only with this line

    @brunovjk wdyt? cc @puneetlath

  20. github-actions commented on Nov 12, 2026

    @github-actions
    Contributor

    ⚠️ @mukhrr Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  21. emkhalid commented on Nov 12, 2026

    @emkhalid
    Contributor

    @brunovjk, thanks for reviewing this and picking a scoped approach that reuses the app's existing keyboard pattern. My proposal follows that exact direction without touching shared modal code, while also catching the safe-area drop—and while testing the selected proposal, I found a regression to flag.

    Regression: Landscape rotation clips the heading and covers Apply

    • Open Spend on Android in portrait and tap a text filter (such as Withdrawal ID).
    • Tap the input field so the keyboard opens.
    • Rotate the phone to landscape.

    Expected: The heading, input, and Apply button stay visible and usable.
    Actual: The heading clips at the top and Apply gets covered by the keyboard.

    VID_20261112_143051.mp4

    Why my proposal is stronger (and already used in the app)
    Mine identified both parts of the root cause (including how safe-area spacing drops when the keyboard opens), stays scoped to the filter popup, and can handle landscape cleanly in the PR too. This same bottom-sheet pattern is already proven in production across the anchored selection-list popovers (used by the Category and Tag picker modals):

    // The keyboard's offset is negative while it is open. It covers the home indicator, so the sheet pads for whichever is taller.
    const {height: keyboardOffset} = useReanimatedKeyboardAnimation();
    const keyboardRoomStyle = useAnimatedStyle(() => ({paddingBottom: Math.max(safeAreaPaddingBottom, -keyboardOffset.get())}));
    return {
    popoverDimensions: {width: popoverWidth, height},
    innerContainerStyle: isSmallScreenWidth ? undefined : StyleUtils.getWidthStyle(popoverWidth),
    // Mobile Safari ignores `interactive-widget=resizes-content` and leaves the sheet docked behind the keyboard, so on mobile browsers
    // the sheet is sized and offset to the visual viewport, which the keyboard does shrink.
    outerStyle: isSmallScreenWidth ? {...styles.w100, ...StyleUtils.getOuterModalStyle(windowHeight, viewportOffsetTop)} : undefined,
    avoidKeyboard: isSmallScreenWidth && !shouldPadForKeyboard,
    /** Style for an `Animated.View` holding the header and the list, since the keyboard room animates with the keyboard */
    contentStyle: [
    StyleUtils.getHeight(height),
    styles.flexColumn,
    !shouldSkipListTopPadding && styles.pt4,
    shouldPadForKeyboard ? keyboardRoomStyle : StyleUtils.getPaddingBottom(bottomSafeAreaPadding),
    ],
    };

    Could you please take another look and reconsider moving forward with my proposal? Happy to open the PR right away!

  22. github-actions commented on Nov 12, 2026

    @github-actions
    Contributor

    ⚠️ @emkhalid Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  23. x-dev90 commented on Nov 12, 2026

    @x-dev90

    @brunovjk, an update on how the approaches compare against main:

    • emkhalid’s approach introduces heading clipping on Android 12 when opening Withdrawal ID in portrait, focusing the input, and rotating to landscape. Main keeps the heading visible. Apply remains mostly covered.
    • The selected approach, including the height-limit adjustment, makes Apply visible after rotation but still hides the heading. It also worsens the clipping already present in the lower split-screen pane. The additional prop does not resolve those regressions.
    • neerajbachani’s capped-offset approach adds an unnecessary 16dp in the tested Android 12 lower pane, pushing a partially visible heading completely outside it. The cap limits the extra movement, but it does not prevent an incorrect movement.

    I also need to correct my earlier statement: some lower-pane clipping and excessive spacing already exist on main. Landscape Apply overlap and Merchant content collapse also pre-exist. Those are separate from the original portrait-overlap issue, though this fix should not make them worse.

    The native coordinate correction in my proposal fixes the reported portrait overlap by calculating the view position and keyboard top relative to the same activity content. It avoids the extra split-screen shift, and no new regressions.. It does not claim to resolve the separate existing layout problems.

    Reusing a pattern already used elsewhere in the app makes sense only if it also works correctly here. In these comparisons, the padding and capped-offset approaches introduce or worsen clipping, while the coordinate correction preserves baseline behavior and fixes the reported issue.

    cc @puneetlath

  24. samranahm commented on Nov 12, 2026

    @samranahm
    Contributor

    @brunovjk I reported another issue we have in the same flow and proposed the fix for that as well in my proposal. Mind sharing your thoughts about this?

  25. emkhalid commented on Nov 13, 2026

    @emkhalid
    Contributor

    @brunovjk, following up on the recent discussion:

    I retested the rotation claim on an Android device, and the issue does not happen with my proposal (perhaps an incomplete version was tested). The heading stays visible, the input is accessible, and the Apply button is never covered.

    video demo:

    video_2026-11-13_16-37-19.mp4

    To make reviewing simple, I created a clean test branch with my full changes applied here:

    test branch: https://github.com/Expensify/App/compare/main...emkhalid:App:test-branch-105145?expand=1

    Why this proposal remains the best fit:

    • Fully working: Cleanly solves the keyboard overlap in portrait and handles landscape rotation without issues.
    • Safest blast radius: Stays strictly inside the filter button without modifying shared modal components or adding risky native patches.
    • Standard app pattern: Reuses the exact same keyboard approach already trusted across our other pickers.

    Why my proposal is stronger (and already used in the app)
    Mine identified both parts of the root cause (including how safe-area spacing drops when the keyboard opens), stays scoped to the filter popup, and can handle landscape cleanly in the PR too. This same bottom-sheet pattern is already proven in production across the anchored selection-list popovers (used by the Category and Tag picker modals):

    // The keyboard's offset is negative while it is open. It covers the home indicator, so the sheet pads for whichever is taller.
    const {height: keyboardOffset} = useReanimatedKeyboardAnimation();
    const keyboardRoomStyle = useAnimatedStyle(() => ({paddingBottom: Math.max(safeAreaPaddingBottom, -keyboardOffset.get())}));
    return {
    popoverDimensions: {width: popoverWidth, height},
    innerContainerStyle: isSmallScreenWidth ? undefined : StyleUtils.getWidthStyle(popoverWidth),
    // Mobile Safari ignores `interactive-widget=resizes-content` and leaves the sheet docked behind the keyboard, so on mobile browsers
    // the sheet is sized and offset to the visual viewport, which the keyboard does shrink.
    outerStyle: isSmallScreenWidth ? {...styles.w100, ...StyleUtils.getOuterModalStyle(windowHeight, viewportOffsetTop)} : undefined,
    avoidKeyboard: isSmallScreenWidth && !shouldPadForKeyboard,
    /** Style for an `Animated.View` holding the header and the list, since the keyboard room animates with the keyboard */
    contentStyle: [
    StyleUtils.getHeight(height),
    styles.flexColumn,
    !shouldSkipListTopPadding && styles.pt4,
    shouldPadForKeyboard ? keyboardRoomStyle : StyleUtils.getPaddingBottom(bottomSafeAreaPadding),
    ],
    };

    Could you please take a look? Happy to open the PR right away!

  26. github-actions commented on Nov 13, 2026

    @github-actions
    Contributor

    ⚠️ @emkhalid Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  27. brunovjk commented on Nov 13, 2026

    @brunovjk
    Contributor

    I’m a bit busy with another PR; I’ll get back here to review the latest comments ASAP. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsOverdue

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions