Skip to content

[Due for payment 2026-11-03] [$350] [Performance] Reduce Search re-renders when opening reports #104742

Closed

Description

@rlinoz

Objective

Reduce unnecessary Search row re-renders when opening a report to improve ManualOpenReport, particularly on slower machines.

Parent: #77173

Slack discussion

Background

Search currently does unnecessary work when a report opens: shared context actions change identity, keyboard focus invalidates every visible row, and broad Onyx subscriptions rebuild Search data for unrelated updates.

The author reported that the combined optimizations reduced ManualOpenReport from approximately 2s to 1.2s (40%) in a web development build with 4× CPU throttling, used to approximate slower machines. Without throttling, the reported timings improved from approximately 330ms to 180ms. These are preliminary local measurements, not verified production results or measurements of each PR individually.

PRs tracked by this issue

The four changes were split into separate draft PRs so each can be tested and shipped independently:

Related optimization already merged

#104716 memoizes Search column-size options to avoid re-rendering every row. It is already tracked separately in #104718; reference it when assessing the combined improvements, without duplicating its implementation tracking here.

Validation / completion criteria

  • Test each of the four PRs independently before marking it ready for review, then verify the combined result.
  • Capture comparable before/after ManualOpenReport measurements with and without CPU throttling, documenting the build, account size, and test conditions.
  • Verify report opening and RHP width behavior, keyboard focus/navigation across Search result types, action-loading indicators, archived task state, row/range/select-all selection, and expense-carousel navigation including newly loaded results.
  • Verify applicable offline behavior and no new console errors, following each PR's test and QA steps across supported platforms.
  • Track all four PRs through merge and QA, then assess the effect on the parent Open Report performance metric.
Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 22, 2026
  2. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  3. changed the title [-][Performance] Reduce Search re-renders when opening reports[/-] [+][$175] [Performance] Reduce Search re-renders when opening reports[/+] on Oct 22, 2026
  4. melvin-bot commented on Oct 22, 2026

    @melvin-bot
  5. self-assigned this
    on Oct 22, 2026
  6. Abdallah-1551 commented on Oct 22, 2026

    @Abdallah-1551
  7. 27 remaining items

  8. melvin-bot commented on Nov 5, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  9. mallenexpensify commented on Nov 6, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @hoangzinh due $350 via NewDot

  10. trjExpensify commented on Nov 9, 2026

    @trjExpensify
    Contributor

    approved $350 for @hoangzinh

  11. hoangzinh commented on Nov 11, 2026

    @hoangzinh
    Contributor

    Thanks, @trjExpensify. But the expense status is still "Waiting for Lauren Reid to approve expenses"

  12. laurenreidexpensify commented on Nov 11, 2026

    @laurenreidexpensify
    Contributor

    approved $350 for @hoangzinh

  13. trjExpensify commented on Nov 11, 2026

    @trjExpensify
    Contributor

    Thanks, @trjExpensify. But the expense status is still "Waiting for Lauren Reid to approve expenses"

    I'm not sure what you're referring to here. Wrong thread/issue or something?

  14. hoangzinh commented on Nov 12, 2026

    @hoangzinh
    Contributor

    I previously found that the expense would be paid shortly after the first approval. However, it is still stuck at the approval stage after you approved @trjExpensify. I wanted to check if the workflow has changed or if it is stuck/bug.

  15. pinned and unpinned a comment on Nov 12, 2026
  16. trjExpensify commented on Nov 13, 2026

    @trjExpensify
    Contributor

    Oh gotcha. Do you have the URL of the report? @laurenreidexpensify can click it and check if she needs to do another approval.

  17. hoangzinh commented on Nov 16, 2026

    @hoangzinh
    Contributor

    All goods now @trjExpensify. I got paid. Thanks for the follow-ups

  18. trjExpensify commented on Nov 17, 2026

    @trjExpensify
    Contributor

    Cool, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions