Repository navigation
Description
Objective
Reduce unnecessary Search row re-renders when opening a report to improve ManualOpenReport, particularly on slower machines.
Parent: #77173
Background
Search currently does unnecessary work when a report opens: shared context actions change identity, keyboard focus invalidates every visible row, and broad Onyx subscriptions rebuild Search data for unrelated updates.
The author reported that the combined optimizations reduced ManualOpenReport from approximately 2s to 1.2s (40%) in a web development build with 4× CPU throttling, used to approximate slower machines. Without throttling, the reported timings improved from approximately 330ms to 180ms. These are preliminary local measurements, not verified production results or measurements of each PR individually.
PRs tracked by this issue
The four changes were split into separate draft PRs so each can be tested and shipped independently:
- perf: Keep WideRHP actions stable on row press #104735 — Keep WideRHP actions stable on row press; store width hints in a ref and narrow report-type subscriptions.
- perf: make Search rows read their own focus #104734 — Make Search rows read their own keyboard focus so focus changes re-render only the affected rows.
- perf: Narrow Search snapshot subscriptions to loading actions and task name-value pairs #104736 — Narrow Search snapshot subscriptions to action-loading report IDs and task-specific name-value pairs.
- perf: Keep Search row selection actions stable #104739 — Keep Search row selection actions and expense-carousel callbacks stable while reading current data at interaction time.
Related optimization already merged
#104716 memoizes Search column-size options to avoid re-rendering every row. It is already tracked separately in #104718; reference it when assessing the combined improvements, without duplicating its implementation tracking here.
Validation / completion criteria
- Test each of the four PRs independently before marking it ready for review, then verify the combined result.
- Capture comparable before/after
ManualOpenReportmeasurements with and without CPU throttling, documenting the build, account size, and test conditions. - Verify report opening and RHP width behavior, keyboard focus/navigation across Search result types, action-loading indicators, archived task state, row/range/select-all selection, and expense-carousel navigation including newly loaded results.
- Verify applicable offline behavior and no new console errors, following each PR's test and QA steps across supported platforms.
- Track all four PRs through merge and QA, then assess the effect on the parent Open Report performance metric.
Issue Owner
Current Issue Owner: @mallenexpensifyUpwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022113269301915878946
- Upwork Job ID: 2113269301915878946
- Last Price Increase: 2026-10-29
Metadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Oct 22, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)[-][Performance] Reduce Search re-renders when opening reports[/-][+][$175] [Performance] Reduce Search re-renders when opening reports[/+]melvin-bot commentedon Oct 22, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022113269301915878946
Abdallah-1551 commentedon Oct 22, 2026
27 remaining items
melvin-bot commentedon Nov 5, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
mallenexpensify commentedon Nov 6, 2026
Payment Summary
Contributor+: @hoangzinh due $350 via NewDot
trjExpensify commentedon Nov 9, 2026
approved $350 for @hoangzinh
hoangzinh commentedon Nov 11, 2026
Thanks, @trjExpensify. But the expense status is still "Waiting for Lauren Reid to approve expenses"
laurenreidexpensify commentedon Nov 11, 2026
approved $350 for @hoangzinh
trjExpensify commentedon Nov 11, 2026
I'm not sure what you're referring to here. Wrong thread/issue or something?
hoangzinh commentedon Nov 12, 2026
I previously found that the expense would be paid shortly after the first approval. However, it is still stuck at the approval stage after you approved @trjExpensify. I wanted to check if the workflow has changed or if it is stuck/bug.
trjExpensify commentedon Nov 13, 2026
Oh gotcha. Do you have the URL of the report? @laurenreidexpensify can click it and check if she needs to do another approval.
hoangzinh commentedon Nov 16, 2026
All goods now @trjExpensify. I got paid. Thanks for the follow-ups
trjExpensify commentedon Nov 17, 2026
Cool, sounds good!