Skip to content

perf: memoize Search column size options so leaving Spend doesn't re-render every row - #104716

Merged
JS00001 merged 3 commits into
Expensify:mainfrom
callstack-internal:perf/search-stable-column-options
Oct 22, 2026
Merged

JS00001 merged 3 commits into
Expensify:mainfrom
callstack-internal:perf/search-stable-column-options

Conversation

@BartekObudzinski

@BartekObudzinski BartekObudzinski commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Search doesn't compile with React Compiler, and it built columnSizeOptions as a new object on every render. That object reaches SearchColumnWidthsContext through SearchListViewLayout, so each Search render gave every TransactionItemRowWide new column styles and re-rendered every row and its cells. In the flat expense and expense report views, useSearchColumnWidths also measured the text of every row again.

Search re-renders when the Spend tab loses focus, so tapping Inbox from Spend paid for all of it inside ManualNavigateToInboxTab.

The object now comes from a useMemo with the same flags. The memo sits above the component's early returns, where its inputs already exist, so rows re-render only when a column changes width. The values don't change.

I measured a minified local build with the CPU slowed 2x, on the first tap of a preloaded Inbox tab, in 4 interleaved rounds of 4 taps per variant:

Tap starts on Before (mean / median) After (mean / median) Change
Spend 219.8 / 221 ms 194.4 / 190 ms -25.4 ms (-11.5%), faster in all 4 rounds
Home 174.4 / 175 ms 175.4 / 175.5 ms none

I didn't add a unit test. SearchPageTest only renders the narrow layout, and a wide-layout test that counts row renders would mostly test the compiler. The measurement above is the evidence.

Fixed Issues

$ #104718
PROPOSAL:

Tests

  1. Open the app on a wide screen and go to Spend > Expenses.
  2. Verify the table header and the rows line up, column by column.
  3. Pick a search with expenses from a previous year, and verify the date column shows the year in the header and in the rows.
  4. Tap Inbox, then tap Spend again.
  5. Verify the columns look exactly as they did in step 2.
  6. Open Spend > Reports and repeat steps 2, 4 and 5.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests. The change only affects how the column options object is built, not where the data comes from.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Spend > Expenses after tapping Inbox and coming back, with the fix. The header and rows line up. The same screenshot from main is byte-identical.

@melvin-bot

melvin-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team October 22, 2026 11:49
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T12:52:43.300868Z c078593 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@BartekObudzinski

Copy link
Copy Markdown
Contributor Author

@MelvinBot test

@Eskalifer1

Copy link
Copy Markdown
Contributor

Reviewing it today

@MelvinBot

MelvinBot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Web test steps verification results: ⚠️ partial

On a wide web viewport, the Spend > Expenses and Spend > Reports tables kept their headers and rows aligned, showed the year for a 2025 expense, and looked identical after a round trip through Inbox. The JS console could not be read in this test session, so the console step is unverified.
Reports table after Inbox and back

Step Status
1. Open Spend > Expenses on a wide screen; the table loadsAfter creating two expenses (the test account had none), the table loaded with headers Receipt, Type, Date, Status, Merchant, Category, Amount and two rows.
Spend Expenses table with aligned columns
✅
2. Table header and rows line up column by columnEach header sits over its values (Oct 22 / Draft / Coffee Shop / Meals and Entertainment / $25.00, and Oct 15, 2025 / Draft / Hotel Stay / Travel / $50.00) with no overlap or offset.
Spend Expenses table with aligned columns
✅
3. Date column shows the year for expenses from a previous yearThe 2025 expense shows "Oct 15, 2025" and the current-year expense shows "Oct 22". Both fit under the Date header without truncation.
Spend Expenses table with aligned columns
✅
4. Tap Inbox, then tap Spend againInbox opened (Concierge chat), then Spend reopened on the Expenses tab with both rows.
✅
5. Columns look exactly as they did in step 2The layout after the round trip matches the step 2 capture: same column positions and row content.
Expenses table after Inbox and back
✅
6. Spend > Reports: header and rows line upOne report ($75.00) shows Created, Status, Title, From, To, Total, Action, each aligned over its value.
Spend Reports table
✅
7. Reports: tap Inbox, then Spend; columns look the sameSpend reopened on the Reports tab with the same column layout as step 6.
Reports table after Inbox and back
✅
8. No errors appear in the JS consoleThe web test tool can't read console logs in this session. No error banners, broken layouts, or stalled renders appeared in the UI, but the console itself was not checked.
⚠️

view run · view recording

@Eskalifer1

Copy link
Copy Markdown
Contributor

@codex review

@Eskalifer1

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
2026-10-22.15.39.52.mov

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: c0785935f9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@Eskalifer1 Eskalifer1 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like MacOS: Chrome / Safari is not correctly completed :)

@Eskalifer1 Eskalifer1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested a review from JS00001 October 22, 2026 12:56
@JS00001
JS00001 merged commit 9279ac9 into Expensify:main Oct 22, 2026
46 of 48 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.20-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed: this PR only memoizes the Search column size options for performance, so column widths, labels, and behavior that users see stay the same.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.20-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants