Repository navigation
Conversation
|
@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@MelvinBot test |
|
Reviewing it today |
|
@codex review |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari2026-10-22.15.39.52.mov |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.20-0 🚀
|
|
No help site update is needed: this PR only memoizes the Search column size options for performance, so column widths, labels, and behavior that users see stay the same. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.20-5 🚀
Bundle Size Analysis (Sentry): |




Explanation of Change
Searchdoesn't compile with React Compiler, and it builtcolumnSizeOptionsas a new object on every render. That object reachesSearchColumnWidthsContextthroughSearchListViewLayout, so each Search render gave everyTransactionItemRowWidenew column styles and re-rendered every row and its cells. In the flat expense and expense report views,useSearchColumnWidthsalso measured the text of every row again.Search re-renders when the Spend tab loses focus, so tapping Inbox from Spend paid for all of it inside
ManualNavigateToInboxTab.The object now comes from a
useMemowith the same flags. The memo sits above the component's early returns, where its inputs already exist, so rows re-render only when a column changes width. The values don't change.I measured a minified local build with the CPU slowed 2x, on the first tap of a preloaded Inbox tab, in 4 interleaved rounds of 4 taps per variant:
I didn't add a unit test.
SearchPageTestonly renders the narrow layout, and a wide-layout test that counts row renders would mostly test the compiler. The measurement above is the evidence.Fixed Issues
$ #104718
PROPOSAL:
Tests
Offline tests
Same as tests. The change only affects how the column options object is built, not where the data comes from.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Spend > Expenses after tapping Inbox and coming back, with the fix. The header and rows line up. The same screenshot from
mainis byte-identical.