You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment] [$500] Android - Composer is hidden by native emoji picker - Reported by @rushatgabhane #10483
Select the emoji picker from the native virtual keyboard
Expected Result:
composer is not hidden by native emoji picker
Actual Result:
composer is hidden by native emoji picker
Workaround:
unknown
Platform:
Where is this issue occurring?
Android
Version Number: 1.1.88-14 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$500] Android - Composer is hidden by native emoji picker - Reported by @rushatgabhane [/-][+][HOLD for payment] [$500] Android - Composer is hidden by native emoji picker - Reported by @rushatgabhane [/+]on Dec 23, 2022
Looks like this wasn't resolved while I was out, so I'll jump in now that I'm back. I think doubling the price of this issue is fair. That comes out to $1,000. @dylanexpensify is out for the holidays, and I think we still need to retest to ensure this is no longer a live issue. @mallenexpensify this might be a good one to take over since you're around over the holidays.
I co-assigned. I'll get to it over the holidays, maybe today but I got a lil bit to do before logging off in an ~hour. Bumped to Daily. Thanks for the patience @0xmiroslav
Thanks @0xmiroslav for helping us fix the android keyboard issues. I def saw multiple bug reports and GH issues for 'em.
For #11087 you were paid $3000, but $1000 was a bonus so, if we are discussing what compensation should be for a situation like this, we shouldn't take into account any bonuses for doing quick work. I don't think you were compensated for other related issues but I might have missed that. Generally speaking, for deciding on bonuses and partial payments, we've found it's best practice to use a percentage vs a dollar amount. So, for this issue, I think a 50% bonus is fair, and that'd be on the job price before the bonus, so $1000.
It's hard to standardize on a process for payment for a PR that fixes multiple bugs (and... similarly, multiple bug reports that are fixed by a single PR). I think it's safe to assume that we weren't sure what was going on, by creating the multiple issues it helped us figure it out and also provided a level of urgency since your PR would fix the bugs.
The bonus should be applied to #11087 since that's the main issue. I'll post over there and issue payment.
Activity
melvin-bot commentedon Aug 23, 2022
Triggered auto assignment to @abekkala (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.OSBotify commentedon Aug 23, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 23, 2022
Triggered auto assignment to @yuwenmemon (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.76 remaining items
[-][$500] Android - Composer is hidden by native emoji picker - Reported by @rushatgabhane [/-][+][HOLD for payment] [$500] Android - Composer is hidden by native emoji picker - Reported by @rushatgabhane [/+]JmillsExpensify commentedon Dec 23, 2022
Looks like this wasn't resolved while I was out, so I'll jump in now that I'm back. I think doubling the price of this issue is fair. That comes out to $1,000. @dylanexpensify is out for the holidays, and I think we still need to retest to ensure this is no longer a live issue. @mallenexpensify this might be a good one to take over since you're around over the holidays.
mallenexpensify commentedon Dec 23, 2022
I co-assigned. I'll get to it over the holidays, maybe today but I got a lil bit to do before logging off in an ~hour. Bumped to
Daily. Thanks for the patience @0xmiroslavmelvin-bot commentedon Dec 27, 2022
@mallenexpensify, @rushatgabhane, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
mallenexpensify commentedon Dec 27, 2022
Working on this @0xmiroslav , hoping to have an update tomorrow.
mallenexpensify commentedon Dec 28, 2022
Thanks @0xmiroslav for helping us fix the android keyboard issues. I def saw multiple bug reports and GH issues for 'em.
For #11087 you were paid $3000, but $1000 was a bonus so, if we are discussing what compensation should be for a situation like this, we shouldn't take into account any bonuses for doing quick work. I don't think you were compensated for other related issues but I might have missed that. Generally speaking, for deciding on bonuses and partial payments, we've found it's best practice to use a percentage vs a dollar amount. So, for this issue, I think a 50% bonus is fair, and that'd be on the job price before the bonus, so $1000.
It's hard to standardize on a process for payment for a PR that fixes multiple bugs (and... similarly, multiple bug reports that are fixed by a single PR). I think it's safe to assume that we weren't sure what was going on, by creating the multiple issues it helped us figure it out and also provided a level of urgency since your PR would fix the bugs.
The bonus should be applied to #11087 since that's the main issue. I'll post over there and issue payment.
mallenexpensify commentedon Dec 28, 2022
I believe this issue can be closed now since there isn't an associated/linked PR for this. Comment/reopen if ya want.
0xmiroslav commentedon Dec 28, 2022
Thanks @mallenexpensify, I appreciate that much.