Skip to content

[HOLD for payment] [$500] Android - Composer is hidden by native emoji picker - Reported by @rushatgabhane  #10483

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login
  2. Go to a chat with any user
  3. Tap on compose box to open the virtual keyboard
  4. Select the emoji picker from the native virtual keyboard

Expected Result:

composer is not hidden by native emoji picker

Actual Result:

composer is hidden by native emoji picker

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.88-14
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-20220823-023430.mp4

Expensify/Expensify Issue URL:
Issue reported by: @rushatgabhane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661203695542579

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Aug 23, 2022
  2. melvin-bot commented on Aug 23, 2022

    @melvin-bot

    Triggered auto assignment to @abekkala (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  3. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Aug 23, 2022
  4. OSBotify commented on Aug 23, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 23, 2022

    @melvin-bot

    Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Aug 23, 2022
  7. 76 remaining items

  8. changed the title [-][$500] Android - Composer is hidden by native emoji picker - Reported by @rushatgabhane [/-] [+][HOLD for payment] [$500] Android - Composer is hidden by native emoji picker - Reported by @rushatgabhane [/+] on Dec 23, 2022
  9. JmillsExpensify commented on Dec 23, 2022

    @JmillsExpensify
    Contributor

    Looks like this wasn't resolved while I was out, so I'll jump in now that I'm back. I think doubling the price of this issue is fair. That comes out to $1,000. @dylanexpensify is out for the holidays, and I think we still need to retest to ensure this is no longer a live issue. @mallenexpensify this might be a good one to take over since you're around over the holidays.

  10. mallenexpensify commented on Dec 23, 2022

    @mallenexpensify
    Contributor

    I co-assigned. I'll get to it over the holidays, maybe today but I got a lil bit to do before logging off in an ~hour. Bumped to Daily. Thanks for the patience @0xmiroslav

  11. melvin-bot commented on Dec 27, 2022

    @melvin-bot

    @mallenexpensify, @rushatgabhane, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  12. mallenexpensify commented on Dec 27, 2022

    @mallenexpensify
    Contributor

    Working on this @0xmiroslav , hoping to have an update tomorrow.

  13. mallenexpensify commented on Dec 28, 2022

    @mallenexpensify
    Contributor

    Thanks @0xmiroslav for helping us fix the android keyboard issues. I def saw multiple bug reports and GH issues for 'em.

    For #11087 you were paid $3000, but $1000 was a bonus so, if we are discussing what compensation should be for a situation like this, we shouldn't take into account any bonuses for doing quick work. I don't think you were compensated for other related issues but I might have missed that. Generally speaking, for deciding on bonuses and partial payments, we've found it's best practice to use a percentage vs a dollar amount. So, for this issue, I think a 50% bonus is fair, and that'd be on the job price before the bonus, so $1000.

    It's hard to standardize on a process for payment for a PR that fixes multiple bugs (and... similarly, multiple bug reports that are fixed by a single PR). I think it's safe to assume that we weren't sure what was going on, by creating the multiple issues it helped us figure it out and also provided a level of urgency since your PR would fix the bugs.

    The bonus should be applied to #11087 since that's the main issue. I'll post over there and issue payment.

  14. mallenexpensify commented on Dec 28, 2022

    @mallenexpensify
    Contributor

    I believe this issue can be closed now since there isn't an associated/linked PR for this. Comment/reopen if ya want.

  15. 0xmiroslav commented on Dec 28, 2022

    @0xmiroslav
    Contributor

    Thanks @mallenexpensify, I appreciate that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions