Skip to content

[HOLD for BZ checklist] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan #11087

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to setting > profile > Add phone number
  2. click on password
  3. check send validation button

Expected Result:

Send validation button should not be hidden

Actual Result:

Send validation button is hidden

Platform:

  • Android

Version Number: 1.1.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43995119/190951528-cf5f7ee0-d6e4-43f6-8f4f-3c38f89d6ab7.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661685271625409

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Sep 19, 2022

    @melvin-bot

    Triggered auto assignment to @davidcardoza (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Sep 19, 2022
  3. davidcardoza commented on Sep 20, 2022

    @davidcardoza
    Contributor

    I can't reproduce on mobile because I am running on iOS. The workflow looks like fine on iOS though. Either way, what's shown on Android should mirror what's shown in iOS
    IMG_BF83BBE593B2-1

  4. melvin-bot commented on Sep 20, 2022

    @melvin-bot

    Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  5. removed their assignment
    on Sep 20, 2022
  6. melvin-bot commented on Sep 26, 2022

    @melvin-bot

    @cead22 Eep! 4 days overdue now. Issues have feelings too...

  7. cead22 commented on Sep 26, 2022

    @cead22
    Contributor

    This is by design. The button should be disabled because the password hasn't been entered

  8. 111 remaining items

  9. melvin-bot commented on Dec 1, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-12-08. 🎊

    After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  10. melvin-bot commented on Dec 1, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  11. JmillsExpensify commented on Dec 1, 2022

    @JmillsExpensify
    Contributor

    @pecanoro Thanks! Looks like we were slightly ahead of the curve.

  12. JmillsExpensify commented on Dec 5, 2022

    @JmillsExpensify
    Contributor

    @Santhosh-Sellavel @gadhiyamanan Can both of you please make sure to apply for the Upwork job. The correct amounts are here.

    Separately, @Santhosh-Sellavel @pecanoro it would be good to get a head start on the checklist above. Can you check the boxes please and confirm we're good there. I'll separately get started on the regression tests.

    Thanks all!

  13. gadhiyamanan commented on Dec 5, 2022

    @gadhiyamanan
    Contributor

    Applied, thanks

  14. pecanoro commented on Dec 5, 2022

    @pecanoro
    Contributor

    @Santhosh-Sellavel @tgolen We could link the PR when the KeyboardAvoidingView behavior for Android was introduced but I think we always had keyboard issues and this wasn't a new bug but inconsistent behavior of the keyboard itself, right? Unless I am missing something of course.

  15. Santhosh-Sellavel commented on Dec 5, 2022

    @Santhosh-Sellavel
    Collaborator

    Yeah this existed even before that PR #11586

  16. JmillsExpensify commented on Dec 8, 2022

    @JmillsExpensify
    Contributor

    Ok cool, that sounds right to me. Ya'll mind checking off the above. I'll circle back on the regression test tomorrow when I settle up with everyone.

  17. JmillsExpensify commented on Dec 10, 2022

    @JmillsExpensify
    Contributor

    Everyone is paid out at this point. Updating the title to clarity I need to create the regression test issue. Won't be able to get to that today.

  18. changed the title [-][HOLD for payment 2022-12-08] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan[/-] [+][HOLD for regression test] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan[/+] on Dec 10, 2022
  19. JmillsExpensify commented on Dec 12, 2022

    @JmillsExpensify
    Contributor

    @Santhosh-Sellavel @pecanoro @tgolen Regression test is a work in progress and linked to the larger set of keyboard tests we'll kick off as part of the KAV initiative. Accordingly, I've marked the regression test off above. I'm OOO this week, so can you all fill out your part of the BugZero checklist above and then close this issue out? Thank you!

  20. changed the title [-][HOLD for regression test] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan[/-] [+][HOLD for BZ checklist] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan[/+] on Dec 12, 2022
  21. tgolen commented on Dec 12, 2022

    @tgolen
    Contributor

    BZ checklist is done so I will close this out.

  22. mallenexpensify commented on Dec 28, 2022

    @mallenexpensify
    Contributor

    Coming from #10483 (comment)
    We've decided to issue @0xmiroslav a bonus of $1000 because their PR fixed many bugs. I have made the payment on the job https://www.upwork.com/jobs/~015814913e9779f5c9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions