You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for BZ checklist] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan #11087
I can't reproduce on mobile because I am running on iOS. The workflow looks like fine on iOS though. Either way, what's shown on Android should mirror what's shown in iOS
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@JmillsExpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
Separately, @Santhosh-Sellavel@pecanoro it would be good to get a head start on the checklist above. Can you check the boxes please and confirm we're good there. I'll separately get started on the regression tests.
@Santhosh-Sellavel@tgolen We could link the PR when the KeyboardAvoidingView behavior for Android was introduced but I think we always had keyboard issues and this wasn't a new bug but inconsistent behavior of the keyboard itself, right? Unless I am missing something of course.
changed the title [-][HOLD for payment 2022-12-08] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan[/-][+][HOLD for regression test] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan[/+]on Dec 10, 2022
@Santhosh-Sellavel@pecanoro@tgolen Regression test is a work in progress and linked to the larger set of keyboard tests we'll kick off as part of the KAV initiative. Accordingly, I've marked the regression test off above. I'm OOO this week, so can you all fill out your part of the BugZero checklist above and then close this issue out? Thank you!
changed the title [-][HOLD for regression test] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan[/-][+][HOLD for BZ checklist] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan[/+]on Dec 12, 2022
Activity
melvin-bot commentedon Sep 19, 2022
Triggered auto assignment to @davidcardoza (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.davidcardoza commentedon Sep 20, 2022
I can't reproduce on mobile because I am running on iOS. The workflow looks like fine on iOS though. Either way, what's shown on Android should mirror what's shown in iOS

melvin-bot commentedon Sep 20, 2022
Triggered auto assignment to @cead22 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.melvin-bot commentedon Sep 26, 2022
@cead22 Eep! 4 days overdue now. Issues have feelings too...
cead22 commentedon Sep 26, 2022
This is by design. The button should be disabled because the password hasn't been entered
111 remaining items
melvin-bot commentedon Dec 1, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-12-08. 🎊
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Dec 1, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
JmillsExpensify commentedon Dec 1, 2022
@pecanoro Thanks! Looks like we were slightly ahead of the curve.
JmillsExpensify commentedon Dec 5, 2022
@Santhosh-Sellavel @gadhiyamanan Can both of you please make sure to apply for the Upwork job. The correct amounts are here.
Separately, @Santhosh-Sellavel @pecanoro it would be good to get a head start on the checklist above. Can you check the boxes please and confirm we're good there. I'll separately get started on the regression tests.
Thanks all!
gadhiyamanan commentedon Dec 5, 2022
Applied, thanks
pecanoro commentedon Dec 5, 2022
@Santhosh-Sellavel @tgolen We could link the PR when the KeyboardAvoidingView behavior for Android was introduced but I think we always had keyboard issues and this wasn't a new bug but inconsistent behavior of the keyboard itself, right? Unless I am missing something of course.
Santhosh-Sellavel commentedon Dec 5, 2022
Yeah this existed even before that PR #11586
JmillsExpensify commentedon Dec 8, 2022
Ok cool, that sounds right to me. Ya'll mind checking off the above. I'll circle back on the regression test tomorrow when I settle up with everyone.
JmillsExpensify commentedon Dec 10, 2022
Everyone is paid out at this point. Updating the title to clarity I need to create the regression test issue. Won't be able to get to that today.
[-][HOLD for payment 2022-12-08] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan[/-][+][HOLD for regression test] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan[/+]JmillsExpensify commentedon Dec 12, 2022
@Santhosh-Sellavel @pecanoro @tgolen Regression test is a work in progress and linked to the larger set of keyboard tests we'll kick off as part of the KAV initiative. Accordingly, I've marked the regression test off above. I'm OOO this week, so can you all fill out your part of the BugZero checklist above and then close this issue out? Thank you!
[-][HOLD for regression test] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan[/-][+][HOLD for BZ checklist] [$2000] Android - Add Phone number UI not consistent - reported by @gadhiyamanan[/+]tgolen commentedon Dec 12, 2022
BZ checklist is done so I will close this out.
mallenexpensify commentedon Dec 28, 2022
Coming from #10483 (comment)
We've decided to issue @0xmiroslav a bonus of $1000 because their PR fixed many bugs. I have made the payment on the job https://www.upwork.com/jobs/~015814913e9779f5c9