Skip to content

Preselected vendor is not pinned at the top of the vendor list in the expense #106467

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.35-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #104693
Email or phone of affected tester (no customers): fischer9966+110926acc@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: MacOS 26.6.2 / Chrome, Safari. iPhone 17 Pro / 27.2. Google Pixel 5 / Android 14
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com or open app
  2. Login with new user
  3. Create new workspace
  4. Go to workspace settings > Connections
  5. Connect to QBO
  6. Go to QBO configuration > Export > Export company card expenses as
  7. Select Credit card or Debit card and set any default Vendor
  8. Sync QBO
  9. Go to Workspace chat and create non-reimbursable expense
  10. Open expense and go to Vendor field

Expected Result:

Vendor that was selected as default in the QBO configuration should pin at the top of the vendor list in the non-reimbursable expense, already selected. There is "None" option directly below default vendor and the remaining vendors in alphabetical order.

Actual Result:

Vendor that was selected as default in the QBO configuration is not pinned at the top of the vendor list in the expense.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7309851_1794302612706.104693-Web-Fail-preselected-vendor-not-appear.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7309851

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 10, 2026
  2. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #104693

  3. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    @robertjchen @linhvovan29546 you have been assigned to this deploy blocker because you reviewed the offending PR: #104693

  4. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    @marufsharifi you have been assigned to this deploy blocker because you authored the offending PR: #104693

  5. github-actions commented on Nov 10, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. MelvinBot commented on Nov 10, 2026

    @MelvinBot
    Contributor

    Deploy-blocker investigation

    Recommendation: keep the blocker pending targeted verification; do not revert yet. The investigation found a mismatch between the reported expectations and the implementation, but did not confirm a regression.

    Relevant PR: Pin the pre-selected vendor to the top of the vendor picker, merged November 9 at 20:47 UTC and included in the reported staging release.

    What the code establishes

    Why not revert: The pre-PR implementation also selected from the saved expense vendor. Reverting would remove long-list pinning, not provide missing default assignment.

    Required verification

    On the failing expense, establish:

    1. Whether transaction.comment.vendor.externalID exists and matches the configured default.
    2. The number of enabled vendors.
    3. Whether explicitly saving a vendor and reopening the picker with 12+ enabled vendors still fails.

    If those conditions hold, investigate the new ordering path. Otherwise, clarify whether this report concerns default assignment or a requirement to pin short lists—neither is established as a regression from this PR.

    Confidence: High in the implementation findings; unconfirmed root cause for the reported instance. No live browser reproduction or tests were executed.


    view run

  8. marufsharifi commented on Nov 10, 2026

    @marufsharifi

    I think I missed that the QBO default vendor should be auto-selected on a new non-reimbursable expense. I didn't handle that in this PR.

    But in my opinion, this is not a regression from this PR. the pinning only works for a vendor that is already selected on the expense. In this case, no vendor was selected, so there was nothing to pin. That is why it shows in its normal place and not at the top. Selecting the default vendor on the expense is a different step that is not part of this change.

    Could you please help me check:

    1. On the failing expense, was a vendor already selected (checkmarked) in the list?
    2. Should the QBO default vendor be auto-selected on a new non-reimbursable expense?

    Once we agree on the expected behavior, I'm happy to look into it more. Thanks

    cc @linhvovan29546 @robertjchen

  9. robertjchen commented on Nov 10, 2026

    @robertjchen
    Contributor

    Agreed that this isn't a regression from . The QBO default vendor is an export-time fallback and is never written to comment.vendor on the transaction, so on a new unmatched expense there's no selected vendor to pin. This is pre-PR behavior and pinning should only kick in at 12+ enabled vendors. 👍

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions