You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Preselected vendor is not pinned at the top of the vendor list in the expense #106467
Version Number: 9.5.35-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#104693 Email or phone of affected tester (no customers):fischer9966+110926acc@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: MacOS 26.6.2 / Chrome, Safari. iPhone 17 Pro / 27.2. Google Pixel 5 / Android 14 App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com or open app
Login with new user
Create new workspace
Go to workspace settings > Connections
Connect to QBO
Go to QBO configuration > Export > Export company card expenses as
Select Credit card or Debit card and set any default Vendor
Sync QBO
Go to Workspace chat and create non-reimbursable expense
Open expense and go to Vendor field
Expected Result:
Vendor that was selected as default in the QBO configuration should pin at the top of the vendor list in the non-reimbursable expense, already selected. There is "None" option directly below default vendor and the remaining vendors in alphabetical order.
Actual Result:
Vendor that was selected as default in the QBO configuration is not pinned at the top of the vendor list in the expense.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Recommendation: keep the blocker pending targeted verification; do not revert yet. The investigation found a mismatch between the reported expectations and the implementation, but did not confirm a regression.
The PR’s testing instructions require both conditions. This issue’s reproduction does not establish either.
Why not revert: The pre-PR implementation also selected from the saved expense vendor. Reverting would remove long-list pinning, not provide missing default assignment.
Required verification
On the failing expense, establish:
Whether transaction.comment.vendor.externalID exists and matches the configured default.
The number of enabled vendors.
Whether explicitly saving a vendor and reopening the picker with 12+ enabled vendors still fails.
If those conditions hold, investigate the new ordering path. Otherwise, clarify whether this report concerns default assignment or a requirement to pin short lists—neither is established as a regression from this PR.
Confidence: High in the implementation findings; unconfirmed root cause for the reported instance. No live browser reproduction or tests were executed.
I think I missed that the QBO default vendor should be auto-selected on a new non-reimbursable expense. I didn't handle that in this PR.
But in my opinion, this is not a regression from this PR. the pinning only works for a vendor that is already selected on the expense. In this case, no vendor was selected, so there was nothing to pin. That is why it shows in its normal place and not at the top. Selecting the default vendor on the expense is a different step that is not part of this change.
Could you please help me check:
On the failing expense, was a vendor already selected (checkmarked) in the list?
Should the QBO default vendor be auto-selected on a new non-reimbursable expense?
Once we agree on the expected behavior, I'm happy to look into it more. Thanks
Agreed that this isn't a regression from . The QBO default vendor is an export-time fallback and is never written to comment.vendor on the transaction, so on a new unmatched expense there's no selected vendor to pin. This is pre-PR behavior and pinning should only kick in at 12+ enabled vendors. 👍
Activity
applause-bot commentedon Nov 10, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/dc3751738a71b10eee3ab60712afb3256e680b38f6fb50bca3ec3f95f4171f14
https://platform.applause.com/services/links/v1/external/4f60ca423196d0aad85795eb34d216c8844af52bcb8ebab756e223ea9ad6e89f
melvin-bot commentedon Nov 10, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #104693
melvin-bot commentedon Nov 10, 2026
@robertjchen @linhvovan29546 you have been assigned to this deploy blocker because you reviewed the offending PR: #104693
melvin-bot commentedon Nov 10, 2026
@marufsharifi you have been assigned to this deploy blocker because you authored the offending PR: #104693
github-actions commentedon Nov 10, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Nov 10, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Nov 10, 2026
Deploy-blocker investigation
Recommendation: keep the blocker pending targeted verification; do not revert yet. The investigation found a mismatch between the reported expectations and the implementation, but did not confirm a regression.
Relevant PR: Pin the pre-selected vendor to the top of the vendor picker, merged November 9 at 20:47 UTC and included in the reported staging release.
What the code establishes
Why not revert: The pre-PR implementation also selected from the saved expense vendor. Reverting would remove long-list pinning, not provide missing default assignment.
Required verification
On the failing expense, establish:
transaction.comment.vendor.externalIDexists and matches the configured default.If those conditions hold, investigate the new ordering path. Otherwise, clarify whether this report concerns default assignment or a requirement to pin short lists—neither is established as a regression from this PR.
Confidence: High in the implementation findings; unconfirmed root cause for the reported instance. No live browser reproduction or tests were executed.
view run
marufsharifi commentedon Nov 10, 2026
I think I missed that the QBO default vendor should be auto-selected on a new non-reimbursable expense. I didn't handle that in this PR.
But in my opinion, this is not a regression from this PR. the pinning only works for a vendor that is already selected on the expense. In this case, no vendor was selected, so there was nothing to pin. That is why it shows in its normal place and not at the top. Selecting the default vendor on the expense is a different step that is not part of this change.
Could you please help me check:
Once we agree on the expected behavior, I'm happy to look into it more. Thanks
cc @linhvovan29546 @robertjchen
robertjchen commentedon Nov 10, 2026
Agreed that this isn't a regression from . The QBO default vendor is an export-time fallback and is never written to
comment.vendoron the transaction, so on a new unmatched expense there's no selected vendor to pin. This is pre-PR behavior and pinning should only kick in at 12+ enabled vendors. 👍