Skip to content

Pin the pre-selected vendor to the top of the vendor picker - #104693

Merged
robertjchen merged 9 commits into
Expensify:mainfrom
marufsharifi:fix/vendor-pin
Nov 9, 2026
Merged

robertjchen merged 9 commits into
Expensify:mainfrom
marufsharifi:fix/vendor-pin

Conversation

@marufsharifi

@marufsharifi marufsharifi commented Oct 22, 2026 •

Copy link
Copy Markdown

Explanation of Change

Pins the pre-selected vendor to the top of the vendor picker (IOURequestStepVendor), so on a long, searchable list the currently selected vendor is visible on open instead of sitting in its alphabetical position below the fold / under the keyboard.

Fixed Issues

$ #69184
PROPOSAL: #69184 (comment)

Tests

  1. On a workspace with a vendor-matching accounting connection (e.g. QuickBooks
    Online) that has 12 or more vendors, set a default/current vendor on a
    non-reimbursable expense.
  2. Open the expense → tap the Vendor field.
  3. Verify the currently selected vendor is at the top of the list, with the
    None row directly below it, and the remaining vendors in alphabetical order.
  4. Type in the search box → verify the selected vendor stays at the top of the
    results and the None row is hidden.
  5. Tap a different vendor → verify it's applied and the list doesn't visibly
    reshuffle before the page closes.
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen_Recording_20261102_172052_New.Expensify.Dev.mp4
Android: mWeb Chrome
Screen_Recording_20261102_172422_Chrome.mp4
iOS: Native
Screen.Recording.2026-11-02.at.5.35.28.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-11-02.at.5.37.54.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-02.at.5.06.15.PM.mov

@codecov

codecov Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...rc/pages/iou/request/step/IOURequestStepVendor.tsx 90.00% <100.00%> (+90.00%) ⬆️
... and 34 files with indirect coverage changes

@melvin-bot
melvin-bot Bot requested review from linhvovan29546 and removed request for a team November 2, 2026 13:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T14:06:19.895292Z 8e3a6a6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested a review from dylanexpensify November 2, 2026 13:44
@melvin-bot

melvin-bot Bot commented Nov 2, 2026

Copy link
Copy Markdown

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team November 2, 2026 13:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e3a6a63dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

dylanexpensify
dylanexpensify previously approved these changes Nov 3, 2026

@dylanexpensify dylanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from product perspective

@linhvovan29546

Copy link
Copy Markdown
Contributor

@MelvinBot Review

@MelvinBot

MelvinBot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Web test steps verification results: ❌ fail

Blocked on dev NewDot web: the supplied account has no workspaces. No accounting connection, vendors, or expense fixtures were invented; vendor behavior could not be tested.

Workspaces page showing No workspaces yet

Step Status
1. Set a current vendor on a non-reimbursable expense in a connected workspace with at least 12 vendorsBlocked: Workspaces shows “No workspaces yet.” The required accounting-connected fixture is unavailable.
Workspaces page showing No workspaces yet
❌
2. Open the expense and Vendor fieldBlocked: the required workspace expense is unavailable.
❌
3. Selected vendor first, None second, remaining vendors alphabeticalBlocked: no vendor picker fixture is available.
❌
4. Matching and nonmatching searchesBlocked: no selected vendor or vendor list is available.
❌
5. Apply another vendor without visible reshuffle before closingBlocked: no editable vendor expense is available.
❌
6. No JavaScript console errorsUnverified: the supported browser tools do not expose console inspection.
❌
Repeat supported checks offlineBlocked by the missing fixture. The supported browser tools also provide no offline network toggle.
❌

view run · view recording

@marufsharifi

Copy link
Copy Markdown
Author

@linhvovan29546 The PR is ready for review. thanks

@linhvovan29546

linhvovan29546 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-06.at.19.28.41.mov
Android: mWeb Chrome
Screen.Recording.2026-11-06.at.19.25.36.mov
iOS: HybridApp
Screen.Recording.2026-11-06.at.19.33.42.mov
iOS: mWeb Safari
Screen.Recording.2026-11-06.at.19.23.23.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-06.at.19.20.52.mov

@melvin-bot
melvin-bot Bot requested a review from robertjchen November 6, 2026 12:35
@marufsharifi

Copy link
Copy Markdown
Author

@robertjchen, could you please check again when you get a chance. i think it is ready to be merged. thanks.

@robertjchen
robertjchen merged commit c982cca into Expensify:main Nov 9, 2026
37 of 39 checks passed
@OSBotify

OSBotify commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

🚧 robertjchen has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@OSBotify OSBotify mentioned this pull request Nov 9, 2026
72 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.5.35-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No FullStory changes needed — this PR only fixes ordering and scrolling in the existing vendor picker, without adding new controls, screens, user-property values, outcomes, or sensitive content.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR only improves ordering and scrolling in the existing vendor picker; it adds no new workflow and leaves existing article instructions accurate.


view run

@IuliiaHerets

Copy link
Copy Markdown

Hi @marufsharifi. Could you please clarify where exactly the default vendor should be set? The test instructions mention setting a default/current vendor, but they don't specify where or how this should be configured.

сс @robertjchen @dylanexpensify @linhvovan29546

104693-Web-Default-Vendor.mp4

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #106467 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.35-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants