Repository navigation
Pin the pre-selected vendor to the top of the vendor picker - #104693
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e3a6a63dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dylanexpensify
left a comment
There was a problem hiding this comment.
Looks good from product perspective
|
@MelvinBot Review |
|
🤖 Web test steps verification results: ❌ fail Blocked on dev NewDot web: the supplied account has no workspaces. No accounting connection, vendors, or expense fixtures were invented; vendor behavior could not be tested.
|
|
@linhvovan29546 The PR is ready for review. thanks |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-06.at.19.28.41.movAndroid: mWeb ChromeScreen.Recording.2026-11-06.at.19.25.36.moviOS: HybridAppScreen.Recording.2026-11-06.at.19.33.42.moviOS: mWeb SafariScreen.Recording.2026-11-06.at.19.23.23.movMacOS: Chrome / SafariScreen.Recording.2026-11-06.at.19.20.52.mov |
|
@robertjchen, could you please check again when you get a chance. i think it is ready to be merged. thanks. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 robertjchen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.5.35-0 🚀
|
|
No FullStory changes needed — this PR only fixes ordering and scrolling in the existing vendor picker, without adding new controls, screens, user-property values, outcomes, or sensitive content. |
|
No help site update needed — this PR only improves ordering and scrolling in the existing vendor picker; it adds no new workflow and leaves existing article instructions accurate. |
|
Hi @marufsharifi. Could you please clarify where exactly the default vendor should be set? The test instructions mention setting a default/current vendor, but they don't specify where or how this should be configured. сс @robertjchen @dylanexpensify @linhvovan29546 104693-Web-Default-Vendor.mp4 |
|
Deploy Blocker #106467 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.35-3 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Pins the pre-selected vendor to the top of the vendor picker (
IOURequestStepVendor), so on a long, searchable list the currently selected vendor is visible on open instead of sitting in its alphabetical position below the fold / under the keyboard.Fixed Issues
$ #69184
PROPOSAL: #69184 (comment)
Tests
Online) that has 12 or more vendors, set a default/current vendor on a
non-reimbursable expense.
None row directly below it, and the remaining vendors in alphabetical order.
results and the None row is hidden.
reshuffle before the page closes.
Offline tests
Same as Tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen_Recording_20261102_172052_New.Expensify.Dev.mp4
Android: mWeb Chrome
Screen_Recording_20261102_172422_Chrome.mp4
iOS: Native
Screen.Recording.2026-11-02.at.5.35.28.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-11-02.at.5.37.54.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-02.at.5.06.15.PM.mov