You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-28] Expense - Pressing Enter on inline field does not save the edit when bulk editing #107462
Version Number: 9.5.43-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#106067 Email or phone of affected tester (no customers):jdionjodisjsnionj1@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses.
Open the report.
Bulk select the expenses.
Click Edit multiple.
Click Amount field.
Enter amount and press Enter.
Expected Result:
Pressing Enter on inline field will save the edit when bulk editing.
Actual Result:
Pressing Enter on inline field does not save the edit when bulk editing.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Recommendation: roll forward with a targeted keyboard-submission fix.Update the Edit multiple flow to use inline editing introduced the missing wiring. Root-cause confidence is high from static evidence; the proposed fix has not been browser-tested.
What is the root cause of that problem?
The new inline Amount input updates the bulk-edit draft but does not connect Enter to saving. Applying those changes requires the Save button, which has no keyboard-submission shortcut.
The shared Amount input implementation forwards onSubmitEditing without providing a default save callback. The page has no enclosing form submission handler.
The introducing PR appears in the staging release checklist. The affected file is unchanged between its merge and reported staging version 9.5.43-0.
This explains why typing changes the draft while Enter does not apply it, without requiring an API failure. Production impact is not established—the report identifies this as a staging-only new feature.
What changes do you think we should make in order to solve the problem?
Connect Enter submission to the existing save handler, preserving validation and confirmation behavior.
The existing Button.KeyboardShortcut is a candidate for keeping keyboard and pointer submission consistent. However, verify picker interactions before adopting it: its guards exclude multiline editing, but do not guarantee suppression whenever a picker is open.
Required web regression checks:
Enter after changing Amount saves both selected expenses exactly once.
Invalid input cannot save.
Enter in Description preserves multiline editing.
Enter in an open picker selects its option without saving the bulk editor.
What alternative solutions did you explore? (Optional)
Wire Amount’s onSubmitEditing directly to save. This is narrower than a page-wide shortcut if picker-safe keyboard submission cannot be established.
Validation limitation: static investigation only; neither implementation has been runtime-verified.
Next Steps for Contributor+ team: To accept:@MelvinBot implement this proposal to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
What changes do you think we should make in order to solve the problem?
Connect Amount’s onSubmitEditing to a zero-argument callback that invokes the existing save handler. Apply the same focused-input behavior to Merchant, the other plain single-line text field.
Reuse the existing validation and finalized-expense confirmation flow. Leave Description’s multiline behavior and picker keyboard interactions unchanged; do not introduce a page-wide Enter listener.
Type an amount, press Enter, and verify both selected expenses update exactly once with the latest value.
Verify invalid input prevents saving.
Verify finalized expenses still require confirmation.
Verify Merchant supports Enter, Description retains newlines, and picker Enter does not submit the editor.
What alternative solutions did you explore? (Optional)
A Save-button keyboard shortcut could provide page-wide submission, but focused input handlers are narrower and avoid changing Enter behavior elsewhere.
Validation: Root cause verified through static code inspection; the proposed change has not been browser-tested.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/107462) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Expense - Pressing Enter on inline field does not save the edit when bulk editing[/-][+][Due for payment 2026-11-28] Expense - Pressing Enter on inline field does not save the edit when bulk editing[/+]on Nov 21, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.51-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-28. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Nov 19, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/a6a0d1900b4fb3fef7ae68c479e8143517d0121e07cb19120ea6afaa6602d68d
expensify-chore-bot commentedon Nov 19, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #106067
expensify-chore-bot commentedon Nov 19, 2026
@mountiny @ikevin127 you have been assigned to this deploy blocker because you reviewed the offending PR: #106067
expensify-chore-bot commentedon Nov 19, 2026
@DylanDylann you have been assigned to this deploy blocker because you authored the offending PR: #106067
expensify-chore-bot commentedon Nov 19, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 19, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mountiny commentedon Nov 19, 2026
@MelvinBot can you create proposal to fix this?
MelvinBot commentedon Nov 19, 2026
Proposal
Recommendation: roll forward with a targeted keyboard-submission fix. Update the Edit multiple flow to use inline editing introduced the missing wiring. Root-cause confidence is high from static evidence; the proposed fix has not been browser-tested.
What is the root cause of that problem?
The new inline Amount input updates the bulk-edit draft but does not connect Enter to saving. Applying those changes requires the Save button, which has no keyboard-submission shortcut.
Supporting evidence and release attribution
onSubmitEditing.saveonly throughonPress.onSubmitEditingwithout providing a default save callback. The page has no enclosing form submission handler.This explains why typing changes the draft while Enter does not apply it, without requiring an API failure. Production impact is not established—the report identifies this as a staging-only new feature.
What changes do you think we should make in order to solve the problem?
Connect Enter submission to the existing
savehandler, preserving validation and confirmation behavior.The existing
Button.KeyboardShortcutis a candidate for keeping keyboard and pointer submission consistent. However, verify picker interactions before adopting it: its guards exclude multiline editing, but do not guarantee suppression whenever a picker is open.Required web regression checks:
What alternative solutions did you explore? (Optional)
Wire Amount’s
onSubmitEditingdirectly tosave. This is narrower than a page-wide shortcut if picker-safe keyboard submission cannot be established.Validation limitation: static investigation only; neither implementation has been runtime-verified.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement this proposalto create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
MelvinBot commentedon Nov 19, 2026
Proposal
What is the root cause of that problem?
The inline Amount input updates the bulk-edit draft but has no Enter submission handler. Only clicking Save invokes the existing save flow.
Code evidence
onSubmitEditing.onPressonly.What changes do you think we should make in order to solve the problem?
Connect Amount’s
onSubmitEditingto a zero-argument callback that invokes the existingsavehandler. Apply the same focused-input behavior to Merchant, the other plain single-line text field.Reuse the existing validation and finalized-expense confirmation flow. Leave Description’s multiline behavior and picker keyboard interactions unchanged; do not introduce a page-wide Enter listener.
Add regression coverage to the bulk-edit page tests:
What alternative solutions did you explore? (Optional)
A Save-button keyboard shortcut could provide page-wide submission, but focused input handlers are narrower and avoid changing Enter behavior elsewhere.
Validation: Root cause verified through static code inspection; the proposed change has not been browser-tested.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/107462)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
Fix Edit multiple deploy blockers from #106067
IuliiaHerets commentedon Nov 20, 2026
Issue is not repro on Windows 10/Chrome/Build 9.5.49-1
2026-11-20.11-36-03.mp4
[-]Expense - Pressing Enter on inline field does not save the edit when bulk editing[/-][+][Due for payment 2026-11-28] Expense - Pressing Enter on inline field does not save the edit when bulk editing[/+]melvin-bot commentedon Nov 21, 2026
@ikevin127 / @Krishna2323 / @DylanDylann
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.51-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-28. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]