Repository navigation
Conversation
- Let the first tap with the keyboard open reach the field (Expensify#107460) - Save from Enter, matching the expense form (Expensify#107462) - Close the keyboard from the amount's Done key (Expensify#107463) - Show list headers on every layout for Category, Reimbursable and Billable (Expensify#107465) - Move Save into the scroll view in landscape with the keyboard open (Expensify#107468) Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@ikevin127 @DylanDylann One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApppr107490-android.mp4iOS: Nativepr107490-ios.mp4MacOS: Chrome / Safaripr107490-ctest.mp4pr107490-ctest-narrow.mp4pr107490-ctest-short.mp4 |
… open Signed-off-by: krishna2323 <belivethatkg@gmail.com>
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM - All tests passed, good to merge
|
🚧 marcaaron has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.5.49-1 🚀
|
|
No help site update needed — this PR fixes keyboard interactions and layout in the beta-gated bulk-edit workflow without adding a public feature, removing the beta gate, or making existing article instructions incorrect. |
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixes the five deploy blockers from #106067 on the Edit multiple page. Each fix follows a pattern the app already uses elsewhere:
keyboardShouldPersistTaps="handled", asTextInputFilterContentand the expense form (ConfirmationListLayout) do.AddExistingExpenseFooterdo. In Description, Enter saves with a hardware keyboard and Shift+Enter adds a new line. On touch devices Enter adds a new line, the same asDescriptionFieldon the expense form.AmountFormField.Inputnow accepts asubmitBehavioroverride. Its default is stillsubmit, soAmountFormis unchanged. This page passesblurAndSubmit, as the other inline amount inputs do (SplitAmountInput,EditableTotalAmountInput).CategoryPickerModalnow passesshouldShowHeaderthrough to the popover, asTaxPickerModalandTagPickerModaldo. The add button is still shown only to users who can create a category. The three rows also reserve room for the header when they work out where the list fits.useShouldFooterBeInsideList, as the expense form andTextInputFilterContentdo.Fixed Issues
$ #107460
$ #107462
$ #107463
$ #107465
$ #107468
PROPOSAL: N/A, deploy blocker fixes for #106067
Tests
Precondition: the
bulkEditbeta is on. A workspace has categories, attendee tracking (in Rules), billable and reimbursable enabled. The workspace has at least two expenses on an open report. Open the report, select both expenses and choose Edit multiple.Web: Enter saves (#107462)
(none)as the merchant and press Enter. Verify the error shows and nothing is saved.Web: List headers (#107465)
Android: Keyboard taps (#107460)
Android and iOS: Done key (#107463)
Android and iOS: Landscape (#107468)
Offline tests
QA Steps
Same as Tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_hybrid_1.mp4
android_hybrid_2.mp4
android_hybrid_3.mp4
Android: mWeb Chrome
iOS: Native
ios_hybrid_1.mp4
ios_hybrid_2.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
web_chrome.mp4