Skip to content

Fix Edit multiple deploy blockers from #106067 - #107490

Merged
marcaaron merged 3 commits into
Expensify:mainfrom
Krishna2323:krishna/106067-bulk-edit-deploy-blockers
Nov 20, 2026
Merged

marcaaron merged 3 commits into
Expensify:mainfrom
Krishna2323:krishna/106067-bulk-edit-deploy-blockers

Conversation

@Krishna2323

@Krishna2323 Krishna2323 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixes the five deploy blockers from #106067 on the Edit multiple page. Each fix follows a pattern the app already uses elsewhere:

Fixed Issues

$ #107460
$ #107462
$ #107463
$ #107465
$ #107468
PROPOSAL: N/A, deploy blocker fixes for #106067

Tests

Precondition: the bulkEdit beta is on. A workspace has categories, attendee tracking (in Rules), billable and reimbursable enabled. The workspace has at least two expenses on an open report. Open the report, select both expenses and choose Edit multiple.

Web: Enter saves (#107462)

  1. Type an amount in Amount and press Enter. Verify the page closes and both expenses get the amount.
  2. Open Edit multiple again. Type a merchant and press Enter. Verify both expenses get the merchant.
  3. Open Edit multiple again. In Description, type a line, press Shift+Enter, then type a second line. Verify a new line is added. Press Enter and verify both expenses get the two-line description.
  4. Open Edit multiple again. Open Category and press Enter before using the arrow keys. Verify nothing is picked and the page does not save. Then move to an option with the arrow keys and press Enter. Verify the category is picked and the page does not save. Repeat for Reimbursable, Billable and the currency picker on the Amount row.
  5. Type (none) as the merchant and press Enter. Verify the error shows and nothing is saved.

Web: List headers (#107465)

  1. In a wide window, open Category, Reimbursable and Billable in turn. Verify each list shows its field name as a header, as Tag and Tax do.
  2. Open Category. Verify the header shows "Category" and there is no + button, since Edit multiple does not offer adding a category.
  3. Resize the window to narrow and repeat step 6. Verify the headers still show in the bottom sheet.
  4. Make the window wide but short, about 450px tall. Open Category, Reimbursable and Billable. Verify each list still opens and can be scrolled.

Android: Keyboard taps (#107460)

  1. Open Edit multiple again. Tap Attendees, then tap the search field and type any text.
  2. With the keyboard open, tap the clear button once. Verify the search clears on that tap.
  3. Tap the search field again. With the keyboard open, tap a user once. Verify the user is selected on that tap.
  4. Dismiss the list. Tap Amount so the keyboard opens, then tap Category once. Verify the category list opens on that tap.
  5. With the keyboard closed, tap an empty part of the page. Verify nothing breaks.

Android and iOS: Done key (#107463)

  1. Tap Amount, type an amount and tap Done on the keyboard. Verify the keyboard closes and the amount stays in the field.
  2. Press Save. Verify both expenses get the amount.
  3. On a touch device, tap Description, type a line and tap Return. Verify a new line is added and the page does not save.

Android and iOS: Landscape (#107468)

  1. Open Edit multiple again. Rotate the device to landscape. Tap Description. Verify Save is no longer pinned above the keyboard and the Description field is visible.
  2. Scroll down. Verify Save is at the end of the fields and saving updates both expenses.
  3. Close the keyboard. Verify Save returns to the bottom of the page.
  4. Rotate back to portrait with Description focused. Verify Save sits at the bottom again.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline and run steps 1 and 15–16. Verify the edits apply optimistically and sync when you go back online.

QA Steps

  • Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_hybrid_1.mp4
android_hybrid_2.mp4
android_hybrid_3.mp4
Android: mWeb Chrome
iOS: Native
ios_hybrid_1.mp4
ios_hybrid_2.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
web_chrome.mp4

- Let the first tap with the keyboard open reach the field (Expensify#107460)
- Save from Enter, matching the expense form (Expensify#107462)
- Close the keyboard from the amount's Done key (Expensify#107463)
- Show list headers on every layout for Category, Reimbursable and Billable (Expensify#107465)
- Move Save into the scroll view in landscape with the keyboard open (Expensify#107468)

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Krishna2323 marked this pull request as ready for review November 20, 2026 00:19
@Krishna2323
Krishna2323 requested review from a team as code owners November 20, 2026 00:19
@expensify-chore-bot
expensify-chore-bot Bot removed the request for review from a team November 20, 2026 00:19
@expensify-chore-bot

Copy link
Copy Markdown

@ikevin127 @DylanDylann One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T00:34:17.953266Z d0eac95 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@expensify-chore-bot
expensify-chore-bot Bot removed the request for review from a team November 20, 2026 00:19
@ikevin127

ikevin127 commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
pr107490-android.mp4
iOS: Native
pr107490-ios.mp4
MacOS: Chrome / Safari
pr107490-ctest.mp4
pr107490-ctest-narrow.mp4
pr107490-ctest-short.mp4

trjExpensify
trjExpensify previously approved these changes Nov 20, 2026

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB fixes. 👍

@ikevin127 ikevin127 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for one non-blocker. Enter can save the page while the Category, Reimbursable or Billable list is open with no row focused. Please also add that case to the Tests.

🔄 Proceeding with manual testing.

Comment thread tests/ui/SearchEditMultiplePageTest.tsx Resolved
… open

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

@ikevin127 ikevin127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM - All tests passed, good to merge

@melvin-bot
melvin-bot Bot requested a review from mountiny November 20, 2026 02:31
@marcaaron
marcaaron merged commit 51819f2 into Expensify:main Nov 20, 2026
49 of 79 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 marcaaron has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

OSBotify pushed a commit that referenced this pull request Nov 20, 2026
…deploy-blockers

Fix Edit multiple deploy blockers from #106067

(cherry picked from commit 51819f2)

(cherry-picked to staging by marcaaron)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 20, 2026
@os-botify

os-botify Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🔁 Filed a Staging retest request for deploy blockers #107460, #107462, #107463, #107465, #107468 after this PR was cherry-picked to staging.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.5.49-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR fixes keyboard interactions and layout in the beta-gated bulk-edit workflow without adding a public feature, removing the beta gate, or making existing article instructions incorrect.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.5.51-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants