Skip to content

[Due for payment 2026-11-28] Bulk edit expense - Reimbursable dropdown does not show header title on wide screen #107465

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.43-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #106067
Email or phone of affected tester (no customers): joinsdjosjdojosijdiosnj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Enabled bulkEdit beta

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses.
  4. Open the report.
  5. Bulk select the expenses.
  6. Click Edit multiple.
  7. Click Reimbursable field.
    → Reimbursable dropdown does not have header title.
  8. Resize window to narrow.
    → Reimbursable dropdown shows header title.

Expected Result:

On wide screen, Reimbursable dropdown will show header title (similar to narrow window).

Actual Result:

On wide screen, Reimbursable dropdown does not show header title.

This issue also happens with category and billable dropdown.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7319375_1795120549480.5.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7319375

Issue OwnerCurrent Issue Owner: @ikevin127

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 19, 2026
  2. applause-bot commented on Nov 19, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/0cb0b28e930bcd616ed9d97a2f8979fc341dafa6c4b18a5b482722ce604ab88a

  3. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #106067

  4. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    @mountiny @ikevin127 you have been assigned to this deploy blocker because you reviewed the offending PR: #106067

  5. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    @DylanDylann you have been assigned to this deploy blocker because you authored the offending PR: #106067

  6. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 19, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. mountiny commented on Nov 19, 2026

    @mountiny
    Contributor

    @MelvinBot can you create proposal to fix this?

  9. MelvinBot commented on Nov 19, 2026

    @MelvinBot
    Contributor

    Deploy blocker investigation

    Introducing PR: [CFI] Update the Edit multiple flow to use inline editing and dropdown down style rows — high-confidence attribution. Its deployment record confirms staging version 9.5.43-0.

    Recommendation: Seek design confirmation and demote this blocker if the intended desktop behavior is confirmed. Do not revert the entire editing-flow change for this heading discrepancy alone. No labels were changed.

    Proposal

    What is the root cause of that problem?

    The desktop omission is explicit rendering logic, not a missing translation or backend failure:

    Whether this constitutes a bug remains unresolved. The PR’s design discussion explicitly discourages repeating desktop field labels while retaining mobile headings. That discussion concerns tags, so it supports—but does not conclusively approve—the Boolean fields’ behavior.

    What changes do you think we should make in order to solve the problem?

    First, have the design owner reconcile the reported expectation with that guidance.

    Only if desktop headings are required: enable the Boolean heading at both widths and allow bulk Category to request a heading independently of category-creation permissions. Keep the change scoped to these callers.

    What alternative solutions did you explore?

    Reverting the introducing PR would restore the older titled pages but is disproportionate to this isolated presentation issue. Other blockers attributed to that PR were not investigated and could independently justify a revert.

    Verification limitation: This investigation traced code, history, deployment evidence, and design discussion; no interactive browser reproduction was performed. Category’s narrow-screen behavior remains unverified.


    Next Steps for Contributor+ team: Confirm the intended desktop design before accepting an implementation proposal or removing the blocker label.


    view run

  10. MelvinBot commented on Nov 19, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    Header visibility is controlled differently for these fields:

    • Reimbursable and Billable: their shared dropdown explicitly shows its heading only on narrow screens.
    • Category: its heading depends on an add-category callback that bulk editing does not supply. Consequently, this dropdown lacks a heading at both widths—not just desktop.
    Code evidence and design consideration

    Design confirmation is needed: desktop suppression is intentional in the Boolean component, and the existing tag design discussion discourages repeating desktop field labels. The proposal below follows this issue’s stated expectation.

    What changes do you think we should make in order to solve the problem?

    Once desktop headings are confirmed:

    1. Always enable the heading in the shared Boolean dropdown, covering both Reimbursable and Billable.
    2. Add an optional header opt-in to Category’s modal, independent of category-creation permissions. Enable it for bulk editing only; preserve existing behavior elsewhere and keep the Add action permission-gated.
    3. Include the header height in all three parent field rows so positioning and limited-height fallback account for the additional content.
    Implementation scope and verification

    Update the three field rows using the existing listHeaderHeight mechanism.

    Add regression coverage for:

    • All three headings at wide and narrow widths.
    • Category heading visibility without exposing Add.
    • Unchanged non-bulk Category behavior.
    • Short-viewport positioning, selection, and dismissal.

    Source investigation only; browser verification and test execution have not been performed.

    What alternative solutions did you explore? (Optional)

    Changing the shared popover’s default would affect unrelated dropdowns. Supplying a dummy add-category callback would incorrectly expose an Add action. Neither is appropriately scoped.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/107465) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  11. IuliiaHerets commented on Nov 20, 2026

    @IuliiaHerets

    Issue is not reproducible/Windows 11/Chrome/v9.5.49-1

    1772.mp4
  12. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 20, 2026
  13. changed the title [-]Bulk edit expense - Reimbursable dropdown does not show header title on wide screen[/-] [+][Due for payment 2026-11-28] Bulk edit expense - Reimbursable dropdown does not show header title on wide screen[/+] on Nov 21, 2026
  14. melvin-bot commented on Nov 21, 2026

    @melvin-bot

    @ikevin127 / @Krishna2323 / @DylanDylann

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.51-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-28. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions