Skip to content

Deploy Checklist: New Expensify 2022-09-01 #10748

Closed

Description

@OSBotify

Release Version: 1.1.96-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

Activity

  1. OSBotify commented on Sep 1, 2022

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.96-0 🚀

  2. mvtglobally commented on Sep 2, 2022

    @mvtglobally

    Regression is completed

    Deploy Blockers
    #10442
    #10751
    #10753
    #10754
    #10756
    #10757
    #10759

    PR #9532 is failing due to #10751 & #10766
    PR #10556 is failing due to #10758.
    PR #10582 & #10717 are failing due to #10751

  3. OSBotify commented on Sep 2, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.96-1 🚀

  4. OSBotify commented on Sep 2, 2022

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-1 has been deployed to staging 🎉

  5. roryabraham commented on Sep 2, 2022

    @roryabraham
    Contributor

    Tried reverting #10582 and was able to reproduce the crash on that branch, so I don't think it's that

  6. OSBotify commented on Sep 2, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.96-2 🚀

  7. OSBotify commented on Sep 2, 2022

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-2 has been deployed to staging 🎉

  8. OSBotify commented on Sep 2, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.96-4 🚀

  9. OSBotify commented on Sep 2, 2022

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-4 has been deployed to staging 🎉

  10. OSBotify commented on Sep 2, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.96-5 🚀

  11. luacmartins commented on Sep 2, 2022

    @luacmartins
    Contributor
  12. mvtglobally commented on Sep 2, 2022

    @mvtglobally

    @luacmartins we will check and confirm in a bit

  13. 8 remaining items

  14. PauloGasparSv commented on Sep 2, 2022

    @PauloGasparSv
    Contributor

    I think we can check #10780 off as @mvtglobally said and address that on the follow up issue if that's ok! Because the offline-first and delete functionality are working despite the message quickly popping up before being deleted when toggling!

    Is that ok?

  15. mvtglobally commented on Sep 2, 2022

    @mvtglobally

    PR #10556 is failing due to #10758. Still seems to be broken

    Recording.1064.mp4
    Screen_Recording_20220902-111516_Chrome.mp4
  16. luacmartins commented on Sep 2, 2022

    @luacmartins
    Contributor

    @mvtglobally can you test with an account that hasn't attempted to send the link more than 3 times? I think the reason the message doesn't show up is because we never send the link since that account is throttled.

    For now, the error message won't show up the first time you click Forgot? since we will fix the error message in a follow up PR in our API layer.

  17. mvtglobally commented on Sep 2, 2022

    @mvtglobally

    Checking off #10582 - retest pass.
    #10556 is the last one left.

  18. bondydaa commented on Sep 2, 2022

    @bondydaa
    Contributor

    yep agreed can you confirm that you're not actually throttled in these #10748 (comment)?

    Users are throttled after on the 4th attempt within 5 minutes of each other: so you should be able to click it 3 times and get magic links sent and then a 4th should give you that error.

  19. mvtglobally commented on Sep 2, 2022

    @mvtglobally

    New account seem ok. When you use re-set password it is showing automatically the message,

    But can you guys re-validate this last one internally as well, to make sure we dont miss anything here.

    Recording.1065.mp4
  20. bondydaa commented on Sep 2, 2022

    @bondydaa
    Contributor

    When you use re-set password it is showing automatically the message

    yep that's expected for now will be fixed on #10785.

    I just tried this myself (hours after those initial attempts) and got the same message for those accounts which is unexpected
    image

    logs https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%22744792dfda233839-SAN%22)+AND+timestamp:[2022-09-02T15:20:33.984Z+TO+2022-09-02T17:20:33.984Z]&index=logs_expensify-018393

    744792dfda233839-SAN | 2022-09-02 16:20:33 987 | mnata.utest+sr@gmail.com | undefined | db1.sjc | [audit] User just got throttled because they reached 3 number of calls for resendValidateCode
    
    dbondy@db2.rno:~$ sudo readdb.sh -line "SELECT name, value FROM nameValuePairs WHERE name like 'private_throttleAttempts_resendValidateCode%' and accountid=12451070;"
     name = private_throttleAttempts_resendValidateCode
    value = [1662135599059757,1662135601949561,1662135632575400,1662135633987843]
    
     name = private_throttleAttempts_resendValidateCode-212.231.184.140
    value = [1662135599059930,1662135601949716,1662135632575547]
    
     name = private_throttleAttempts_resendValidateCode-99.235.190.147
    value = [1662050591612159]
    

    But if anything this is something broken in auth not this code - new dot is actually handling this well and showing us the error now 🎉

  21. mvtglobally commented on Sep 2, 2022

    @mvtglobally

    @bondydaa Are we ok to check it off then?

  22. bondydaa commented on Sep 2, 2022

    @bondydaa
    Contributor

    hm strange and I just tried again and it worked fine for mnata.utest+sr@gmail.com
    image

    looking at the db again, the throttle attempts had been cleared out and only 2 show now

    dbondy@db2.rno:~$ sudo readdb.sh -line "SELECT name, value FROM nameValuePairs WHERE name like 'private_throttleAttempts_resendValidateCode%' and accountid=12451070;"
     name = private_throttleAttempts_resendValidateCode
    value = [1662138028209658,1662138031477769]
    
     name = private_throttleAttempts_resendValidateCode-212.231.184.140
    value = [1662138028209808,1662138031477953]
    
     name = private_throttleAttempts_resendValidateCode-99.235.190.147
    value = [1662050591612159]
    dbondy@db2.rno:~$
    

    Just copying over from Slack I tested with a brand new account

    1. created a new account, clicked resend validation link 3 times and got this image (1)
    2. on the 4th click of resend validation link got the error as expected: image (2)
    3. And got 4 emails as expected (when you first create the account we send you a validation link and then the 3 from the repeated clicking of resend validation link). image (3)

    So yep I think 👍 to check it off.

  23. mvtglobally commented on Sep 2, 2022

    @mvtglobally

    We are good to 🚀 then

  24. Julesssss commented on Sep 5, 2022

    @Julesssss
    Contributor

    Awesome, we're good to deploy first thing this morning.

    • I rechecked the timing dash and there are no noticeable timing regressions.
    • I see one new exception here. I haven't been able to reproduce yet as the logs are a bit vague. Posting in #deployer before I move forward.
  25. Julesssss commented on Sep 5, 2022

    @Julesssss
    Contributor

    From testing the app I'm still unable to find any exception. Going to move forward as Applause's checklist would have picked up on any noticable regression.

  26. Julesssss commented on Sep 5, 2022

    @Julesssss
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions