You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we can check #10780 off as @mvtglobally said and address that on the follow up issue if that's ok! Because the offline-first and delete functionality are working despite the message quickly popping up before being deleted when toggling!
@mvtglobally can you test with an account that hasn't attempted to send the link more than 3 times? I think the reason the message doesn't show up is because we never send the link since that account is throttled.
For now, the error message won't show up the first time you click Forgot? since we will fix the error message in a follow up PR in our API layer.
yep agreed can you confirm that you're not actually throttled in these #10748 (comment)?
Users are throttled after on the 4th attempt within 5 minutes of each other: so you should be able to click it 3 times and get magic links sent and then a 4th should give you that error.
744792dfda233839-SAN | 2022-09-02 16:20:33 987 | mnata.utest+sr@gmail.com | undefined | db1.sjc | [audit] User just got throttled because they reached 3 number of calls for resendValidateCode
dbondy@db2.rno:~$ sudo readdb.sh -line "SELECT name, value FROM nameValuePairs WHERE name like 'private_throttleAttempts_resendValidateCode%' and accountid=12451070;"
name = private_throttleAttempts_resendValidateCode
value = [1662135599059757,1662135601949561,1662135632575400,1662135633987843]
name = private_throttleAttempts_resendValidateCode-212.231.184.140
value = [1662135599059930,1662135601949716,1662135632575547]
name = private_throttleAttempts_resendValidateCode-99.235.190.147
value = [1662050591612159]
But if anything this is something broken in auth not this code - new dot is actually handling this well and showing us the error now 🎉
hm strange and I just tried again and it worked fine for mnata.utest+sr@gmail.com
looking at the db again, the throttle attempts had been cleared out and only 2 show now
dbondy@db2.rno:~$ sudo readdb.sh -line "SELECT name, value FROM nameValuePairs WHERE name like 'private_throttleAttempts_resendValidateCode%' and accountid=12451070;"
name = private_throttleAttempts_resendValidateCode
value = [1662138028209658,1662138031477769]
name = private_throttleAttempts_resendValidateCode-212.231.184.140
value = [1662138028209808,1662138031477953]
name = private_throttleAttempts_resendValidateCode-99.235.190.147
value = [1662050591612159]
dbondy@db2.rno:~$
Just copying over from Slack I tested with a brand new account
created a new account, clicked resend validation link 3 times and got this
on the 4th click of resend validation link got the error as expected:
And got 4 emails as expected (when you first create the account we send you a validation link and then the 3 from the repeated clicking of resend validation link).
From testing the app I'm still unable to find any exception. Going to move forward as Applause's checklist would have picked up on any noticable regression.
Activity
OSBotify commentedon Sep 1, 2022
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.96-0 🚀
mvtglobally commentedon Sep 2, 2022
Regression is completed
Deploy Blockers
#10442
#10751
#10753
#10754
#10756
#10757
#10759
PR #9532 is failing due to #10751 & #10766
PR #10556 is failing due to #10758.
PR #10582 & #10717 are failing due to #10751
OSBotify commentedon Sep 2, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.96-1🚀OSBotify commentedon Sep 2, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-1 has been deployed to staging 🎉
roryabraham commentedon Sep 2, 2022
Tried reverting #10582 and was able to reproduce the crash on that branch, so I don't think it's that
OSBotify commentedon Sep 2, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.96-2🚀OSBotify commentedon Sep 2, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-2 has been deployed to staging 🎉
OSBotify commentedon Sep 2, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.96-4🚀OSBotify commentedon Sep 2, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-4 has been deployed to staging 🎉
OSBotify commentedon Sep 2, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.96-5🚀luacmartins commentedon Sep 2, 2022
@mvtglobally @kbecciv can you still reproduce the following issues?
We are having issues reproducing these locally and on staging.
mvtglobally commentedon Sep 2, 2022
@luacmartins we will check and confirm in a bit
8 remaining items
PauloGasparSv commentedon Sep 2, 2022
I think we can check #10780 off as @mvtglobally said and address that on the follow up issue if that's ok! Because the offline-first and delete functionality are working despite the message quickly popping up before being deleted when toggling!
Is that ok?
mvtglobally commentedon Sep 2, 2022
PR #10556 is failing due to #10758. Still seems to be broken
Recording.1064.mp4
Screen_Recording_20220902-111516_Chrome.mp4
luacmartins commentedon Sep 2, 2022
@mvtglobally can you test with an account that hasn't attempted to send the link more than 3 times? I think the reason the message doesn't show up is because we never send the link since that account is throttled.
For now, the error message won't show up the first time you click
Forgot?since we will fix the error message in a follow up PR in our API layer.mvtglobally commentedon Sep 2, 2022
Checking off #10582 - retest pass.
#10556 is the last one left.
bondydaa commentedon Sep 2, 2022
yep agreed can you confirm that you're not actually throttled in these #10748 (comment)?
Users are throttled after on the 4th attempt within 5 minutes of each other: so you should be able to click it 3 times and get magic links sent and then a 4th should give you that error.
mvtglobally commentedon Sep 2, 2022
New account seem ok. When you use re-set password it is showing automatically the message,
But can you guys re-validate this last one internally as well, to make sure we dont miss anything here.
Recording.1065.mp4
bondydaa commentedon Sep 2, 2022
yep that's expected for now will be fixed on #10785.
I just tried this myself (hours after those initial attempts) and got the same message for those accounts which is unexpected

logs https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%22744792dfda233839-SAN%22)+AND+timestamp:[2022-09-02T15:20:33.984Z+TO+2022-09-02T17:20:33.984Z]&index=logs_expensify-018393
But if anything this is something broken in auth not this code - new dot is actually handling this well and showing us the error now 🎉
mvtglobally commentedon Sep 2, 2022
@bondydaa Are we ok to check it off then?
bondydaa commentedon Sep 2, 2022
hm strange and I just tried again and it worked fine for

mnata.utest+sr@gmail.comlooking at the db again, the throttle attempts had been cleared out and only 2 show now
Just copying over from Slack I tested with a brand new account
So yep I think 👍 to check it off.
mvtglobally commentedon Sep 2, 2022
We are good to 🚀 then
Julesssss commentedon Sep 5, 2022
Awesome, we're good to deploy first thing this morning.
Julesssss commentedon Sep 5, 2022
From testing the app I'm still unable to find any exception. Going to move forward as Applause's checklist would have picked up on any noticable regression.
Julesssss commentedon Sep 5, 2022